Make gauss and box-mueller not mix precision with float16_t

devshgraphicsprogramming · devshgraphicsprogramming · commit b1633b135191 · 2026-03-31T16:12:59.000+02:00
diff --git a/examples_tests b/examples_tests
@@ -1 +1 @@
-Subproject commit 5d3b3b27a9b4534ac086e55ab0dee2a26d74e67b
+Subproject commit 9f89a9e0a8362728924b12bcb131fe97e4037a10
diff --git a/include/nbl/builtin/hlsl/path_tracing/gaussian_filter.hlsl b/include/nbl/builtin/hlsl/path_tracing/gaussian_filter.hlsl
@@ -21,15 +21,15 @@ struct GaussianFilter
     static this_t create(const scalar_type gaussianFilterCutoff, const scalar_type stddev)
     {
         this_t retval;
-        retval.truncation = hlsl::exp(-0.5 * gaussianFilterCutoff * gaussianFilterCutoff);
+        retval.truncation = hlsl::exp(-scalar_type(0.5) * gaussianFilterCutoff * gaussianFilterCutoff);
         retval.boxMuller.stddev = stddev;
         return retval;
     }
 
     vector2_type sample(const vector2_type randVec)
     {
         vector2_type remappedRand = randVec;
-        remappedRand.x *= 1.0 - truncation;
+        remappedRand.x *= scalar_type(1) - truncation;
         remappedRand.x += truncation;
         return boxMuller(remappedRand);
     }
diff --git a/include/nbl/builtin/hlsl/sampling/box_muller_transform.hlsl b/include/nbl/builtin/hlsl/sampling/box_muller_transform.hlsl
@@ -24,8 +24,8 @@ struct BoxMullerTransform
     vector2_type operator()(const vector2_type xi)
     {
         scalar_type sinPhi, cosPhi;
-        math::sincos<scalar_type>(2.0 * numbers::pi<scalar_type> * xi.y - numbers::pi<scalar_type>, sinPhi, cosPhi);
-        return vector2_type(cosPhi, sinPhi) * nbl::hlsl::sqrt(-2.0 * nbl::hlsl::log(xi.x)) * stddev;
+        math::sincos<scalar_type>(scalar_type(2) * numbers::pi<scalar_type> * xi.y - numbers::pi<scalar_type>, sinPhi, cosPhi);
+        return vector2_type(cosPhi, sinPhi) * nbl::hlsl::sqrt(scalar_type(-2) * nbl::hlsl::log(xi.x)) * stddev;
     }
 
     vector2_type backwardPdf(const vector2_type outPos)

Original file line number	Diff line number	Diff line change
`@@ -21,15 +21,15 @@ struct GaussianFilter`
`21`	`21`	`static this_t create(const scalar_type gaussianFilterCutoff, const scalar_type stddev)`
`22`	`22`	`{`
`23`	`23`	`this_t retval;`
`24`		`- retval.truncation = hlsl::exp(-0.5 * gaussianFilterCutoff * gaussianFilterCutoff);`
	`24`	`+ retval.truncation = hlsl::exp(-scalar_type(0.5) * gaussianFilterCutoff * gaussianFilterCutoff);`
`25`	`25`	`retval.boxMuller.stddev = stddev;`
`26`	`26`	`return retval;`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`vector2_type sample(const vector2_type randVec)`
`30`	`30`	`{`
`31`	`31`	`vector2_type remappedRand = randVec;`
`32`		`- remappedRand.x *= 1.0 - truncation;`
	`32`	`+ remappedRand.x *= scalar_type(1) - truncation;`
`33`	`33`	`remappedRand.x += truncation;`
`34`	`34`	`return boxMuller(remappedRand);`
`35`	`35`	`}`
Original file line number	Diff line number	Diff line change
`@@ -24,8 +24,8 @@ struct BoxMullerTransform`
`24`	`24`	`vector2_type operator()(const vector2_type xi)`
`25`	`25`	`{`
`26`	`26`	`scalar_type sinPhi, cosPhi;`
`27`		`- math::sincos<scalar_type>(2.0 * numbers::pi<scalar_type> * xi.y - numbers::pi<scalar_type>, sinPhi, cosPhi);`
`28`		`- return vector2_type(cosPhi, sinPhi) * nbl::hlsl::sqrt(-2.0 * nbl::hlsl::log(xi.x)) * stddev;`
	`27`	`+ math::sincos<scalar_type>(scalar_type(2) * numbers::pi<scalar_type> * xi.y - numbers::pi<scalar_type>, sinPhi, cosPhi);`
	`28`	`+ return vector2_type(cosPhi, sinPhi) * nbl::hlsl::sqrt(scalar_type(-2) * nbl::hlsl::log(xi.x)) * stddev;`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`vector2_type backwardPdf(const vector2_type outPos)`