fix(bindings) : Python examples not working#47
Conversation
da522f2 to
33096b0
Compare
LCOV of commit
|
f857f1b to
0d5e191
Compare
|
@xuanhien070594 sorry for the delay, setting up CI took sometime. Should be good to review now. |
|
Do we need to pin down python version? |
|
we already have |
|
These two lines look interesting. What do they serve? |
|
Previously, xuanhien070594 (Hien Bui) wrote…
Nvm, you just want to check whether or not calling lcs.A() fails, right? |
|
This function is not used anywhere in this file. |
|
This function is also not used anywhere. |
xuanhien070594
left a comment
There was a problem hiding this comment.
@xuanhien070594 reviewed 16 files and all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on Meow404).
Meow404
left a comment
There was a problem hiding this comment.
@Meow404 made 5 comments.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on xuanhien070594).
.cirrus.yml line 16 at r1 (raw file):
Previously, xuanhien070594 (Hien Bui) wrote…
Do we need to pin down python version?
I'm using the system python version. Are you referring to these or the python package versions?
bindings/pyc3/test_c3_smoke.py line 46 at r1 (raw file):
Previously, xuanhien070594 (Hien Bui) wrote…
Nvm, you just want to check whether or not calling lcs.A() fails, right?
Yes that's right!
bindings/pyc3/test/test_c3.py line 145 at r1 (raw file):
Previously, xuanhien070594 (Hien Bui) wrote…
we already have
_data_pathfunction from above right?
Done.
bindings/pyc3/test/test_multibody.py line 8 at r1 (raw file):
Previously, xuanhien070594 (Hien Bui) wrote…
This function is not used anywhere in this file.
Done.
bindings/pyc3/test/test_systems.py line 21 at r1 (raw file):
Previously, xuanhien070594 (Hien Bui) wrote…
This function is also not used anywhere.
Done.
|
Previously, Meow404 (Thomas Stephen Felix) wrote…
I mean the system python version on cirrus CI. I'm not sure which version we are using, but if it is too old, it might not be compatible to newer Drake in the future. |
|
I removed |
xuanhien070594
left a comment
There was a problem hiding this comment.
@xuanhien070594 reviewed 4 files and all commit messages, made 1 comment, and resolved 4 discussions.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Meow404).
|
@xuanhien070594 Ill need to add a few more tests after rebase. |
6778ecd to
c5412b5
Compare
c5412b5 to
f8df04e
Compare
xuanhien070594
left a comment
There was a problem hiding this comment.
@xuanhien070594 reviewed 9 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Meow404).
Fixes #46
Includes:
This change is