Skip to content

Migrate enveloped signature support from JSF to JSS#858

Open
stevespringett wants to merge 3 commits into2.0-devfrom
2.0-dev-x590
Open

Migrate enveloped signature support from JSF to JSS#858
stevespringett wants to merge 3 commits into2.0-devfrom
2.0-dev-x590

Conversation

@stevespringett
Copy link
Copy Markdown
Member

Migrate enveloped signature support from JSF to JSS (ITU-T X.590)

Summary

  • Replaced legacy JSON Signature Format (JSF) with JSON Signature Scheme (JSS) per ITU-T X.590 (10/2023). Added CycloneDX 2.0 model schema that implements JSS
  • Updated all schema files referencing signatures to use the new signatures array (JSS) instead of singular signature object (JSF)
  • Removed old JSF test (valid-signatures-2.0.json) and added 18 targeted JSS test cases (8 valid, 10 invalid)

This PR closes #851

All tests are structural validations only. Keys, certificates, thumbprints, and signature values are illustrative and may not be cryptographically valid. No content validation is performed.

… number of valid and invalid use cases.

Signed-off-by: Steve Springett <[email protected]>
Copy link
Copy Markdown

@j28smith j28smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick look at this @stevespringett and it looks good at a high level. I noted a number of places where the descriptions still reference JSF instead of the updated JSS.

For the core change/update, is this the main file to look more closely at to ensure it references the JSS spec correctly?

schema/2.0/model/cyclonedx-jss_X590_2023_10-2.0.schema.json

Comment thread schema/2.0/model/cyclonedx-annotation-2.0.schema.json Outdated
Comment thread schema/2.0/model/cyclonedx-component-2.0.schema.json Outdated
Comment thread schema/2.0/model/cyclonedx-composition-2.0.schema.json Outdated
Comment thread schema/2.0/model/cyclonedx-declaration-2.0.schema.json Outdated
Comment thread schema/2.0/model/cyclonedx-declaration-2.0.schema.json Outdated
Comment thread schema/2.0/model/cyclonedx-declaration-2.0.schema.json Outdated
Comment thread schema/2.0/model/cyclonedx-declaration-2.0.schema.json Outdated
Comment thread schema/2.0/model/cyclonedx-declaration-2.0.schema.json Outdated
Comment thread schema/2.0/model/cyclonedx-service-2.0.schema.json Outdated
Comment thread schema/2.0/model/cyclonedx-standard-2.0.schema.json Outdated
@j28smith
Copy link
Copy Markdown

j28smith commented Mar 9, 2026

@jordan2175 if possible, would you be able to take a look at this PR? Or perhaps you can suggest someone else who worked closely on the JSS technical standardization process that could lend assistance with a review of Steve's PR here?

Note the key thing to look at is the schema definition for JSS in this file:

schema/2.0/model/cyclonedx-jss_X590_2023_10-2.0.schema.json

Thanks.

@j28smith
Copy link
Copy Markdown

@jordan2175, here is the PR that I mentioned on our call today. Would appreciate your review if you could also take a look.

Thanks!

@stevespringett stevespringett added request for comment RFC notice sent A public RFC notice was distributed to the CycloneDX mailing list for consideration labels May 4, 2026
@jkowalleck
Copy link
Copy Markdown
Member

RFC notice sent on May 04, 2026

Public RFC period ends June 01, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

proposed core enhancement request for comment RFC notice sent A public RFC notice was distributed to the CycloneDX mailing list for consideration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Update signatures to use formal standard X.590 (JSS) instead of JSF

3 participants