Migrate enveloped signature support from JSF to JSS#858
Migrate enveloped signature support from JSF to JSS#858stevespringett wants to merge 3 commits into2.0-devfrom
Conversation
… number of valid and invalid use cases. Signed-off-by: Steve Springett <[email protected]>
j28smith
left a comment
There was a problem hiding this comment.
I took a quick look at this @stevespringett and it looks good at a high level. I noted a number of places where the descriptions still reference JSF instead of the updated JSS.
For the core change/update, is this the main file to look more closely at to ensure it references the JSS spec correctly?
schema/2.0/model/cyclonedx-jss_X590_2023_10-2.0.schema.json
|
@jordan2175 if possible, would you be able to take a look at this PR? Or perhaps you can suggest someone else who worked closely on the JSS technical standardization process that could lend assistance with a review of Steve's PR here? Note the key thing to look at is the schema definition for JSS in this file:
Thanks. |
|
@jordan2175, here is the PR that I mentioned on our call today. Would appreciate your review if you could also take a look. Thanks! |
…the various models. Signed-off-by: Steve Springett <[email protected]>
Signed-off-by: Steve Springett <[email protected]>
|
RFC notice sent on May 04, 2026
Public RFC period ends June 01, 2026 |
Migrate enveloped signature support from JSF to JSS (ITU-T X.590)
Summary
signaturesarray (JSS) instead of singularsignatureobject (JSF)valid-signatures-2.0.json) and added 18 targeted JSS test cases (8 valid, 10 invalid)This PR closes #851
All tests are structural validations only. Keys, certificates, thumbprints, and signature values are illustrative and may not be cryptographically valid. No content validation is performed.