fix: CMakeRun now actually uses vim.o.shell on Windows#369
Merged
lceWolf merged 3 commits intoCivitasv:masterfrom Mar 13, 2026
Merged
fix: CMakeRun now actually uses vim.o.shell on Windows#369lceWolf merged 3 commits intoCivitasv:masterfrom
lceWolf merged 3 commits intoCivitasv:masterfrom
Conversation
Collaborator
|
Thanks for taking care of that. LGTM Nice write up and clean PR 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On windows, the terminal handling of CMakeRun is kind of wonky.
cmd /C.cmd /Cis still passed, but is unable execute properly.Example program
cmd Before
cmd After
pwsh (Powershell 7) Before
pwsh (Powershell 7) After
powershell Before
powershell After
bash (mingw64 (git bash)) Before
bash (mingw64 (git bash)) After
After changes
For each of the above vim.o.shell was set to cmd/pwsh/powershell/bash respectively.
Though, the changes should support full paths to shell binaries.
I did a quick test on my ubuntu machine to make sure it still works on nix.
Basically solves #331.