Recursively respect include directives in CMake presets files#357
Merged
lceWolf merged 3 commits intoCivitasv:masterfrom Feb 6, 2026
Merged
Recursively respect include directives in CMake presets files#357lceWolf merged 3 commits intoCivitasv:masterfrom
include directives in CMake presets files#357lceWolf merged 3 commits intoCivitasv:masterfrom
Conversation
lceWolf
reviewed
Jan 20, 2026
mous16
force-pushed
the
fix/presets_recursive_include
branch
from
fc97975 to
0b6b024
Compare
Contributor
Author
|
With 0b6b024 I've fixed also the formatting error |
Collaborator
|
Thanks for taking care of this. Much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With respect to #310 , this PR aims to handle
includedirectives in CMake presets files, allowing to parse also the directives in included files recursively, and avoiding multiple inclusion of same file.I've also added some stricter controls on CMakePresets and CMakeUserPresets file names, to avoid wrong deduction of include fields.
I'm not a Lua developer, so the code may not be perfect.
Please, let me know if it requires some changes to be acceptable.