Skip to content

do not build with preset when none is selected (#349) #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lceWolf merged 1 commit into from
Dec 18, 2025
+21 −22
Merged

do not build with preset when none is selected (#349) #356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 21 additions & 22 deletions lua/cmake-tools/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,7 @@ function cmake.build(opt, callback)
end

local presets_exists = config.base_settings.use_preset and Presets.exists(config.cwd)
local use_build_preset = false
if presets_exists then
local presets = Presets:parse(config.cwd)
if not config.build_preset then
Expand All @@ -367,9 +368,10 @@ function cmake.build(opt, callback)
end
if config.build_preset then
local build_preset = presets:get_build_preset(config.build_preset)
if build_preset then
if build_preset and build_preset:is_valid() then
config:update_build_target()
config:update_build_type()
use_build_preset = true
end
end
end
Expand All @@ -387,7 +389,7 @@ function cmake.build(opt, callback)

local args

if presets_exists and config.build_preset then
if use_build_preset then
args = { "--build", "--preset", config.build_preset } -- preset don't need define build dir.
else
args = {
Expand Down Expand Up @@ -868,32 +870,29 @@ function cmake.select_build_preset(callback)
callback(Result:new_error(Types.NOT_SELECT_PRESET, "No build preset selected"))
return
end

if config.build_preset ~= choice then
config.build_preset = choice

local build_preset = presets:get_build_preset(choice)
if build_preset:is_valid() then
config.build_preset = choice

if build_preset then
config:update_build_target()
if build_preset and build_preset:is_valid() then
config:update_build_target()

local associated_configure_preset =
presets:get_configure_preset(build_preset.configurePreset, { include_hidden = true })
local associated_configure_preset_name = associated_configure_preset
and associated_configure_preset.name
or nil

if
associated_configure_preset_name
and config.configure_preset ~= associated_configure_preset_name
then
config.configure_preset = associated_configure_preset_name
end
end
end
local associated_configure_preset = presets:get_configure_preset(
presets:get_build_preset(choice).configurePreset,
{ include_hidden = true }
)
local associated_configure_preset_name = associated_configure_preset
and associated_configure_preset.name
or nil
local configure_preset_updated = false

if
associated_configure_preset_name
and config.configure_preset ~= associated_configure_preset_name
then
config.configure_preset = associated_configure_preset_name
configure_preset_updated = true
end

callback(Result:new(Types.SUCCESS, nil, nil))
end)
Expand Down