refactor(build-preset): make 'None' option an actual preset (#333)#335
Merged
lceWolf merged 1 commit intoCivitasv:masterfrom Aug 26, 2025
Merged
Conversation
…#333) This commit changes the handling of the None option of the build-preset selection to be an actual preset. A new `is_valid` function checks if the preset was created from the presets file or if it was added "by hand" for the option to have no (real) build-preset selected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes the handling of the None option of the build-preset selection to be an actual preset. A new
is_validfunction checks if the preset was created from the presets file or if it was added "by hand" for the option to have no (real) build-preset selected