Skip to content

fix(notification): nvim_win_is_valid does not accepts nil #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lceWolf merged 1 commit into from
Jun 11, 2025
+1 −1
Merged

fix(notification): nvim_win_is_valid does not accepts nil #328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lua/cmake-tools/notification.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ function Notification:notify(msg, level, opts)

-- We have to check for a valid window here as it seems notify invokes the on_close callback async.
-- Hence checking for self.closed would not work as it gets set too late
if vim.api.nvim_win_is_valid(self.win) and self.width then
if self.win and vim.api.nvim_win_is_valid(self.win) and self.width then
-- update the notification width when the message was updated
local timeDigits = 8
local headlineLength = (self.opts.icon and (#self.opts.icon + 1) or 0)
Expand Down