check for valid window before resizing (#306)#324
Merged
lceWolf merged 1 commit intoCivitasv:masterfrom Jun 5, 2025
Merged
Conversation
when calling `notify` on a notification instance quickly after the window has been dismissed, the on_close callback was not yet called as it is handled asynchronously by vim-notify. Yet, the window is gone and its winID is not valid anymore. Since the on_open callback is also handled async, the winID has not been replaced by then. Skipping the resize should be fine as the new notification should be displayed with the correct size to begin with
lceWolf
force-pushed
the
fix_notification_invalid_window_error
branch
from
2ba94c5 to
cfe2f8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when calling
notifyon a notification instance quickly after the window has been dismissed, the on_close callback was not yet called as it is handled asynchronously by vim-notify. Yet, the window is gone and its winID is not valid anymore. Since the on_open callback is also handled async, the winID has not been replaced by then. Skipping the resize should be fine as the new notification should be displayed with the correct size to begin with