Skip to content

Upgrade Node.js requirement from v20 to v22 #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PeterDaveHello merged 1 commit into from
Feb 28, 2026
Merged

Upgrade Node.js requirement from v20 to v22 #931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version: 20
node-version: 22
- run: npm ci
- run: npm test
- run: npm run lint
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pre-release-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version: 20
node-version: 22
cache: 'npm'
cache-dependency-path: '**/package-lock.json'
- name: Detect Node version
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tagged-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:

- uses: actions/setup-node@v6
with:
node-version: 20
node-version: 22
- run: npm ci

- uses: actions/setup-python@v6
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/verify-configs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ jobs:
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version: 20
node-version: 22
- run: npm ci
- run: npm run verify
1 change: 1 addition & 0 deletions .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
22
2 changes: 1 addition & 1 deletion AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ The extension supports multiple AI providers:

### Build Issues

- Build failures: Check Node.js version (requires Node 20+), clear caches and rebuild.
- Build failures: Check Node.js version (requires Node 22+), clear caches and rebuild.
- macOS/Linux: `rm -rf node_modules && npm ci && rm -rf node_modules/.cache build/ dist/`
- Windows (PowerShell): `Remove-Item -Recurse -Force node_modules, build, dist; if (Test-Path node_modules\.cache) { Remove-Item -Recurse -Force node_modules\.cache }; npm ci`
- "Module not found" errors: Usually indicate missing `npm ci`
Expand Down
3 changes: 3 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
{
"name": "chatgptbox",
"engines": {
"node": ">=22"
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using >=22 for the node engine is a bit too broad and might cause issues with future major Node.js versions (e.g., v23) that could introduce breaking changes. It's generally safer to restrict the version to the current major release. I suggest using a caret range like ^22.0.0 to allow for minor and patch updates within version 22 while preventing automatic adoption of future major versions.

Suggested change
"node": ">=22"
"node": "^22.0.0"

},
"scripts": {
"build": "node build.mjs --production",
"build:safari": "bash ./safari/build.sh",
Expand Down