fix(search): allow any value for keywords not required by form#2148
Open
fix(search): allow any value for keywords not required by form#2148
Conversation
Contributor
Collaborator
Code Coverage (Ubuntu)DetailsDiff against developResults for commit: b243936 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Collaborator
Code Coverage (Windows)DetailsDiff against developResults for commit: b243936 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
More precisely: allow any value if the keyword not required by form and the list of allowed values is empty.
4018d34 to
b243936
Compare
jlahovnik
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is fixing how the available values are calculated from the constraints file.
If no constraint is matching a given parameter, then look at the form file:
In the latter case, there may be no constraint at all containing that keyword because any value is anyway accepted.