Return early from parsing DHCP response if End is encoutered#168
Merged
slp merged 1 commit intoAsahiLinux:mainfrom Apr 21, 2025
Merged
Return early from parsing DHCP response if End is encoutered#168slp merged 1 commit intoAsahiLinux:mainfrom
slp merged 1 commit intoAsahiLinux:mainfrom
Conversation
Up until now DHCP response was parsed by reading the option and the length first. The length field obviously does not apply to the End option, so if muvm got a response that ended exactly at the End byte, muvm would crash because of an out-of-bound read. Signed-off-by: Nikodem Rabuliński <[email protected]>
nrabulinski
requested review from
WhatAmISupposedToPutHere,
alyssarosenzweig,
slp and
teohhanhui
as code owners
13 tasks
Contributor
Oops. It wasn't so obvious to me at some point, see: https://archives.passt.top/passt-dev/20250210191547.5cf0698a@elisabeth/, and I forgot to check against this implementation afterwards. :( Thanks for fixing this!
|
teohhanhui
approved these changes
Apr 17, 2025
Contributor
Author
Haha yeah, hindsight is 20/20. Also, I did not realize you were behind passt (and the dhcp implementation in particular)! Thanks for your hard work! I should've paid more attention to commit authors 😁 |
Contributor
|
You're welcome! I'm glad you use / like it! |
slp
added a commit
to slp/krun
that referenced
this pull request
Apr 21, 2025
Prepare for an expedited minor release to address a crash when parsing a DHCP response from passt (see AsahiLinux#168). Signed-off-by: Sergio Lopez <[email protected]>
Merged
slp
added a commit
that referenced
this pull request
Apr 21, 2025
Prepare for an expedited minor release to address a crash when parsing a DHCP response from passt (see #168). Signed-off-by: Sergio Lopez <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up until now DHCP response was parsed by reading the option and the length first. The length field obviously does not apply to the End option, so if muvm got a response that ended exactly at the End byte, muvm would crash because of an out-of-bound read.
This works with older versions of passt because the response muvm received was longer than it could've been. Latest version of passt sends only as many bytes as necessary.
cc @sbrivio-rh