kboot_atc: Add t8122 tunables#555
Merged
svenpeter42 merged 1 commit intoAsahiLinux:mainfrom Apr 16, 2026
Merged
Conversation
Signed-off-by: Alyssa Milburn <[email protected]>
noopwafel
force-pushed
the
t8122-atc-tunables
branch
from
2f1c08c to
1403cad
Compare
jannau
approved these changes
Apr 2, 2026
| ret = dt_append_atc_tunable(dt, adt_node, fdt_node, &atc_tunables[i]); | ||
| if (adt_is_compatible_at(adt, adt_node, "atc-phy,t8122", 0)) { | ||
| tunables = &atc_tunables_t8122[0]; | ||
| tunable_count = sizeof(atc_tunables_t8122) / sizeof(*atc_tunables_t8122); |
Member
There was a problem hiding this comment.
nit: this could use ARRAY_SIZE macro but not really important as we don't strictly use it
|
|
||
| for (size_t i = 0; i < sizeof(atc_tunables) / sizeof(*atc_tunables); ++i) { | ||
| ret = dt_append_atc_tunable(dt, adt_node, fdt_node, &atc_tunables[i]); | ||
| if (adt_is_compatible_at(adt, adt_node, "atc-phy,t8122", 0)) { |
Member
There was a problem hiding this comment.
I wonder if we want to copy the approach for atc_fuses but I guess we can still refactor once we add support for t603x or t814x. One possible issue is that the DT compaitbles probably won't allow this.
svenpeter42
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for t8122 USB tunables; a few are commented out since they're not used on my j613 (w/14.8.3) and so I don't know the offsets.