Skip to content

T8132 smp #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuyuyureka wants to merge 3 commits into
base: main
Choose a base branch
from
+33 −3
Open

T8132 smp #536

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d890f8
smp: add CPU_START_OFF for T8132
yuyuyureka Jan 24, 2026
413d454
proxyclient: only write rvbar if needed
yuyuyureka Jan 24, 2026
e5d941e
smp: only write rvbar if needed
yuyuyureka Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion proxyclient/m1n1/hv/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1786,7 +1786,16 @@ def remove_oslog(node):
continue
addr, size = cpu.cpu_impl_reg
print(f" {cpu.name}: [0x{addr:x}] = 0x{rvbar:x}")
self.p.write64(addr, rvbar)

val = p.read64(addr)
locked = val & 1
do_write = val & 0xfffffffff000 != rvbar
Copy link
Copy Markdown
Member

@jannau jannau May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think

if val & ~0xfff != rvbar:
    if val & 1:
        raise Exception(f"RVBAR for {cpu.name} is locked but differs from entry point")

    p.write64(addr, rvbar)

is easier to follow than the ifs with two booleans. print(f" {cpu.name}: [0x{addr:x}] = 0x{rvbar:x}") should stay directly above the write.

Not sure if we shouldn't just drop this. I think this is a leftover from old times before we updated in-place


if locked and do_write:
raise Exception("RVBAR is locked and does not already contain start address")

if do_write:
p.write64(addr, rvbar)

def _load_macho_symbols(self):
self.symbol_dict = self.macho.symbols
Expand Down
11 changes: 10 additions & 1 deletion proxyclient/tools/chainload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,16 @@ def remove_oslog(node):
continue
addr, size = cpu.cpu_impl_reg
print(f" {cpu.name}: [0x{addr:x}] = 0x{rvbar:x}")
p.write64(addr, rvbar)

val = p.read64(addr)
locked = val & 1
do_write = val & 0xfffffffff000 != rvbar
Copy link
Copy Markdown
Member

@jannau jannau May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here


if locked and do_write:
raise Exception("RVBAR is locked and does not already contain start address")

if do_write:
p.write64(addr, rvbar)

u.push_adt()

Expand Down
1 change: 1 addition & 0 deletions src/smp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,7 @@ void smp_start_secondaries(void)
break;
case T8112:
case T8122:
case T8132:
cpu_start_off = CPU_START_OFF_T8112;
break;
case T6020:
Expand Down