Conversation
Add a new script that detects physical network interfaces and configures ethtool RX ring sizes (preferring 4096, falling back to 2047). The script sets net.core.netdev_budget, writes a persistent sysctl file (/etc/sysctl.d/99-netdev-budget.conf), and generates a NetworkManager dispatcher script (/etc/NetworkManager/dispatcher.d/45-ethtool) to reapply RX settings on interface up. It validates changes, creates backups of existing dispatcher/sysctl files, and requires root and ethtool to run.
There was a problem hiding this comment.
Pull request overview
Adds a new host-tuning shell script intended to optimize NIC receive behavior by adjusting RX ring sizes via ethtool and increasing net.core.netdev_budget, with persistence across reboots and link events through a sysctl drop-in and a NetworkManager dispatcher script.
Changes:
- Detects “physical” interfaces from
/sys/class/netand applies RX ring sizing (prefer 4096, fall back to 2047). - Sets
net.core.netdev_budgetimmediately and persists it via/etc/sysctl.d/99-netdev-budget.conf. - Generates
/etc/NetworkManager/dispatcher.d/45-ethtoolto reapply RX ring settings on interface “up”.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| echo | ||
| echo "Writing static dispatcher script: $DISPATCHER_SCRIPT" | ||
|
|
||
| [[ -f "$DISPATCHER_SCRIPT" ]] && cp "$DISPATCHER_SCRIPT" "$DISPATCHER_SCRIPT.bak" |
Comment on lines
+75
to
+81
| echo "Writing static dispatcher script: $DISPATCHER_SCRIPT" | ||
|
|
||
| [[ -f "$DISPATCHER_SCRIPT" ]] && cp "$DISPATCHER_SCRIPT" "$DISPATCHER_SCRIPT.bak" | ||
|
|
||
| cat > "$DISPATCHER_SCRIPT" <<'EOF' | ||
| #!/bin/bash | ||
| EOF |
Comment on lines
+32
to
+42
| detect_rx_size() { | ||
| local iface="$1" | ||
|
|
||
| if ethtool -G "$iface" rx "$PREFERRED_RX" >/dev/null 2>&1; then | ||
| echo "$PREFERRED_RX" | ||
| elif ethtool -G "$iface" rx "$FALLBACK_RX" >/dev/null 2>&1; then | ||
| echo "$FALLBACK_RX" | ||
| else | ||
| echo "" | ||
| fi | ||
| } |
| net.core.netdev_budget=$NETDEV_BUDGET | ||
| EOF | ||
|
|
||
| sysctl --system >/dev/null |
Comment on lines
+108
to
+115
| echo | ||
| echo "Validating applied settings..." | ||
| ACTUAL_BUDGET="$(sysctl -n net.core.netdev_budget)" | ||
| if [[ "$ACTUAL_BUDGET" == "$NETDEV_BUDGET" ]]; then | ||
| echo "✓ net.core.netdev_budget correctly set to $NETDEV_BUDGET" | ||
| else | ||
| echo "✗ Warning: net.core.netdev_budget is $ACTUAL_BUDGET (expected $NETDEV_BUDGET)" | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new script that detects physical network interfaces and configures ethtool RX ring sizes (preferring 4096, falling back to 2047). The script sets net.core.netdev_budget, writes a persistent sysctl file (/etc/sysctl.d/99-netdev-budget.conf), and generates a NetworkManager dispatcher script (/etc/NetworkManager/dispatcher.d/45-ethtool) to reapply RX settings on interface up. It validates changes, creates backups of existing dispatcher/sysctl files, and requires root and ethtool to run.