Skip to content

🔒 [security fix] Unsafe set_len without size validation in api.rs #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
404Setup merged 1 commit into from
May 4, 2026
Merged

🔒 [security fix] Unsafe set_len without size validation in api.rs #431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ impl Compressor {
let (res, size) = f(&mut self.inner, data, out_uninit);
match res {
CompressResult::Success => {
assert!(size <= bound);
unsafe {
output.set_len(size);
}
Expand Down Expand Up @@ -118,7 +119,10 @@ impl Compressor {
let out_uninit = crate::common::slice_as_uninit_mut(output);
let (res, size) = f(&mut self.inner, data, out_uninit);
match res {
CompressResult::Success => Ok(size),
CompressResult::Success => {
assert!(size <= output.len());
Ok(size)
}
_ => Err(io::Error::other(error_msg)),
}
}
Expand Down Expand Up @@ -233,6 +237,7 @@ impl Decompressor {

let (res, _, size) = f(&mut self.inner, data, out_uninit);
if res == crate::decompress::DecompressResult::Success {
assert!(size <= expected_size);
unsafe {
output.set_len(size);
}
Expand Down Expand Up @@ -268,6 +273,7 @@ impl Decompressor {
let out_uninit = crate::common::slice_as_uninit_mut(output);
let (res, _, size) = f(&mut self.inner, data, out_uninit);
if res == crate::decompress::DecompressResult::Success {
assert!(size <= output.len());
Ok(size)
} else {
Err(io::Error::new(
Expand Down