Verify Decompressor Memory Limits and Ratio#382
Conversation
Added integration tests to `tests/security_limit.rs` to verify that `set_max_memory_limit` and `set_limit_ratio` correctly enforce limits on real compressed data. This ensures protection against zip bombs (highly compressed files) and excessive memory allocation requests across Deflate, Zlib, and Gzip formats. Tests include: - `test_memory_limit_with_real_data`: Confirms decompression fails when output exceeds `max_memory_limit`. - `test_ratio_limit_with_real_data`: Confirms decompression fails when expansion ratio exceeds `limit_ratio` (using strict limit on level 12 compressed data). - `test_gzip_zlib_limits`: Confirms limits apply to Gzip and Zlib streams. Co-authored-by: 404Setup <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
404Setup
deleted the
verify-decompressor-memory-limits-5272232841701043701
branch
1 participant
Added tests to verify
Decompressormemory and ratio limits using real compressed data to simulate zip bombs.test_memory_limit_with_real_datatest_ratio_limit_with_real_datatest_gzip_zlib_limitsPR created automatically by Jules for task 5272232841701043701 started by @404Setup