Skip to content

ci(workflows): add concurrency to win-install + deploy-gh-pages#164

Closed
ss-o wants to merge 1 commit into
nextfrom
feature-zsh1-perms-concurrency
Closed

ci(workflows): add concurrency to win-install + deploy-gh-pages#164
ss-o wants to merge 1 commit into
nextfrom
feature-zsh1-perms-concurrency

Conversation

@ss-o
Copy link
Copy Markdown
Member

@ss-o ss-o commented May 25, 2026

ZSH-1 CI modernization (perms/concurrency sweep). Both workflows had permissions but no concurrency block. Adds standard concurrency groups; deploy-gh-pages uses cancel-in-progress: false so deploys aren't interrupted mid-run.

ZSH-1 perms/concurrency sweep: add concurrency groups to cancel stale runs. deploy-gh-pages uses cancel-in-progress: false so in-flight deploys complete.
Copilot AI review requested due to automatic review settings May 25, 2026 23:33
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying src with  Cloudflare Pages  Cloudflare Pages

Latest commit: c37af5c
Status: ✅  Deploy successful!
Preview URL: https://000f7b75.zi-src.pages.dev
Branch Preview URL: https://feature-zsh1-perms-concurren.zi-src.pages.dev

View logs

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds workflow-level GitHub Actions concurrency controls as part of a CI modernization sweep, aiming to standardize concurrency grouping and avoid unwanted overlap between runs (with deploys intended to not be interrupted mid-run).

Changes:

  • Add top-level concurrency to win-install workflow (with cancellation enabled).
  • Add top-level concurrency to deploy-gh-pages workflow (with cancellation disabled to avoid interrupting deploys).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/win-install.yml Adds workflow-level concurrency controls for Windows install CI runs.
.github/workflows/deploy-gh-pages.yml Adds workflow-level concurrency controls for GitHub Pages deployments, keeping deploys from being cancelled mid-run.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +22 to +24
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
Comment on lines +16 to +18
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: false
@ss-o
Copy link
Copy Markdown
Member Author

ss-o commented May 26, 2026

Closing — not needed. Both workflows already define concurrency at the job level (win-installrun-install with cancel-in-progress: false; deploy-gh-pagesdeploy). The audit only checked for top-level concurrency: and missed these. Adding a workflow-level block here is redundant for deploy and actively wrong for win-install (top-level cancel-in-progress: true would cancel in-flight Windows installs, contradicting the deliberate job-level false). No change required; the org concurrency convention is already satisfied at job level.

@ss-o ss-o closed this May 26, 2026
@ss-o ss-o deleted the feature-zsh1-perms-concurrency branch May 26, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants