Added voice bitrate option. Separated voice settings into their own category. Fixed erroring in recording pulse enumerator. Fixed replays erroring when they didn't have any voices recorded. Fixed not being able to change replays if first page is all folders. Actually removed all ModUI and ModUI+ references. FINALLY fixed crystal erroring when holding grip between scene loads.

Author: xLoadingx

ERRORMODS-ReplayMod-1.0.0/ERRORMODS-ReplayMod-1.2.0.zip

@@ -95,7 +95,9 @@ public class Main : MelonMod
     public MelonPreferences_Entry<bool> HandFingerRecording = new();
     public MelonPreferences_Entry<bool> CloseHandsOnPose = new();
 
+    // Recording - Voices
     public MelonPreferences_Entry<bool> VoiceRecording = new();
+    public MelonPreferences_Entry<int> voiceBitrate = new();
 
     // Automatic Markers - Match End
     public MelonPreferences_Entry<bool> EnableMatchEndMarker = new();
@@ -151,7 +153,6 @@ public enum ControllerAction
     // Other
     public MelonPreferences_Entry<float> tableOffset;
     public MelonPreferences_Entry<bool> enableDebug;
-    public MelonPreferences_Category extensionsFolder;
 
     // ------------
 
@@ -198,7 +199,10 @@ public override void OnInitializeMelon()
         HandFingerRecording = recordingFolder.CreateEntry("Finger_Animation_Recording", true, "Finger Animation Recording", "Controls whether finger input values are recorded into the replay.");
         CloseHandsOnPose = recordingFolder.CreateEntry("Close_Hands_On_Pose", true, "Close Hands On Pose", "Closes the hands of a clone when they do a pose.");
 
-        VoiceRecording = recordingFolder.CreateEntry("Voice_Recording", true, "Record In-Game Voices", "Toggles whether in-game voices are recorded into replays.");
+        var voiceFolder = MelonPreferences.CreateCategory("Voices");
+        
+        VoiceRecording = voiceFolder.CreateEntry("Voice_Recording", true, "Record In-Game Voices", "Toggles whether in-game voices are recorded into replays.");
+        voiceBitrate = voiceFolder.CreateEntry("Voice_Bitrate", 30, "Voice Bitrate", "Determines what bitrate voices are recorded in.\nDefault: 30");
 
         var automaticMarkersFolder = MelonPreferences.CreateCategory("Automatic_Markers", "Automatic Markers");
         automaticMarkersFolder.SetFilePath(configPath);
@@ -217,7 +221,7 @@ public override void OnInitializeMelon()
         PlaybackControlsFollow = playbackFolder.CreateEntry("Playback_Controls_Follow_Player", false, "Playback Controls Follow Player", "Makes the playback controls menu follow you when opened.");
         DestroyControlsOnPunch = playbackFolder.CreateEntry("Destroy_Controls_On_Punch", true, "Destroy Controls On Punch", "Destroys the playback controls when you punch the slab hard enough.");
 
-        var playbackTogglesFolder = MelonPreferences.CreateCategory("Toggles");
+        var playbackTogglesFolder = MelonPreferences.CreateCategory("Visual Toggles");
         playbackTogglesFolder.SetFilePath(configPath);
 
         ToggleUI = playbackTogglesFolder.CreateEntry("Toggle_UI", true, "Toggle UI", "Toggles whether the UI for selecting replays is visible.");
@@ -398,6 +402,8 @@ public override void OnApplicationQuit()
 
     public override void OnSceneWasLoaded(int buildIndex, string sceneName)
     {
+        isSceneReady = false;
+        
         if (currentScene == "Loader" || !UIInitialized)
             return;
 

ERRORMODS-ReplayMod-1.0.0/Mods/ReplayMod.dll

@@ -5,7 +5,6 @@
 using HarmonyLib;
 using Il2Cpp;
 using Il2CppPhoton.Pun;
-using Il2CppPhoton.Voice;
 using Il2CppRUMBLE.Audio;
 using Il2CppRUMBLE.Environment;
 using Il2CppRUMBLE.Input;

src/Core/Main.cs

@@ -304,24 +304,33 @@ public void LoadReplay(string path, bool allowDifferentSceneLoad = false)
 
             ReorderPlayers();
 
-            foreach (var info in currentReplay.Header.VoiceTrackInfos)
+            try
             {
-                var clone = PlaybackPlayers.FirstOrDefault(p => 
-                    p.Controller.assignedPlayer.Data.GeneralData.PlayFabMasterId == info.MasterId);
+                if (currentReplay.Header.VoiceTrackInfos != null)
+                {
+                    foreach (var info in currentReplay.Header.VoiceTrackInfos)
+                    {
+                        var clone = PlaybackPlayers.FirstOrDefault(p =>
+                            p.Controller.assignedPlayer.Data.GeneralData.PlayFabMasterId == info.MasterId);
 
-                if (clone == null) continue;
+                        if (clone == null) continue;
 
-                string voicePath = Path.Combine(currentReplay.Header.VoiceFolder, info.FileName);
+                        string voicePath = Path.Combine(currentReplay.Header.VoiceFolder, info.FileName);
 
-                var clip = ReplayVoices.LoadVoiceClipFromFile(voicePath);
-                
-                if (clip == null) return;
-                    
-                clone.VoiceTracks.Add(new Clone.VoiceTrack
-                {
-                    StartTime = info.StartTime,
-                    Clip = clip
-                });
+                        var clip = ReplayVoices.LoadVoiceClipFromFile(voicePath);
+
+                        if (clip == null) continue;
+
+                        clone.VoiceTracks.Add(new Clone.VoiceTrack
+                        {
+                            StartTime = info.StartTime, Clip = clip
+                        });
+                    }
+                }
+            }
+            catch (Exception e)
+            {
+                Main.ReplayError($"Voice laoding failed: {e}");
             }
 
             if (currentReplay.Header.Scene == "Gym")

src/Core/Patches.cs

@@ -827,14 +827,17 @@ public IEnumerator Pulse()
 
             while (recording.CurrentRecordingState == RecordingState.Saving)
             {
-                t += Time.deltaTime * 2f;
+                if (tmp != null && transform != null)
+                {
+                    t += Time.deltaTime * 2f;
 
-                float ping = Mathf.PingPong(t, 1f);
-                ping = Utilities.EaseInOut(ping);
-                tmp.color = Color.Lerp(a, b, ping);
+                    float ping = Mathf.PingPong(t, 1f);
+                    ping = Utilities.EaseInOut(ping);
+                    tmp.color = Color.Lerp(a, b, ping);
 
-                float scale = Mathf.Lerp(0.95f, 1.05f, ping);
-                transform.localScale = Vector3.one * (0.4f * scale);
+                    float scale = Mathf.Lerp(0.95f, 1.05f, ping);
+                    transform.localScale = Vector3.one * (0.4f * scale);
+                }
 
                 yield return null;
             }

src/Core/ReplayPlayback.cs

@@ -210,8 +210,7 @@ public void GoUp()
     public void Next()
     {
         if (currentReplayEntries.Count == 0) return;
-
-        if (GetPage().All(e => e.IsFolder)) return;
+        if (currentReplayEntries.All(e => e.IsFolder)) return;
 
         do
         {
@@ -225,8 +224,7 @@ public void Next()
     public void Previous()
     {
         if (currentReplayEntries.Count == 0) return;
-
-        if (GetPage().All(e => e.IsFolder)) return;
+        if (currentReplayEntries.All(e => e.IsFolder)) return;
 
         do
         {

src/Core/ReplayRecording.cs

@@ -8,20 +8,16 @@
 using ReplayMod.Replay.Files;
 using ReplayMod.Replay.Serialization;
 using ReplayMod.Replay.UI;
-using RumbleModUI;
-using RumbleModUIPlus;
 using UnityEngine;
 using BuildInfo = ReplayMod.Core.BuildInfo;
 using CompressionLevel = System.IO.Compression.CompressionLevel;
 using Main = ReplayMod.Core.Main;
-using Mod = RumbleModUI.Mod;
 
 namespace ReplayMod.Replay;
 
 public static class ReplayAPI
 {
     private static readonly List<ReplayExtension> _extensions = new();
-    private static readonly List<ModSettingFolder> _extensionFolders = new(); 
 
     /// <summary>
     /// Invoked when a replay is selected from the UI.

src/Replay/Files/ReplayExplorer.cs

@@ -176,6 +176,7 @@ public static void OnRemoteVoiceLinkAdded(RemoteVoiceLink link)
                     link.VoiceInfo.SamplingRate,
                     link.VoiceInfo.Channels,
                     path,
+                    bitrate: Mathf.Clamp(Main.instance.voiceBitrate.Value, 8, 128),
                     initalTimeStamp: startTime // file doesnt actually start until the person starts speaking for the first time
                 );
 
@@ -228,9 +229,8 @@ public VoiceStreamWriter(
             Channels = channels;
 
             _fileStream = File.Create(path);
-
-
-            _encoder = OpusCodecFactory.CreateEncoder(sampleRate, channels, Concentus.Enums.OpusApplication.OPUS_APPLICATION_VOIP);
+            
+            _encoder = OpusCodecFactory.CreateEncoder(sampleRate, channels, OpusApplication.OPUS_APPLICATION_VOIP);
             _encoder.Bitrate = bitrate;
             _encoder.Complexity = complexity;
             _encoder.SignalType = OpusSignal.OPUS_SIGNAL_VOICE;

src/Replay/ReplayAPI.cs

@@ -52,7 +52,7 @@ public static void HandleCrystals()
             }
         }
 
-        if (heldCrystal == null)
+        if (heldCrystal == null && Main.isSceneReady)
         {
             if (Calls.ControllerMap.RightController.GetGrip() > 0.5f)
             {