Split WordPressShared into cross-platform and UIKit-only modules

Create WordPressSharedObjCUI and WordPressSharedUI for UIKit-dependent
code, keeping WordPressSharedObjC and WordPressShared cross-platform.
Update all import statements across the codebase accordingly.

Author: jkmassel

Modules/Package.swift

@@ -71,6 +71,7 @@ let package = Package(
         ]),
         .target(name: "AztecExtensions", dependencies: [
             "WordPressShared",
+            "WordPressSharedUI",
             .product(name: "Gridicons", package: "Gridicons-iOS"),
             .product(name: "Aztec", package: "AztecEditor-iOS"),
         ], swiftSettings: [.swiftLanguageMode(.v5)]),
@@ -88,6 +89,7 @@ let package = Package(
             name: "FormattableContentKit",
             dependencies: [
                 "WordPressShared",
+                "WordPressSharedUI",
                 "WordPressUI",
                 // TODO: Remove — It's here just for a NSMutableParagraphStyle init helper
                 "WordPressKit",
@@ -99,6 +101,7 @@ let package = Package(
         .target(
             name: "JetpackStats",
             dependencies: [
+                "WordPressSharedUI",
                 "WordPressUI",
                 "WordPressKit",
             ],
@@ -169,7 +172,14 @@ let package = Package(
             .product(name: "SwiftSoup", package: "SwiftSoup"),
         ]),
         .target(name: "WordPressLegacy", dependencies: ["DesignSystem", "WordPressShared"]),
-        .target(name: "WordPressSharedObjC", resources: [.process("Resources")], swiftSettings: [.swiftLanguageMode(.v5)]),
+        .target(name: "WordPressSharedObjC", swiftSettings: [.swiftLanguageMode(.v5)]),
+        .target(
+            name: "WordPressSharedObjCUI",
+            dependencies: ["WordPressSharedObjC"],
+            publicHeadersPath: "include",
+            resources: [.process("Resources")],
+            swiftSettings: [.swiftLanguageMode(.v5)]
+        ),
         .target(
             name: "WordPressShared",
             dependencies: [
@@ -181,6 +191,14 @@ let package = Package(
             resources: [.process("Resources")],
             swiftSettings: [.swiftLanguageMode(.v5)]
         ),
+        .target(
+            name: "WordPressSharedUI",
+            dependencies: [
+                "WordPressShared",
+                "WordPressSharedObjCUI",
+            ],
+            swiftSettings: [.swiftLanguageMode(.v5)]
+        ),
         .target(name: "WordPressTesting", resources: [.process("Resources")]),
         .target(
             name: "WordPressUI",
@@ -235,7 +253,7 @@ let package = Package(
         ),
         .target(
             name: "WordPressReader",
-            dependencies: ["AsyncImageKit", "WordPressUI", "WordPressShared"],
+            dependencies: ["AsyncImageKit", "WordPressUI", "WordPressShared", "WordPressSharedUI"],
             resources: [.process("Resources")]
         ),
         .testTarget(name: "JetpackStatsTests", dependencies: ["JetpackStats"]),
@@ -298,6 +316,7 @@ enum XcodeSupport {
         let wordPresAuthentificatorDependencies: [Target.Dependency] = [
             "BuildSettingsKit",
             "WordPressShared",
+            "WordPressSharedUI",
             "WordPressUI",
             "WordPressKit",
             .product(name: "Gridicons", package: "Gridicons-iOS"),
@@ -313,6 +332,7 @@ enum XcodeSupport {
             "SFHFKeychainUtils",
             "ShareExtensionCore",
             "WordPressShared",
+            "WordPressSharedUI",
             "WordPressUI",
             "TextBundle",
             "TracksMini",
@@ -357,6 +377,8 @@ enum XcodeSupport {
             "WordPressFlux",
             "WordPressIntelligence",
             "WordPressShared",
+            "WordPressSharedUI",
+            "WordPressSharedObjCUI",
             "WordPressLegacy",
             "WordPressReader",
             "WordPressUI",
@@ -401,6 +423,7 @@ enum XcodeSupport {
             .xcodeTarget("XcodeTarget_Keystone", dependencies: keystoneDependencies),
             .xcodeTarget("XcodeTarget_WordPressTests", dependencies: testDependencies + [
                 "WordPressShared",
+                "WordPressSharedUI",
                 "WordPressUI",
                 .product(name: "Gravatar", package: "Gravatar-SDK-iOS"),
                 // Needed by WordPressData because of how linkage works...
@@ -494,6 +517,7 @@ enum XcodeSupport {
                     "FormattableContentKit",
                     "SFHFKeychainUtils",
                     "WordPressShared",
+                    "WordPressSharedUI",
                     "WordPressKit",
                     .product(name: "CocoaLumberjack", package: "CocoaLumberjack"),
                     .product(name: "CocoaLumberjackSwift", package: "CocoaLumberjack"),

Modules/Sources/AztecExtensions/Header+WordPress.swift

@@ -2,6 +2,7 @@ import Foundation
 import Aztec
 import Gridicons
 import WordPressShared
+import WordPressSharedUI
 
 // MARK: - Header and List presentation extensions
 //

Modules/Sources/FormattableContentKit/Styles/SnippetsContentStyles.swift

@@ -1,4 +1,5 @@
 import WordPressShared
+import WordPressSharedUI
 
 public class SnippetsContentStyles: FormattableContentStyles {
     public var attributes: [NSAttributedString.Key: Any] {

Modules/Sources/FormattableContentKit/Styles/SubjectContentStyles.swift

@@ -1,4 +1,5 @@
 import WordPressShared
+import WordPressSharedUI
 
 public class SubjectContentStyles: FormattableContentStyles {
     public var attributes: [NSAttributedString.Key: Any] {

Modules/Sources/FormattableContentKit/Styles/WPStyleGuide+Notifications.swift

@@ -3,6 +3,7 @@ import Foundation
 import Gridicons
 import UIKit
 import WordPressShared
+import WordPressSharedUI
 import WordPressKit // FIXME: Here just for the NSMutableParagraphStyle custom init
 import WordPressUI
 

Modules/Sources/JetpackStats/StatsRouter.swift

@@ -1,6 +1,7 @@
 import SwiftUI
 import UIKit
 import SafariServices
+import WordPressSharedUI
 
 @MainActor
 public protocol StatsRouterScreenFactory: AnyObject {

Modules/Sources/WordPressReader/Settings/ReaderDisplaySettings.swift

@@ -1,5 +1,6 @@
 import UIKit
 import WordPressShared
+import WordPressSharedUI
 
 public struct ReaderDisplaySettings: Codable, Equatable, Hashable, Sendable {
 

Modules/Sources/WordPressShared/Reachability/ReachabilityUtils.swift

@@ -14,16 +14,6 @@ public class ReachabilityUtils: NSObject {
         connectionAvailable
     }
 
-    @objc
-    public static func showAlertNoInternetConnection() {
-        ReachabilityAlert(retryBlock: nil).show()
-    }
-
-    @objc
-    public static func showAlertNoInternetConnection(retryBlock: (() -> Void)? = nil) {
-        ReachabilityAlert(retryBlock: retryBlock).show()
-    }
-
     @objc
     public static func noConnectionMessage() -> String {
         NSLocalizedString(
@@ -33,10 +23,6 @@ public class ReachabilityUtils: NSObject {
         )
     }
 
-    @objc
-    public static func alertIsShowing() -> Bool {
-        currentReachabilityAlert != nil
-    }
 
     public static func configure(
         notificationCenter: NotificationCenter = .default,

Modules/Sources/WordPressSharedObjC/Utility/DisplayableImageHelper.m

@@ -1,5 +1,8 @@
 #import "DisplayableImageHelper.h"
-#import "NSString+Util.h"
+
+@interface NSObject (NumericValueHack)
+- (NSNumber *)numericValue;
+@end
 
 static const NSInteger FeaturedImageMinimumWidth = 150;