Fix clippy warnings

Author: timfennis

.cargo/config.toml

@@ -39,7 +39,6 @@ rustflags = [
     "-Wclippy::map_err_ignore",
     "-Wclippy::map_flatten",
     "-Wclippy::map_unwrap_or",
-    "-Wclippy::match_on_vec_items",
     "-Wclippy::match_same_arms",
     "-Wclippy::match_wild_err_arm",
     "-Wclippy::match_wildcard_for_single_variants",
@@ -62,7 +61,6 @@ rustflags = [
     "-Wclippy::string_add_assign",
     "-Wclippy::string_add",
     "-Wclippy::string_lit_as_bytes",
-    "-Wclippy::string_to_string",
     "-Wclippy::todo",
     "-Wclippy::trait_duplication_in_bounds",
     "-Wclippy::unimplemented",

ndc_lib/src/interpreter/environment.rs

@@ -139,7 +139,7 @@ impl Environment {
                     );
             }
             ResolvedVar::Global { .. } => {
-                todo!("convert to panic?? you cannot assign to the global scope right?")
+                unreachable!("cannot assign value to global")
             }
         }
     }

ndc_lib/src/interpreter/evaluate/mod.rs

@@ -292,9 +292,8 @@ pub(crate) fn evaluate_expression(
                     let result = evaluate_expression(loop_body, environment);
                     match result {
                         Err(FunctionCarrier::Break(value)) => return Ok(value),
-                        Err(FunctionCarrier::Continue) => {}
+                        Err(FunctionCarrier::Continue) | Ok(_) => {}
                         Err(err) => return Err(err),
-                        Ok(_) => {}
                     }
                 } else if lit == Value::Bool(false) {
                     break;

ndc_lib/src/lexer/mod.rs

@@ -118,7 +118,6 @@ impl Iterator for Lexer<'_> {
             match (first, second) {
                 (' ' | '\t' | '\r' | '\n', _) => {
                     self.source.consume(1);
-                    continue;
                 }
                 ('r', Some('"' | '#')) => {
                     return Some(self.lex_string_literal());