More clippy fixes

Author: timfennis

ndc_lib/src/interpreter/evaluate/mod.rs

@@ -1,6 +1,4 @@
-use crate::ast::{
-    Expression, ExpressionLocation, ForBody, ForIteration, LogicalOperator, Lvalue,
-};
+use crate::ast::{Expression, ExpressionLocation, ForBody, ForIteration, LogicalOperator, Lvalue};
 use crate::hash_map::HashMap;
 use crate::interpreter::environment::{Environment, EnvironmentRef};
 use crate::interpreter::function::{Function, FunctionBody, FunctionCarrier, OverloadedFunction};

ndc_lib/src/interpreter/num.rs

@@ -224,8 +224,8 @@ impl BinaryOperatorError {
 
     pub fn undefined_operation(
         operator: BinaryOperator,
-        left: ValueType,
-        right: ValueType,
+        left: &ValueType,
+        right: &ValueType,
     ) -> Self {
         Self(format!(
             "operator {operator} is not defined for {left} and {right}"
@@ -397,8 +397,8 @@ impl Number {
             (Self::Float(p1), Self::Float(p2)) => Ok(Self::Float(p1.rem_euclid(p2))),
             (left, right) => Err(BinaryOperatorError::undefined_operation(
                 BinaryOperator::EuclideanModulo,
-                ValueType::from(left),
-                ValueType::from(right),
+                &ValueType::from(left),
+                &ValueType::from(right),
             )),
         }
     }

ndc_lib/src/interpreter/resolve.rs

@@ -513,8 +513,9 @@ impl LexicalScope {
     pub fn get_slot_by_name(&self, find_ident: &str) -> Option<usize> {
         for (slot, ident_in_scope) in self.identifiers.iter().enumerate().rev() {
             let name_in_scope = match ident_in_scope {
-                LexicalIdentifier::Variable { name } => name,
-                LexicalIdentifier::Function { name, .. } => name,
+                LexicalIdentifier::Variable { name } | LexicalIdentifier::Function { name, .. } => {
+                    name
+                }
             };
 
             if name_in_scope == find_ident {

ndc_lib/src/lexer/mod.rs

@@ -118,7 +118,7 @@ impl Iterator for Lexer<'_> {
             match (first, second) {
                 (' ' | '\t' | '\r' | '\n', _) => {
                     self.source.consume(1);
-                    continue 'iterator;
+                    continue;
                 }
                 ('r', Some('"' | '#')) => {
                     return Some(self.lex_string_literal());