chore(deps): update microsoft.testing#6369
Conversation
There was a problem hiding this comment.
Code Review
Reviewed the diff (2 files, +8/-8). This is an automated Renovate dependency bump for the Microsoft.Testing.Platform ecosystem packages (Microsoft.Testing.Platform, .MSBuild, .Extensions.CrashDump/HangDump/Telemetry/TrxReport(.Abstractions)), all going from 2.2.3 → 2.3.0 (minor version).
Findings: None. No design, architectural, or maintainability concerns — this is a mechanical version bump with no behavioral code changes.
Verification:
- All package versions are updated consistently in
Directory.Packages.props(central package management), so there's no risk of version drift across the solution. - The one direct
PackageReferenceinexamples/CloudShop/CloudShop.Tests/CloudShop.Tests.csprojwas updated in lockstep with the central version — good, this avoids a stale pinned version diverging from the CPM baseline. - No source files, public APIs, or source-generator output are touched, so snapshot tests and dual-mode (source-gen/reflection) concerns don't apply here.
Suggestion: Since this is a minor bump of the test platform/runner itself (not just an extension), it's worth confirming CI (in progress at review time) passes fully before automerge, particularly the modularpipeline matrix jobs, since platform version bumps have occasionally introduced subtle CLI/output-format changes in this repo's history. Nothing to act on now beyond letting CI complete.
Approving from a code-quality standpoint — no changes requested.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
9473e8f to
a5a265f
Compare
a5a265f to
9db2102
Compare
There was a problem hiding this comment.
Code Review
This is an automated Renovate dependency bump (Microsoft.Testing.Platform and related Microsoft.Testing.Extensions.* packages: 2.2.3 → 2.3.0, Microsoft.Testing.Extensions.CodeCoverage: 18.8.0 → 18.9.0). The diff itself (Directory.Packages.props, CloudShop.Tests.csproj) is mechanical and correctly applied consistently across both the central package version and the one project with a pinned version override — no architectural concerns there.
Blocking issue: this bump breaks the build
CI is currently failing (.NET / modularpipeline on macOS, de-DE, and integration-tests) with 8 compile errors across all three target frameworks (net8.0/net9.0/net10.0):
error MTP0001: 'CancelledTestNodeStateProperty' is obsolete: Test frameworks should throw
OperationCanceledException using the cancellation token passed by Microsoft.Testing.Platform
instead of using this state. (https://aka.ms/testingplatform/diagnostics#MTP0001)
Microsoft.Testing.Platform 2.3.0 introduces an analyzer that flags CancelledTestNodeStateProperty as obsolete-as-error. This property is still used in several places in TUnit.Engine:
Xml/JUnitXmlWriter.cs(lines 234, 400)TUnitMessageBus.cs(line 116)Reporters/GitHubReporter.cs(lines 153, 509, 540, 570)Reporters/Html/HtmlReporter.cs(line 622)TUnit.Engine.Tests/GitHubReporterTests.cs
This isn't flaky CI — it reproduces consistently across every OS/TFM combination in the pipeline, so this PR cannot merge as-is.
Suggested approach: rather than suppressing MTP0001 (which just defers the problem and keeps emitting cancellation state through a deprecated path), migrate TUnit.Engine's cancellation reporting to throw/propagate OperationCanceledException via the cancellation token Microsoft.Testing.Platform already passes through the engine, per the diagnostic's own guidance. That keeps TUnit.Engine aligned with the platform's intended cancellation model rather than accumulating tech debt behind a pragma. Given the scope (5 files touching XML/HTML/GitHub reporters and the message bus), this warrants a small follow-up PR from a maintainer/bot-adjacent contributor rather than folding it into this Renovate PR — Renovate PRs should stay mechanical.
Until that migration lands (or the obsolete member is suppressed as a stopgap with a tracking issue), this PR should stay blocked/rebased rather than merged, despite Renovate's automerge being enabled.
9db2102 to
ab5196b
Compare
ab5196b to
c7ebd5a
Compare
This PR contains the following updates:
18.8.0→18.9.02.2.3→2.3.12.2.3→2.3.12.2.3→2.3.12.2.3→2.3.12.2.3→2.3.12.2.3→2.3.12.2.3→2.3.1Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Mend Renovate.