Skip to content

chore(deps): update verify to 31.24.0#6367

Open
thomhurst wants to merge 1 commit into
mainfrom
renovate/verify
Open

chore(deps): update verify to 31.24.0#6367
thomhurst wants to merge 1 commit into
mainfrom
renovate/verify

Conversation

@thomhurst

@thomhurst thomhurst commented Jul 6, 2026

Copy link
Copy Markdown
Owner

This PR contains the following updates:

Package Type Update Change
Verify nuget minor 31.20.031.24.0
Verify.NUnit nuget minor 31.20.031.24.0
Verify.TUnit nuget minor 31.20.031.24.0

Release Notes

VerifyTests/Verify (Verify)

v31.24.0

Compare Source

  • #​1789 Add ExcludeTargets with converter-side IsTargetExcluded check

v31.23.0

Compare Source

  • #​1785 Fix chunk boundary scrubber bugs and test adapter defects
  • #​1788 Add exclude targets to omit targets by extension

v31.22.0

Compare Source

  • #​1778 Allow conversion splitters for text extensions
  • #​1779 Fix chunk boundary scrubber bugs and test adapter defects
  • #​1781 stop using MSTest metapackage
  • #​1782 Migrate CI to Microsoft.Testing.Platform so all tests run
  • #​1783 Guard against duplicate xunit attachment names
  • #​1784 Add Kill process locking file option

v31.21.0

Compare Source

  • #​1656 throw for greedy RegisterFileConverter
  • #​1762 Reject carriage returns in verified files instead of normalizing
  • #​1767 Fix correctness and perf issues in compare, recording, naming and checks
  • #​1768 Fix VerifySettings copy constructor, temp cleanup, and stream/extensi…
  • #​1769 Fix combination runner/converter, Expecto directory verification, and…
  • #​1770 Fix serialization scrub/convert bugs and reduce per-value scrubbing allocations
  • #​1771 Fix verifier cleanup composition, stream/xml disposal and comparison
  • #​1772 Bump Argon from 0.34.0 to 0.35.0
  • #​1773 Bump DiffEngine from 19.2.0 to 19.3.0
  • #​1774 Clear synchronization context in to task()
  • #​1775 Throw for greedy RegisterFileConverter

    Configuration

    📅 Schedule: (UTC)

    • Branch creation
      • At any time (no schedule defined)
    • Automerge
      • At any time (no schedule defined)

    🚦 Automerge: Enabled.

    Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

    🔕 Ignore: Close this PR and you won't be reminded about these updates again.


    • If you want to rebase/retry this PR, check this box

    This PR has been generated by Mend Renovate.

@thomhurst thomhurst added dependencies Pull requests that update a dependency file MINOR renovate-bot labels Jul 6, 2026
@thomhurst thomhurst enabled auto-merge (squash) July 6, 2026 23:55

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This is an automated Renovate dependency bump: Verify, Verify.NUnit, and Verify.TUnit 31.20.031.21.0 in Directory.Packages.props. No source, test, or snapshot files are touched.

Reviewed the upstream Verify 31.21.0 release notes — it's a bugfix/perf release (compare/recording/naming fixes, reduced scrubbing allocations, VerifySettings copy-constructor and disposal fixes), with no breaking API changes called out. This is a patch-level update to a test-only dependency, so risk is low.

No design, architecture, or maintainability concerns here — nothing to change. LGTM.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Reviewed this Renovate dependency bump (Verify / Verify.NUnit / Verify.TUnit 31.20.031.21.0).

Assessment: Looks good, no issues.

  • Change is minimal and mechanical — 3 lines in Directory.Packages.props, all three related Verify* packages bumped together in lockstep, no other files touched.
  • Checked the release notes for anything relevant to this repo's snapshot-testing setup (per CLAUDE.md, TUnit relies heavily on .verified.txt snapshots). The notable item is #1762 "Reject carriage returns in verified files instead of normalizing" — this could theoretically break snapshot tests if verified files contained CRLF line endings.
  • Verified this isn't a concern here: .gitattributes already forces *.verified.txt and *.received.txt to eol=lf, and a sample of existing .verified.txt files confirms plain LF/ASCII content. No breaking impact expected.
  • No source or test code changes are involved, so no snapshot re-verification is needed for this PR itself.

Safe to merge.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Re-reviewed this Renovate dependency bump (Verify / Verify.NUnit / Verify.TUnit 31.20.031.21.0). The diff is unchanged since the prior reviews on this PR: 3 lines in Directory.Packages.props, all three related packages bumped together in lockstep, no source, test, or .verified.txt snapshot files touched.

Assessment: no issues, safe to merge.

  • Confirmed .gitattributes still forces *.verified.txt/*.received.txt to eol=lf (lines 43-44), so the upstream change to reject CRLF in verified files (VerifyTests/Verify#1762) poses no risk to this repo's snapshots.
  • No breaking API changes in the 31.21.0 release notes — bugfix/perf release (compare/recording/naming fixes, reduced scrubbing allocations, VerifySettings disposal fixes).
  • Purely mechanical, low-risk, test-only dependency update. Nothing architectural to flag.

@claude

claude Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Code Review

Overview: Automated Renovate dependency bump for Verify, Verify.NUnit, and Verify.TUnit from 31.20.031.21.0 (minor version). The diff is a 3-line change to Directory.Packages.props, consistently bumping all three related Verify* packages together.

Analysis:

  • Correctness: All three related Verify packages are bumped in lockstep, which is correct — mismatched Verify/Verify.NUnit/Verify.TUnit versions can cause subtle incompatibilities.
  • Release notes: Per the linked upstream release notes, 31.21.0 contains bug fixes (perf/correctness fixes in compare, recording, naming, and disposal logic; stricter handling of carriage returns in verified files) and no breaking API changes are indicated.
  • Risk: Low risk — this is test-infrastructure tooling (Verify is used for snapshot testing), not a runtime dependency shipped to consumers. Per this repo's rules, snapshot-testing changes ("Quick Fix: Snapshot Tests Failing") are the main thing to watch for here, particularly since 31.21.0 explicitly changes how carriage returns in verified files are handled (rejecting instead of normalizing) — this could cause previously-passing snapshot tests to fail on file the CRLF/LF mismatches.
  • Test coverage: N/A — this is a version bump only, correctness is validated by the existing test/snapshot suite running against the new package version in CI.

Suggestion: No code changes needed. Recommend merging only after confirming CI (especially the snapshot test suites) passes, given the carriage-return handling change noted in the release notes — verify no .verified.txt files contain CRLF line endings that would now fail comparison.

No issues found with the change itself — looks good to merge pending green CI.

@claude

claude Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Code Review

Re-checked — diff is still unchanged (Verify / Verify.NUnit / Verify.TUnit 31.20.031.22.0, scoped entirely to the 3-line Directory.Packages.props bump). No new commits since the last review changed any content.

No design, architecture, or maintainability concerns — mechanical lockstep version bump across the three related Verify* packages, no source/test/snapshot files touched. Safe to merge pending green CI.

@claude

claude Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Code Review

This is a routine Renovate dependency bump: Verify / Verify.NUnit / Verify.TUnit 31.20.031.22.0, isolated to Directory.Packages.props (central package management), so all consuming projects pick up the same version consistently. No source or test code is touched.

Looks good to merge. A couple of notes, not blockers:

  • The Verify changelog between these versions includes a couple of behavior changes worth being aware of given how heavily this repo relies on Verify for snapshot testing (per .claude/docs snapshot-testing conventions): 31.21.0 "Reject carriage returns in verified files instead of normalizing" (previously CR was silently normalized) and "throw for greedy RegisterFileConverter<object>". Neither should affect TUnit's usage as far as the diff shows, and CI (modularpipeline across locales, integration-tests) is passing on this PR, so no snapshot fallout observed.
  • No .verified.txt/.received.txt files are affected, so nothing further to accept here.

No architectural concerns — this is exactly the shape of PR that should stay a pure version bump with no manual intervention.

@claude

claude Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Code Review

Re-checked after Renovate's rebase — diff content is unchanged from the prior review (still Verify / Verify.NUnit / Verify.TUnit 31.20.031.22.0, isolated to the 3-line Directory.Packages.props bump via central package management). No source or test code is touched.

Looks good to merge. Confirmed the one potentially relevant breaking change in this range — Verify 31.21.0's "throw for greedy RegisterFileConverter<object>" — doesn't apply here; the repo has no calls to RegisterFileConverter. No .verified.txt/.received.txt files are affected.

No architectural concerns for a pure version bump like this.

Note: this PR has now received 10+ nearly-identical automated review comments across repeated re-triggers with no diff changes in between. If this review is running on a schedule/webhook rather than only on new commits, it may be worth gating re-review on commit SHA changes to avoid further duplicate comments.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@claude

claude Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Code Review

Re-checked — diff is unchanged (Verify / Verify.NUnit / Verify.TUnit 31.20.031.22.0, all three references bumped consistently in Directory.Packages.props, no other file references the old version). No issues found. Checked for bugs and CLAUDE.md compliance.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Diff has moved since the last review — Renovate rebased this PR onto a new target: Verify / Verify.NUnit / Verify.TUnit 31.20.031.23.0 (previously reviewed at 31.22.0). Still isolated to the same 3-line Directory.Packages.props bump via central package management, all three related packages kept in lockstep. No source, test, or snapshot files touched.

Checked the incremental 31.22.031.23.0 release notes (VerifyTests/Verify#1785, #1788): chunk-boundary scrubber/test-adapter bug fixes, and a new opt-in "exclude targets by extension" config option. Neither is a breaking API change, and the new option is opt-in so it doesn't affect existing usage here.

No architectural or design concerns — this remains a pure, low-risk dependency bump. Safe to merge pending green CI.

@claude

claude Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Code Review

Diff has moved again since the last review — Renovate rebased this PR to target: Verify / Verify.NUnit / Verify.TUnit 31.20.031.24.0 (previously reviewed at 31.23.0). Still isolated to the same 3-line Directory.Packages.props bump via central package management, all three related packages kept in lockstep. No source, test, or .verified.txt snapshot files touched.

The only incremental change since the last review (31.23.031.24.0) is VerifyTests/Verify#1789, "Add ExcludeTargets with converter-side IsTargetExcluded check" — an opt-in addition to the file-converter exclusion API, not a breaking change, and unrelated to how TUnit currently uses Verify.

No architectural or design concerns. This remains a pure, low-risk, test-only dependency update. Safe to merge pending green CI.

@claude

claude Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Code Review

Overview: Automated Renovate PR bumping Verify, Verify.NUnit, and Verify.TUnit from 31.20.031.24.0 (minor version) in Directory.Packages.props. Single file, 3 lines changed, no source changes.

Analysis:

  • All three related Verify* package versions are bumped together and stay in sync — correct, since they need to match.
  • Change is confined to Directory.Packages.props (central package management), consistent with the repo's convention.
  • Reviewed the upstream release notes (31.21.0 → 31.24.0): mostly bug fixes (chunk boundary scrubber, VerifySettings copy constructor, disposal/cleanup) and minor additive features (ExcludeTargets). One note worth flagging: 31.21.0 changes carriage-return handling in verified files ("Reject carriage returns in verified files instead of normalizing" instead of silently normalizing them). This is a potential breaking behavior change for snapshot tests using Verify.TUnit/Verify.NUnit if any .verified.txt files contain CRLF content that was previously being normalized — worth confirming the snapshot test suite (TUnit.Core.SourceGenerator.Tests and friends per CLAUDE.md) still passes cleanly rather than assuming a minor-version bump is risk-free.
  • No code, test, or snapshot files were touched, which is expected for a pure dependency bump — but per this repo's own rule, changes affecting snapshot-testing dependencies should have CI green on the snapshot test job before merge.

Risk: Low overall (minor version, additive/fixes only, single dependency file), but not zero given the CR-handling change above.

CI status at review time: No checks have failed; several (including integration-tests, modularpipeline matrix, claude-review) were still in progress. Recommend waiting for full green, particularly the snapshot/verify-related test jobs, before merge — Renovate has automerge enabled so this should happen automatically once checks pass.

No architectural or design concerns — this is a routine, well-scoped dependency update.

@claude

claude Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Code Review

Re-checked — the diff is unchanged since the last review (Verify / Verify.NUnit / Verify.TUnit 31.20.031.24.0 in Directory.Packages.props, 3 lines, no source/test/snapshot files touched). No new commits or rebases since that review.

All prior concerns were already addressed in earlier passes:

  • All three Verify* packages stay in lockstep.
  • The CR-handling change in 31.21.0 was checked against .gitattributes (*.verified.txt/*.received.txt forced to eol=lf) — no risk.
  • No breaking changes in the 31.21.0→31.24.0 delta relevant to this repo's usage.

No architectural or design concerns. Still safe to merge pending green CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file MINOR renovate-bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants