decide on inkey init obj shape

[spencercap]

current:

export type InkeyConfig = {
	src?: string; // url
	align?: 'center' | 'left' | 'right';
	darkMode?: boolean;
	styles?: InkeyStyleObj;
};

put everything in the styles object? including darkMode and align? or make everything peer for simplicity?
note: styles object might get larger one day...

do we want THIS level of customization or should we have a stylePreset field which takes a specific style id w hardcoded params stored someplace else?

---

more idea:

// more specific field names to account for future addins  
overlayTransparent?: boolean;
overlayBlurBehind?: boolean;
overlayColor?: string; // greyish
bgBlur?: boolean;
bgColor?: string;

[youraerials]

This looks good. I'd like an inkeyLogoGraphic: string; in there as well

[youraerials]

I think the main thing is to just take colors and other value params, not actual CSS code so people can't hack things just by injecting CSS

[spencercap]

@enceladus thoughts on the stylePreset thing?

[enceladus]

I think the current config makes sense. styles affects the look & feel. align affects the positioning, makes sense that it wouldn't be in that object. darkMode is more of a "state" than a persistent style (ie it might change during runtime), so it also makes sense that it's separate.

Once we have a need for stylePreset, let's add it. I don't see much use in adding parameters we have no immediate use for. We change our minds too often to be thinking that far ahead. And we already have one un-implemented parameter on this object already (darkMode).

@youraerials where would inkeyLogoGraphic be implemented?

[spencercap]

@enceladus let's land on some consistent + obvious names for these style obj fields. i was updating them all the pkgs up the try so that the typings were correct up in algjs and i found blur and blurOverlay to behave inverse to how i expected

[enceladus]

"overlay" is a pretty common name for the background div that covers a page behind a modal window, so I think it is relatively clear that blurOverlay would blur everything under the overlay. But I can agree that blur could be more specific, perhaps modalBlur. I am only a bit hesitant in changing these parameter names because it requires so much overhead to update every instance of Inkey. I think if we change the names, we should prepare a branch / PR that can wait until a bigger change. Otherwise we are spending a lot of time keeping up these very incremental version changes that don't accomplish much.

But, anyway — I suggest something like this: (current names in comments)

overlayColor?: string; // containerBg
overlayBlur?: boolean; // blurOverlay
modalTransparent?: boolean; // transparent
modalBlur?: boolean; // blur