chore: pr comments

Author: ctrlc03

crates/events/src/enclave_event/compute_request/zk.rs

@@ -15,15 +15,15 @@ use serde::{Deserialize, Serialize};
 /// ZK proof generation request variants.
 #[derive(Clone, Debug, PartialEq, Eq, Hash, Serialize, Deserialize)]
 pub enum ZkRequest {
-    /// Generate proof for BFV public key (T0).
+    /// Generate proof for BFV public key (C0).
     PkBfv(PkBfvProofRequest),
-    /// Generate proof for PK generation (T1).
+    /// Generate proof for PK generation (C1).
     PkGeneration(PkGenerationProofRequest),
-    /// Generate proof for share and esm computation (T2a and T2b).
+    /// Generate proof for share and esm computation (C2a and C2b).
     ShareComputation(ShareComputationProofRequest),
 }
 
-/// Request to generate a proof for share computation (T2a or T2b).
+/// Request to generate a proof for share computation (C2a or C2b).
 #[derive(Derivative, Clone, PartialEq, Eq, Hash, Serialize, Deserialize)]
 #[derivative(Debug)]
 pub struct ShareComputationProofRequest {
@@ -39,7 +39,7 @@ pub struct ShareComputationProofRequest {
     pub committee_size: CiphernodesCommitteeSize,
 }
 
-/// Request to generate a proof for BFV public key generation (T0).
+/// Request to generate a proof for BFV public key generation (C0).
 #[derive(Derivative, Clone, PartialEq, Eq, Hash, Serialize, Deserialize)]
 #[derivative(Debug)]
 pub struct PkBfvProofRequest {
@@ -49,7 +49,7 @@ pub struct PkBfvProofRequest {
     pub params_preset: BfvPreset,
 }
 
-/// Request to generate a proof for PK share generation (T1a).
+/// Request to generate a proof for PK share generation (C1).
 #[derive(Derivative, Clone, PartialEq, Eq, Hash, Serialize, Deserialize)]
 #[derivative(Debug)]
 pub struct PkGenerationProofRequest {

crates/events/src/enclave_event/share_computation_proof_signed.rs

@@ -4,7 +4,7 @@
 // without even the implied warranty of MERCHANTABILITY
 // or FITNESS FOR A PARTICULAR PURPOSE.
 
-use crate::{E3id, ProofType, SignedProofPayload};
+use crate::{E3id, SignedProofPayload};
 use actix::Message;
 use serde::{Deserialize, Serialize};
 use std::fmt::{self, Display};
@@ -14,7 +14,6 @@ use std::fmt::{self, Display};
 pub struct ShareComputationProofSigned {
     pub e3_id: E3id,
     pub party_id: u64,
-    pub proof_type: ProofType,
     pub signed_proof: SignedProofPayload,
 }
 

crates/keyshare/src/threshold_keyshare.rs

@@ -465,14 +465,15 @@ impl ThresholdKeyshare {
             return Ok(());
         }
 
+        let proof_type = msg.signed_proof.payload.proof_type;
         info!(
             "Received ShareComputationProofSigned ({:?}) for party {} E3 {}",
-            msg.proof_type, msg.party_id, msg.e3_id
+            proof_type, msg.party_id, msg.e3_id
         );
 
         self.state.try_mutate(&ec, |s| {
             let current: AggregatingDecryptionKey = s.clone().try_into()?;
-            let updated = match msg.proof_type {
+            let updated = match proof_type {
                 ProofType::T1SkShareComputation => AggregatingDecryptionKey {
                     signed_sk_share_computation_proof: Some(msg.signed_proof),
                     ..current

crates/zk-prover/src/actors/proof_request.rs

@@ -320,7 +320,6 @@ impl ProofRequestActor {
             ShareComputationProofSigned {
                 e3_id: e3_id.clone(),
                 party_id,
-                proof_type: ProofType::T1SkShareComputation,
                 signed_proof: signed_sk_share,
             },
             ec.clone(),
@@ -332,7 +331,6 @@ impl ProofRequestActor {
             ShareComputationProofSigned {
                 e3_id: e3_id.clone(),
                 party_id,
-                proof_type: ProofType::T1ESmShareComputation,
                 signed_proof: signed_e_sm_share,
             },
             ec.clone(),