Volatile members

[aahaselgrove]

My understanding is that it is correct to call ButtonProcess from a timer. If this is the case, would it be correct for the (non-array) members of the Debouncer struct to be volatile?

[tcleg]

Usually, I would call ButtonProcess in the main loop.

I'm an old school programmer who likes to do everything outside of an
interrupt. So, I would (precluding any kind of RTOS) set a volatile flag
inside the interrupt routine of the timer and have the main loop respond by
calling all the needed functions.

The members can be set to volatile if you would like to use the functions
within a timer interrupt, though. That's fine.

It might be good for me to commit a change to the code with some added
documentation on the use of the functions within interrupt routines in
general. Not a bad idea.
On May 19, 2016 9:36 AM, "Dimpl" notifications@github.com wrote:

My understanding is that it is correct to call ButtonProcess from a timer.
If this is the case, would it be correct for the (non-array) members of the
Debouncer struct to be volatile? I was having an unusual issue, and making
this the case resolved it.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#1

[LarsSDahlberg]

Hi,
I've used your code (C++) (and modified to support a 16 bit button port - I use PCF8575) and it works great in a polled fasion. I would however like to utilise the interrupt instead but I don't quite understand how to incorporate your code in an interrupt fasion. Before incorporating your code I had my input under interrupt control where the interrupt routine just sets a flag I check in the main loop.

in your other post here aboove you mention you planned to update your exampple with info around interrupt handling - is that something you would do soon?

Thanks for sharing this gr8 code...

Kind Regards
Lars Dahlberg