Refactor API (AccountGo#73)

* Remove non used services and managers

removed unused signinmanager and security service out of the
AccountController

* Use Object initializers and refactor string array

* Delete unused else

* Return the right audit dto and fix intendation

use the right audit dto to return, use linq and object initializer to
create the instance of auditlogsdto and fix general intendation with
ctrl+k+d

* Fix style and refactor initialization

Improve if-else's and use object initializer

* Refactor Administration controller

Used var type for clear data types and refactored the initializing data
method into several methods about the context. Also refactored those
methods

Author: igeligel

src/Api/Controllers/AccountController.cs

@@ -1,4 +1,4 @@
-using Api.Data;
+using Api.Data;
 using Microsoft.AspNetCore.Identity;
 using Microsoft.AspNetCore.Mvc;
 using Services.Administration;
@@ -10,9 +10,7 @@ namespace Api.Controllers
     public class AccountController : BaseController
     {
         private readonly UserManager<ApplicationUser> _userManager;
-        private readonly SignInManager<ApplicationUser> _signInManager;
         private readonly IAdministrationService _administrationService;
-        private readonly ISecurityService _securityService;
 
         public AccountController(
             UserManager<ApplicationUser> userManager,
@@ -22,9 +20,7 @@ ISecurityService securityService
             )
         {
             _userManager = userManager;
-            _signInManager = signInManager;
             _administrationService = administrationService;
-            _securityService = securityService;
         }
 
         [HttpPost]
@@ -76,7 +72,6 @@ public async System.Threading.Tasks.Task<IActionResult> SignIn([FromBody]dynamic
         [Route("[action]")]
         public async System.Threading.Tasks.Task<IActionResult> AddNewUser([FromBody]dynamic registerViewModel)
         {
-            string[] errors = null;
             try
             {
                 if (registerViewModel == null)
@@ -93,24 +88,24 @@ public async System.Threading.Tasks.Task<IActionResult> AddNewUser([FromBody]dyn
                 var result = await _userManager.CreateAsync(user, password);
                 if (result.Succeeded)
                 {
-                    Core.Domain.Security.User newUser = new Core.Domain.Security.User();
-                    newUser.EmailAddress = username;
-                    newUser.UserName = username;
-                    newUser.Firstname = firstName;
-                    newUser.Lastname = lastName;
+                    Core.Domain.Security.User newUser =
+                        new Core.Domain.Security.User
+                        {
+                            EmailAddress = username,
+                            UserName = username,
+                            Firstname = firstName,
+                            Lastname = lastName
+                        };
 
                     _administrationService.SaveUser(newUser);
 
                     return new ObjectResult(result);
                 }
-                else
-                {
-                    return new BadRequestObjectResult(result);
-                }
+                return new BadRequestObjectResult(result);
             }
             catch(System.Exception ex)
             {
-                errors = new string[1] { ex.InnerException != null ? ex.InnerException.Message : ex.Message };
+                var errors = new[] { ex.InnerException != null ? ex.InnerException.Message : ex.Message };
                 return new BadRequestObjectResult(errors);
             }
         }