SD-3386 - fix: deletion handling across paragraph boundaries#3664
Open
chittolinag wants to merge 4 commits into
Open
SD-3386 - fix: deletion handling across paragraph boundaries#3664chittolinag wants to merge 4 commits into
chittolinag wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…e-selection-inserts-spurious
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 737a2ae4be
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…e-selection-inserts-spurious
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
In suggesting mode, deleting a selection that spans two paragraphs pushed the remainder of the second paragraph onto a new line, as if Enter was pressed. On the real Backspace/Delete keymap path the tracked interception could crash position mapping (
RangeError: Position NaN), and the dispatch fallback then deleted the text untracked. Accepting or rejecting the change failed silently, leaving the inline decoration painted, and the hover bubble reported "Accepted" even after a reject.Proposed solution
replaceStep.jsnow compiles slices without inline leaf content as plain tracked deletions, skips the invert/mirror mapping pairing for that mark-only compile (the source of the NaN), and emits an explicit caret hint at the deletion's left edge.