Fix Docker Hub/Quay.io registry login conditions and snapshot creation command syntax

* Add step IDs to Docker Hub and Quay.io login actions
* Replace continue-on-error with conditional execution based on login success
* Fix openstack volume snapshot create command - move snapshot name to end as positional argument
* Remove --name flag from snapshot creation (not supported in positional syntax)

Author: Kevin Allioli

.github/workflows/docker-build.yml

@@ -55,6 +55,7 @@ jobs:
 
       # Docker Hub
       - name: Login to Docker Hub
+        id: dockerhub_login
         uses: docker/login-action@v3
         with:
           username: ${{ secrets.DOCKERHUB_USERNAME }}
@@ -63,6 +64,7 @@ jobs:
 
       # Quay.io
       - name: Login to Quay.io
+        id: quay_login
         uses: docker/login-action@v3
         with:
           registry: quay.io
@@ -85,6 +87,7 @@ jobs:
           cache-to: type=gha,mode=max
 
       - name: Build and push to Docker Hub
+        if: steps.dockerhub_login.outcome == 'success'
         uses: docker/build-push-action@v5
         with:
           context: .
@@ -94,9 +97,9 @@ jobs:
             ${{ env.DOCKERHUB_REPO }}/${{ env.IMAGE_NAME }}:latest
           cache-from: type=gha
           cache-to: type=gha,mode=max
-        continue-on-error: true
 
       - name: Build and push to Quay.io
+        if: steps.quay_login.outcome == 'success'
         uses: docker/build-push-action@v5
         with:
           context: .
@@ -106,7 +109,6 @@ jobs:
             quay.io/${{ env.QUAY_REPO }}/${{ env.IMAGE_NAME }}:latest
           cache-from: type=gha
           cache-to: type=gha,mode=max
-        continue-on-error: true
 
       - name: Summary
         run: |

openstack-backup.sh

@@ -124,7 +124,7 @@ create_backup_via_snapshot() {
     echo "Step 1/5: Creating snapshot of volume ${volume_name}..."
     local snapshot_name="temp_snap_${timestamp}_${volume_name}"
     local snapshot_output
-    snapshot_output=$(openstack volume snapshot create --volume "$volume_id" --name "$snapshot_name" -f json 2>&1) || {
+    snapshot_output=$(openstack volume snapshot create --volume "$volume_id" -f json "$snapshot_name" 2>&1) || {
         echo "Error: Failed to create snapshot for volume ${volume_name}: ${snapshot_output}"
         return 1
     }