Skip to content

rollback: deploy-on-merge does not advance the deploy-history ring #385

Description

@joshua-temple

Surfaced while debugging the rollback-dispatch fleet suite. Only promote and rollback finalize call PushPreviousSnapshot; the deploy-on-merge (orchestrate) path does not push a ring snapshot. So after seed+advance deploys, state..previous holds whatever was there before (a stale/cross-run entry), and a no-target rollback resolves its target from that, not from the just-deployed history. The rollback-dispatch suite was rewritten to anchor its assertion on cascade rollback preflight rather than a self-seeded sha to work around this. Product question: should deploy-on-merge advance the ring so a no-target rollback after a deploy returns to the prior deploy? Decide intended semantics and align the code + docs.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions