Skip to content

"headers" option not used when rendering the page. #82

Description

@bhumikaSinghal

I wanted to use the Basic Auth headers while rendering the page using phatomJs. However, even though I set this var while defining the var render, it is not reflected/used.

If I modify the following in index.js:
ropts = xtend({
url : url,
quality:opts.quality,
format : opts.format,
printMedia : opts.printMedia,
expects : opts.expects,
timeout : opts.timeout
}, ropts);

to:

ropts = xtend({
url : url,
quality:opts.quality,
format : opts.format,
printMedia : opts.printMedia,
expects : opts.expects,
timeout : opts.timeout,
headers : opts.headers
}, ropts);

then the page renders fine. If this is the case then this ropts object is missing other options that can be set and thus index.js should be updated. Is this the correct approach or am I missing something?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions