Add request: Request argument to column formatter function

[ycuk]

Checklist

• There are no similar issues or pull requests for this yet.

Is your feature related to a problem? Please describe.

Cant get request.url_for() to make link to another table

Describe the solution you would like.

from starlette.requests import Request

def formatter(
    model,
    attribute,
    request: Request, # this is new argument
):
    # `model` is model instance
    # `attribute` is a Union[ColumnProperty, RelationshipProperty]
    request.url_for('admin:details', identity='sometable', pk=some_id)

Describe alternatives you considered

No response

Additional context

No response

[mmzeynalli]

Can you clarify your issue please? And provide minimal example?

[ycuk]

class SomeView(ModelView, model=models.Some):
    column_list = ('id', '_to_relation')

    @staticmethod
    def _to_relation(model, field):
        href = request.url_for('admin:edit', identity='some_rel', pk=event.some_rel_id)
        return Markup(f'<a href="{href}" target="_blank">Some rel</a>')

    column_formatters = {
        '_to_relation': _to_relation,
    }

Btw would be good to have self also to access session maker and the rest methods from view or even fastapi app lifespan context.

[mmzeynalli]

Currently, _build_url_for function does indeed redirect to other model.

However, if I understand you correctly, you want to redirect to edit view right?

[mmzeynalli]

If yes, you can do the following. By default, name is "admin:detail" for FK objects, you just override that:

class SomeView(ModelView, model=models.Some):
    column_list = ('id', '_to_relation')

     def _build_url_for(self, name: str, request: Request, obj: Any) -> URL:
        if not obj.__class__ is self.model:
            name = "admin:edit"

        return request.url_for(
            name,
            identity=self.identity,
            pk=get_object_identifier(obj),
        )

[ycuk]

If you suggest to change existing links, then actually no.
It is custom column. As you can see _to_relation method uses request, but it nowhere to go, no argument. I cant call url_for.

[mmzeynalli]

To be honest, Im having hard time understanding your problem. Please give full minimal example, what is output and what output you expect it to have.