StaggeredGridView mScrollListener null

[fanno]

I don't need the listener in my case... sooo ...

@Override
protected void onScrollChanged(int x, int y, int oldX, int oldY) {
    super.onScrollChanged(x, y, oldX, oldY);

    if ( Math.abs(y - oldY) < 2 || 
            y + getHeight() >= mTopLayout.getMeasuredHeight() ||
            y <= SCROLL_OFFSET+1 ) {
        if( mScrollListener != null ) {
            if( y <= SCROLL_OFFSET+1 ) {
                mScrollListener.onTop();
            } else if( y + getHeight() >= mTopLayout.getMeasuredHeight() ) {
                mScrollListener.onBottom();
            }
        }
    } else {
        mScrollListener.onScroll(); 
    }
}

Should be changed to:

@Override
protected void onScrollChanged(int x, int y, int oldX, int oldY) {
    super.onScrollChanged(x, y, oldX, oldY);

    if ( Math.abs(y - oldY) < 2 || 
            y + getHeight() >= mTopLayout.getMeasuredHeight() ||
            y <= SCROLL_OFFSET+1 ) {
        if( mScrollListener != null ) {
            if( y <= SCROLL_OFFSET+1 ) {
                mScrollListener.onTop();
            } else if( y + getHeight() >= mTopLayout.getMeasuredHeight() ) {
                mScrollListener.onBottom();
            }
        }
    } else {
        if( mScrollListener != null ) {
            mScrollListener.onScroll(); 
        }
    }
}

[smanikandan14]

Agree. I would add a null check for the listener check.

[fanno]

This may be a side question. what are the "con's" using this instead of a gridview?

i am find with a normal grid vide the problem is the the height are not always the same and the views over lap sometimes..

but i am scared i can easy run in to memory issues with this view. as it is a scroll view and all views are still in memory when not displayed ?

what is your experiance ?

[smanikandan14]

Yes thats right. Use this view only if you have a limited number of items to display. Fixed number of items. Otherwise i would suggest you to use etsy staggered grid view which does view recycling.

[fanno]

I will take a look at that one also, happy to try this and improve it a bit =)

have good day.