Remove no longer necessary uploaded files structure migration (#4711)

Author: vitek-rostislav

build.xml

@@ -147,7 +147,7 @@
 
     <target name="build-deploy-part-1-db-independent" depends="build-version-generate,clean,composer-prod,dirs-create,assets,npm" description="First part of application build for production preserving your DB (can be run without maintenance page)."/>
 
-    <target name="build-deploy-part-2-db-dependent" depends="check-migrate-uploaded-files,elasticsearch-index-migrate,redis-check,db-migrations,domains-data-create,friendly-urls-generate,domains-urls-replace,migrate-uploaded-files-force,warmup" description="Second part of application build for production preserving your DB (must be run with maintenance page when containing DB migrations)."/>
+    <target name="build-deploy-part-2-db-dependent" depends="elasticsearch-index-migrate,redis-check,db-migrations,domains-data-create,friendly-urls-generate,domains-urls-replace,warmup" description="Second part of application build for production preserving your DB (must be run with maintenance page when containing DB migrations)."/>
 
     <target name="build-deploy-part-3-non-blocking" depends="run-post-deploy-tasks" description="Third part of application build for production. Non-blocking tasks that run after maintenance page is turned off."/>
 
@@ -173,13 +173,6 @@
         </copy>
     </target>
 
-    <target name="check-migrate-uploaded-files" description="Checks if the uploaded files structure is compatible with 'migrate-uploaded-files'." hidden="true">
-        <exec executable="${path.php.executable}" passthru="true" checkreturn="true">
-            <arg value="${path.bin-console}"/>
-            <arg value="shopsys:uploaded-files:check-migrate"/>
-        </exec>
-    </target>
-
     <target name="checks" depends="checks-internal,standards,tests" description="Runs internal checks, coding standards and runs unit, DB and smoke tests."/>
 
     <target name="checks-ci" depends="checks-internal,test-demo-data,tests-functional,tests-smoke,tests-acceptance" description="Runs internal checks and runs DB, smoke and acceptance tests."/>
@@ -847,21 +840,6 @@
         </exec>
     </target>
 
-    <target name="migrate-uploaded-files" description="Move all uploaded files from subdirectories to the top level directory." hidden="true">
-        <exec executable="${path.php.executable}" passthru="true" checkreturn="true">
-            <arg value="${path.bin-console}"/>
-            <arg value="shopsys:uploaded-files:migrate"/>
-        </exec>
-    </target>
-
-    <target name="migrate-uploaded-files-force" description="Force move (without check) all uploaded files from subdirectories to the top level directory." hidden="true">
-        <exec executable="${path.php.executable}" passthru="true" checkreturn="true">
-            <arg value="${path.bin-console}"/>
-            <arg value="shopsys:uploaded-files:migrate"/>
-            <arg value="--force"/>
-        </exec>
-    </target>
-
     <target name="npm" description="Build node modules.">
         <phingcall target="npm-install-dependencies"/>
         <phingcall target="npm-export-translations"/>

src/Command/CheckMigrateUploadedFilesCommand.php

@@ -27,7 +27,6 @@ class Setting
     public const string TRANSFER_DAYS_BETWEEN_STOCKS = 'transferDaysBetweenStocks';
     public const string FEED_DELIVERY_DAYS_FOR_OUT_OF_STOCK_PRODUCTS = 'feedDeliveryDaysForOutOfStockProducts';
     public const string CUSTOMER_USER_DEFAULT_GROUP_ROLE_ID = 'customerUserDefaultGroupRoleId';
-    public const string FILE_STRUCTURE_MIGRATED_FOR_RELATIONS = 'fileStructureMigratedForRelations';
     public const string CSP_HEADER = 'cspHeader';
 
     /**

src/Command/MigrateUploadedFilesCommand.php

@@ -0,0 +1,19 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Shopsys\FrameworkBundle\Migrations;
+
+use Doctrine\DBAL\Schema\Schema;
+use Override;
+use Shopsys\MigrationBundle\Component\Doctrine\Migrations\AbstractMigration;
+
+final class Version20260720150326 extends AbstractMigration
+{
+    #[Override]
+    public function up(Schema $schema): void
+    {
+        $this->sql('DELETE FROM setting_values WHERE name = \'fileStructureMigratedForRelations\'');
+        $this->sql('DELETE FROM migrations WHERE version = \'Shopsys\FrameworkBundle\Migrations\Version20240730113802\'');
+    }
+}

src/Component/Setting/Setting.php

@@ -7,10 +7,6 @@ services:
     Shopsys\FrameworkBundle\Command\:
         resource: '../../Command'
 
-    Shopsys\FrameworkBundle\Command\CheckMigrateUploadedFilesCommand:
-        arguments:
-            - '%shopsys.uploaded_file_dir%'
-
     Shopsys\FrameworkBundle\Command\ConfigureDomainsUrlsCommand:
         arguments:
             $configFilepath: '%shopsys.domain_urls_config_filepath%'
@@ -26,10 +22,6 @@ services:
     Shopsys\FrameworkBundle\Command\ExtendedClassesAnnotationsCommand:
         autoconfigure: false
 
-    Shopsys\FrameworkBundle\Command\MigrateUploadedFilesCommand:
-        arguments:
-            - '%shopsys.uploaded_file_dir%'
-
     # the command is supposed to be used in DEV environment only so it is configured in services_dev.yaml
     Shopsys\FrameworkBundle\Command\ReplaceObsoleteIconsCommand:
         autoconfigure: false