Skip to content

Channel branding sed in trivalent.spec has been a no-op since M143 #821

Description

@aaravrav

This line no longer matches anything:

sed -i 's/getenv("CHROME_VERSION_EXTRA")/"%{chromium_name}"/' chrome/common/channel_info_posix.cc

Since it exits 0, it has been silently failing since Chromium 143.0.7499.95, when the getenv calls were consolidated into a single helper. So with CHROME_VERSION_EXTRA unset, the channel name resolves to an empty string

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    Priority

    None yet

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions