Suggest type next to visibility for const items

[reddevilmidzy]

resolve: #157368

Adjusts the type const suggestion to preserve visibility ordering, so pub const is suggested as pub type const instead of type pub const.

[rustbot]

HIR ty lowering was modified

cc @fmease

[rustbot]

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: compiler
• compiler expanded to 73 candidates
• Random selection from 17 candidates

[petrochenkov]

r? compiler

[Kivooeo]

Hey, thanks for a PR, I'm a bit busy this week. I will try to review within next 3 days

[Unique-Usman]

I went through the pr, looks good. There is already an alternative test if it is an external crate(non-local) at tests/ui/const-generics/mgca/non-local-const-without-type_const.rs, so, not needed for this pr since it exist.

[estebank]

There is some code duplication between the branches, but that's ok. One thing that'd be nice to have is a check for whether the feature is enabled in order to add a note explaining that this change only would work on nightly (like we do in the errors when using a feature that isn't enabled).

Other than that, r=me.

[Kivooeo]

I'd change this match to something like this

View changes since this review

[Kivooeo]

@rustbot author

[reddevilmidzy]

There is some code duplication between the branches, but that's ok. One thing that'd be nice to have is a check for whether the feature is enabled in order to add a note explaining that this change only would work on nightly (like we do in the errors when using a feature that isn't enabled).

Other than that, r=me.

Am I understanding correctly that you mean we should add this note only when min_generic_const_args is disabled?

If that's my understanding, then for this test case, when MGCA is not enabled, the code compiles successfully instead of emitting an error with a suggestion to use type const.

[reddevilmidzy]

thank you for the review :)
@rustbot ready