rustdoc: IXCRE: Preserve sizedness bounds on type params belonging to the parent item by fmease · Pull Request #157262 · rust-lang/rust

fmease · 2026-06-01T16:03:14Z

rustbot · 2026-06-01T16:03:21Z

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: rustdoc
rustdoc expanded to 9 candidates
Random selection from GuillaumeGomez, camelid, lolbinarycat, notriddle

…rent item

fmease · 2026-06-01T16:05:47Z

@@ -1201,20 +1201,17 @@ impl GenericBound {
    }

    fn is_bounded_by_lang_item(&self, tcx: TyCtxt<'_>, lang_item: LangItem) -> bool {


drive-by refactoring here and one below

View changes since the review

fmease · 2026-06-01T16:07:20Z

Merged into the new sized-bounds.rs test so we don't have 1000s of micro tests for cross-crate Sized bounds. Of course, there are still more out there which aren't so micro like inline_cross/impl-sized...

View changes since the review

fmease · 2026-06-02T07:03:21Z

+        // This transformation is only valid on type parameters defined on the closest item.
+        // If the parameter was defined by the parent item we know that the sizedness bound
+        // *has* to be user-written in which case we have to preserve it as is.
+        let Some(param_sizedness) = type_params.get_mut(param) else { return true };


This is the core change. All changes around it are basically only refactoring because I got so annoyed at the state of things (cc issue #157247) that I couldn't help myself, I had to jettison the jank...

Lmk if I should be more disciplined and split this into two+ commits for ease of reviewing.

View changes since the review

notriddle · 2026-06-03T15:32:32Z

@bors r+

rust-bors · 2026-06-03T15:32:35Z

📌 Commit 5a302ff has been approved by notriddle

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened.

…bounds-on-parent-params, r=notriddle rustdoc: IXCRE: Preserve sizedness bounds on type params belonging to the parent item Fixes rust-lang#144015.

@clarfonthey

Rollup of 12 pull requests Successful merges: - #157085 (powerpc: warn against incorrect values for ABI-relevant target features) - #157170 (Use `impl` restrictions in `std`, `core`) - #157217 ([tiny] remove unecessary `.into()` calls) - #157262 (rustdoc: IXCRE: Preserve sizedness bounds on type params belonging to the parent item) - #157379 (Some more simple per-owner resolver changes) - #157381 (librustdoc: fix CSS border issue to support Firefox high contrast mode) - #155512 (interpreter: improve comments and error message in mir_assign_valid_types) - #157254 (Correct description of panic.rs) - #157290 (interpret: fix mir::UnOp layout computation) - #157332 (Rewrite target checking for `#[sanitize]`) - #157351 (Avoid leaking the query-job collection warning into the panic query stack) - #157389 (Add @clarfonthey to libs review rotation)

Rollup merge of #157262 - fmease:rustdoc-preserve-sizedness-bounds-on-parent-params, r=notriddle rustdoc: IXCRE: Preserve sizedness bounds on type params belonging to the parent item Fixes #144015.

@clarfonthey

Rollup of 12 pull requests Successful merges: - rust-lang/rust#157085 (powerpc: warn against incorrect values for ABI-relevant target features) - rust-lang/rust#157170 (Use `impl` restrictions in `std`, `core`) - rust-lang/rust#157217 ([tiny] remove unecessary `.into()` calls) - rust-lang/rust#157262 (rustdoc: IXCRE: Preserve sizedness bounds on type params belonging to the parent item) - rust-lang/rust#157379 (Some more simple per-owner resolver changes) - rust-lang/rust#157381 (librustdoc: fix CSS border issue to support Firefox high contrast mode) - rust-lang/rust#155512 (interpreter: improve comments and error message in mir_assign_valid_types) - rust-lang/rust#157254 (Correct description of panic.rs) - rust-lang/rust#157290 (interpret: fix mir::UnOp layout computation) - rust-lang/rust#157332 (Rewrite target checking for `#[sanitize]`) - rust-lang/rust#157351 (Avoid leaking the query-job collection warning into the panic query stack) - rust-lang/rust#157389 (Add @clarfonthey to libs review rotation)

Mark-Simulacrum · 2026-06-09T01:47:16Z

@rust-timer build 3b5acb2

cc rollup result - #157398 (comment) / https://perf.rust-lang.org/compare.html?start=9c963eecaaa5e9ef270e235a8b35f05e33b597ed&end=b354133fb126352871bea4b40795a45739adff2b&stat=instructions%3Au

rust-timer · 2026-06-09T02:28:02Z

Finished benchmarking commit (3b5acb2): comparison URL.

Overall result: ❌ regressions - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.1%, 0.3%]	4
Regressions ❌ (secondary)	0.2%	[0.1%, 0.3%]	16
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[0.1%, 0.3%]	4

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (primary -2.3%, secondary -2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.1%]	1
All ❌✅ (primary)	-2.3%	[-2.3%, -2.3%]	1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 519.257s -> 511.878s (-1.42%)
Artifact size: 400.68 MiB -> 400.73 MiB (0.01%)

Mark-Simulacrum · 2026-06-09T02:32:40Z

Regressions look roughly reasonable for a correctness fix.

rustbot assigned notriddle Jun 1, 2026

fmease force-pushed the rustdoc-preserve-sizedness-bounds-on-parent-params branch from 9cadf69 to 5a302ff Compare June 1, 2026 16:05

rustdoc: Preserve sizedness bounds on type params belonging to the pa…

5a302ff

…rent item

fmease commented Jun 1, 2026

View reviewed changes

fmease changed the title ~~rustdoc: Preserve sizedness bounds on type params belonging to the parent item~~ rustdoc: IXCRE: Preserve sizedness bounds on type params belonging to the parent item Jun 1, 2026

fmease commented Jun 2, 2026

View reviewed changes

fmease mentioned this pull request Jun 2, 2026

rustdoc: fix ICE when delegating functions with impl Trait as argument type #156498

Open

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2026

JonathanBrouwer mentioned this pull request Jun 3, 2026

Rollup of 8 pull requests #157387

Closed

jhpratt mentioned this pull request Jun 3, 2026

Rollup of 12 pull requests #157398

Merged

rust-bors Bot merged commit 5478269 into rust-lang:main Jun 3, 2026
12 checks passed

rustbot added this to the 1.98.0 milestone Jun 3, 2026

fmease deleted the rustdoc-preserve-sizedness-bounds-on-parent-params branch June 4, 2026 05:25

This comment has been minimized.

Sign in to view

rustbot added the perf-regression Performance regression. label Jun 9, 2026

Mark-Simulacrum added the perf-regression-triaged The performance regression has been triaged. label Jun 9, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

rustdoc: IXCRE: Preserve sizedness bounds on type params belonging to the parent item#157262

rustdoc: IXCRE: Preserve sizedness bounds on type params belonging to the parent item#157262
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
fmease:rustdoc-preserve-sizedness-bounds-on-parent-params

fmease commented Jun 1, 2026 •

edited by rustbot

Loading

Uh oh!

rustbot commented Jun 1, 2026

Uh oh!

fmease Jun 1, 2026 •

edited by rustbot

Loading

Uh oh!

fmease Jun 1, 2026 •

edited by rustbot

Loading

Uh oh!

fmease Jun 2, 2026 •

edited

Loading

Uh oh!

notriddle commented Jun 3, 2026

Uh oh!

rust-bors Bot commented Jun 3, 2026

Uh oh!

Uh oh!

Mark-Simulacrum commented Jun 9, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Jun 9, 2026

Uh oh!

Mark-Simulacrum commented Jun 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		@@ -1201,20 +1201,17 @@ impl GenericBound {
		}

		fn is_bounded_by_lang_item(&self, tcx: TyCtxt<'_>, lang_item: LangItem) -> bool {

Uh oh!

Conversation

fmease commented Jun 1, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 1, 2026

Uh oh!

fmease Jun 1, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fmease Jun 1, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fmease Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

notriddle commented Jun 3, 2026

Uh oh!

rust-bors Bot commented Jun 3, 2026

Uh oh!

Uh oh!

Mark-Simulacrum commented Jun 9, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Jun 9, 2026

Overall result: ❌ regressions - please read:

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Mark-Simulacrum commented Jun 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fmease commented Jun 1, 2026 •

edited by rustbot

Loading

fmease Jun 1, 2026 •

edited by rustbot

Loading

fmease Jun 1, 2026 •

edited by rustbot

Loading

fmease Jun 2, 2026 •

edited

Loading