resolve: Partially convert ambiguous_glob_imports lint into a hard error

[petrochenkov]

View all comments

I'm tired of this logic interfering with any attempts to fix or refactor glob imports.

Change description for lang team: #149195 (comment).
Part of #114095.

[rustbot]

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

[rustbot]

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[petrochenkov]

@bors try

[rust-bors]

☀️ Try build successful (CI)
Build commit: 446cb60 (446cb600aa4837dd6c513f14fa0d25a909b177d7, parent: e22dab387f6b4f6a87dfc54ac2f6013dddb41e68)

[petrochenkov]

@craterbot check

[craterbot]

👌 Experiment pr-149195 created and queued.
🤖 Automatically detected try build 446cb60
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🚧 Experiment pr-149195 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🎉 Experiment pr-149195 is completed!
📊 2676 regressed and 6 fixed (741888 total)
📊 2000 spurious results on the retry-regessed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-149195/retry-regressed-list.txt ↩

[nnethercote]

@petrochenkov: seems like a lot of regressions :( Should I review this?

[petrochenkov]

@petrochenkov: seems like a lot of regressions :( Should I review this?

Not yet.
@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[petrochenkov]

The largest part of the regressions are from openssl-0.10.*, it's a known issue that is addressed by #147984.
So this is blocked by #147984 now.
@rustbot blocked

[yaahc]

Correct me if I'm wrong on this one

@rustbot author

[petrochenkov]

Is there an FCW that will get emitted if the crate-specific hacks get hit?

Yes, ambiguous_glob_imports.
Crate-specific hacks in this case turn a hard error into the lint (which is deny-by-default and report-in-deps now).

[rust-rfcbot]

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

[petrochenkov]

@rustbot ready
r? @mu001999

[mu001999]

@rustbot author

View changes since this review

[petrochenkov]

@rustbot ready

[mu001999]

r=me after CI green

View changes since this review

[petrochenkov]

@bors r=mu001999

[rust-bors]

📌 Commit a0a7e16 has been approved by mu001999

It is now in the queue for this repository.

[rust-bors]

💔 Test for ba66bad failed: CI. Failed job:

• auto - x86_64-msvc-ext1 (web logs, enhanced plaintext logs)

[petrochenkov]

Ugh, I'll try to send a fix to net2, although it was last updated 3 years ago.
@alexcrichton will you accept a patch to https://crates.io/crates/net2 just to fix cargotest?

The root test is this cargotest:

    Test {
        name: "iron",
        repo: "https://github.com/iron/iron",
        sha: "cf056ea5e8052c1feea6141e40ab0306715a2c33",
        lock: None,
        packages: &[],
        features: None,
        manifest_path: None,
        filters: &[],
    },

There's no lock, so I guess the update to net2 should propagate.
iron was also not updated for 5 years.

I guess the alternative is removing iron from cargotest.

[alexcrichton]

I unfortunately don't have access to the git repo any more (I think I transferred that many years ago), so if it's workable I suspect the best way forward is removing (or updating) the really old cargotest

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[rust-bors]

⚠️ A new commit 15b13982bfa68131fdc5e46ba5f947e478b98eda was pushed.

This PR was contained in a rollup (#157028), which was closed.

[petrochenkov]

I've added one more crate-specific exception for net2 to avoid blocking this PR on cargotest or fixing net2 itself.
@bors r=mu001999

[rust-bors]

📌 Commit 15b1398 has been approved by mu001999

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1. This pull request will be tested once the tree is reopened.

[petrochenkov]

The fix to net2 is submitted in deprecrated/net2-rs#117.

[JonathanBrouwer]

This PR broke one of the runtime benchmarks in rust-timer:
#157121 (comment)

Cannot compile runtime benchmark css

Caused by:
    0: Failed to compile runtime benchmark `css`
    1: Failed to run cargo, exit code 101
       /home/collector/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/lightningcss-1.0.0-alpha.44/src/properties/mod.rs:1601:13: error[E0659]: `Token` is ambiguous: ambiguous name

[JonathanBrouwer]

Should be fixed by rust-lang/rustc-perf#2482