Retry download not working

[gabrielefronze]

Apparently there's an error within the code wrapping rucio download, which was previously commented to avoid issues.
If a download fails it should be retried by the pipeline:

fuse-posix/include/download-pipeline.h

Lines 50 to 52 in 2fbe45e

	if(output->freturn_code != MAX_ATTEMPTS){
	fastlog(INFO,"Trying again did %s download in %s.", output->fdid.data(), output->full_cache_path().data());
	// fInputQ->append(*output);

The idea is nice, but the issue is with the if condition. In fact testing:

output->freturn_code != MAX_ATTEMPTS

should be:

output->freturn_code != TOO_MANY_ATTEMPTS

or:

output->fattempt > MAX_ATTEMPTS

based on the definition here:

fuse-posix/include/rucio-download.h

Lines 123 to 140 in 2fbe45e

	rucio_download_info* rucio_download_wrapper(rucio_download_info& info){
	if(not server_exists(info.fserver_name)) {
	fastlog(ERROR, "Server %s not found. Aborting!", info.fserver_name.data());
	info.freturn_code = SERVER_NOT_FOUND;
	return &info;
	} else {
	if (info.fattempt <= MAX_ATTEMPTS and info.freturn_code != SETTINGS_NOT_FOUND) {
	info.fattempt++;
	info.freturn_code = rucio_download_wrapper(info.fserver_name, info.fserver_config, info.scopename(),
	info.filename());
	info.fdownloaded = (info.freturn_code != FILE_NOT_FOUND and info.freturn_code != SETTINGS_NOT_FOUND);
	} else {
	info.freturn_code = TOO_MANY_ATTEMPTS;
	info.fdownloaded = false;
	}
	}
	return &info;
	}