Fix tests for created_at in compact index output

The compact index info endpoint now includes created_at timestamps,
so the expected output in tests needs to account for this by
dynamically including each version's created_at value.

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

Author: hsbt

test/integration/api/compact_index_test.rb

@@ -14,45 +14,50 @@ def digest(body)
 
   setup do
     @rubygem2 = create(:rubygem, name: "gemB")
-    @version = create(:version, rubygem: @rubygem2, number: "1.0.0", info_checksum: "qw2dwe")
+    @version = create(:version, rubygem: @rubygem2, number: "1.0.0", info_checksum: "qw2dwe",
+      created_at: 5.days.ago)
 
     # another gem
     rubygem = create(:rubygem, name: "gemA")
     dep1 = create(:rubygem, name: "gemA1", indexed: true)
     dep2 = create(:rubygem, name: "gemA2", indexed: true)
 
     # minimal version
-    create(:version,
+    @gem_a_v100 = create(:version,
       rubygem: rubygem,
       number: "1.0.0",
       info_checksum: "013we2",
-      required_ruby_version: nil)
+      required_ruby_version: nil,
+      created_at: 4.days.ago)
 
     # version with deps but no ruby or rubygems requirements
-    version = create(:version,
+    @gem_a_v200 = create(:version,
       rubygem: rubygem,
       number: "2.0.0",
       info_checksum: "1cf94r",
-      required_ruby_version: nil)
-    create(:dependency, rubygem: dep1, version: version)
+      required_ruby_version: nil,
+      created_at: 3.days.ago)
+    create(:dependency, rubygem: dep1, version: @gem_a_v200)
 
     # version with required ruby and rubygems version
-    create(:version,
+    @gem_a_v120 = create(:version,
       rubygem: rubygem,
       number: "1.2.0",
       info_checksum: "13q4es",
       required_rubygems_version: ">1.9",
-      required_ruby_version: ">= 2.0.0")
+      required_ruby_version: ">= 2.0.0",
+      created_at: 2.days.ago)
 
     # version with everything
-    version = create(:version,
+    @gem_a_v210 = create(:version,
       rubygem: rubygem,
       number: "2.1.0",
       info_checksum: "e217fz",
-      required_rubygems_version: ">=2.0")
+      required_rubygems_version: ">=2.0",
+      created_at: 1.day.ago)
 
-    create(:dependency, rubygem: dep1, version: version)
-    create(:dependency, rubygem: dep2, version: version)
+    create(:dependency, rubygem: dep1, version: @gem_a_v210)
+    create(:dependency, rubygem: dep2, version: @gem_a_v210)
   end
 
   test "/names output" do
@@ -149,10 +154,10 @@ def digest(body)
   test "/info with existing gem" do
     expected = <<~VERSIONS_FILE
       ---
-      1.0.0 |checksum:b5d4045c3f466fa91fe2cc6abe79232a1a57cdf104f7a26e716e0a1e2789df78,rubygems:>= 2.6.3
-      2.0.0 gemA1:= 1.0.0|checksum:b5d4045c3f466fa91fe2cc6abe79232a1a57cdf104f7a26e716e0a1e2789df78,rubygems:>= 2.6.3
-      1.2.0 |checksum:b5d4045c3f466fa91fe2cc6abe79232a1a57cdf104f7a26e716e0a1e2789df78,ruby:>= 2.0.0,rubygems:>1.9
-      2.1.0 gemA1:= 1.0.0,gemA2:= 1.0.0|checksum:b5d4045c3f466fa91fe2cc6abe79232a1a57cdf104f7a26e716e0a1e2789df78,ruby:>= 2.0.0,rubygems:>=2.0
+      1.0.0 |checksum:b5d4045c3f466fa91fe2cc6abe79232a1a57cdf104f7a26e716e0a1e2789df78,rubygems:>= 2.6.3,created_at:#{@gem_a_v100.created_at.utc.iso8601}
+      2.0.0 gemA1:= 1.0.0|checksum:b5d4045c3f466fa91fe2cc6abe79232a1a57cdf104f7a26e716e0a1e2789df78,rubygems:>= 2.6.3,created_at:#{@gem_a_v200.created_at.utc.iso8601}
+      1.2.0 |checksum:b5d4045c3f466fa91fe2cc6abe79232a1a57cdf104f7a26e716e0a1e2789df78,ruby:>= 2.0.0,rubygems:>1.9,created_at:#{@gem_a_v120.created_at.utc.iso8601}
+      2.1.0 gemA1:= 1.0.0,gemA2:= 1.0.0|checksum:b5d4045c3f466fa91fe2cc6abe79232a1a57cdf104f7a26e716e0a1e2789df78,ruby:>= 2.0.0,rubygems:>=2.0,created_at:#{@gem_a_v210.created_at.utc.iso8601}
     VERSIONS_FILE
     expected_digest = digest(expected)
 
@@ -174,10 +179,10 @@ def digest(body)
   test "/info partial response" do
     expected = <<~VERSIONS_FILE
       ---
-      1.0.0 |checksum:b5d4045c3f466fa91fe2cc6abe79232a1a57cdf104f7a26e716e0a1e2789df78,rubygems:>= 2.6.3
-      2.0.0 gemA1:= 1.0.0|checksum:b5d4045c3f466fa91fe2cc6abe79232a1a57cdf104f7a26e716e0a1e2789df78,rubygems:>= 2.6.3
-      1.2.0 |checksum:b5d4045c3f466fa91fe2cc6abe79232a1a57cdf104f7a26e716e0a1e2789df78,ruby:>= 2.0.0,rubygems:>1.9
-      2.1.0 gemA1:= 1.0.0,gemA2:= 1.0.0|checksum:b5d4045c3f466fa91fe2cc6abe79232a1a57cdf104f7a26e716e0a1e2789df78,ruby:>= 2.0.0,rubygems:>=2.0
+      1.0.0 |checksum:b5d4045c3f466fa91fe2cc6abe79232a1a57cdf104f7a26e716e0a1e2789df78,rubygems:>= 2.6.3,created_at:#{@gem_a_v100.created_at.utc.iso8601}
+      2.0.0 gemA1:= 1.0.0|checksum:b5d4045c3f466fa91fe2cc6abe79232a1a57cdf104f7a26e716e0a1e2789df78,rubygems:>= 2.6.3,created_at:#{@gem_a_v200.created_at.utc.iso8601}
+      1.2.0 |checksum:b5d4045c3f466fa91fe2cc6abe79232a1a57cdf104f7a26e716e0a1e2789df78,ruby:>= 2.0.0,rubygems:>1.9,created_at:#{@gem_a_v120.created_at.utc.iso8601}
+      2.1.0 gemA1:= 1.0.0,gemA2:= 1.0.0|checksum:b5d4045c3f466fa91fe2cc6abe79232a1a57cdf104f7a26e716e0a1e2789df78,ruby:>= 2.0.0,rubygems:>=2.0,created_at:#{@gem_a_v210.created_at.utc.iso8601}
     VERSIONS_FILE
 
     get info_path(gem_name: "gemA"), env: { range: "bytes=159-" }
@@ -188,11 +193,12 @@ def digest(body)
 
   test "/info with new gem" do
     rubygem = create(:rubygem, name: "gemC")
-    version = create(:version, rubygem: rubygem, number: "1.0.0", info_checksum: "65ea0d")
+    version = create(:version, rubygem: rubygem, number: "1.0.0", info_checksum: "65ea0d",
+      created_at: Time.utc(2024, 2, 1))
     create(:dependency, :development, version: version, rubygem: @rubygem2)
     expected = <<~VERSIONS_FILE
       ---
-      1.0.0 |checksum:b5d4045c3f466fa91fe2cc6abe79232a1a57cdf104f7a26e716e0a1e2789df78,ruby:>= 2.0.0,rubygems:>= 2.6.3
+      1.0.0 |checksum:b5d4045c3f466fa91fe2cc6abe79232a1a57cdf104f7a26e716e0a1e2789df78,ruby:>= 2.0.0,rubygems:>= 2.6.3,created_at:2024-02-01T00:00:00Z
     VERSIONS_FILE
     expected_digest = digest(expected)
 
@@ -234,7 +240,7 @@ def digest(body)
 
     expected = <<~VERSIONS_FILE
       ---
-      1.0.0 aaab:>= 0,aaab:~> 0.2,bbcc:= 1.0.0|checksum:b5d4045c3f466fa91fe2cc6abe79232a1a57cdf104f7a26e716e0a1e2789df78,ruby:>= 2.0.0,rubygems:>= 2.6.3
+      1.0.0 aaab:>= 0,aaab:~> 0.2,bbcc:= 1.0.0|checksum:b5d4045c3f466fa91fe2cc6abe79232a1a57cdf104f7a26e716e0a1e2789df78,ruby:>= 2.0.0,rubygems:>= 2.6.3,created_at:#{@version.created_at.utc.iso8601}
     VERSIONS_FILE
     expected_digest = digest(expected)
 

test/integration/push_test.rb

@@ -49,16 +49,20 @@ class PushTest < ActionDispatch::IntegrationTest
 
     assert_response :success, response.body
 
+    sigstore = Rubygem.find_by!(name: "sigstore")
+    v001 = sigstore.versions.find_by(number: "0.0.1")
+    v100 = sigstore.versions.find_by(number: "1.0.0")
+
     get info_path("sigstore")
     info_file = response.body
 
     assert_response :success
     assert_equal <<~INFO, info_file
       ---
-      0.0.1 |checksum:b5d4045c3f466fa91fe2cc6abe79232a1a57cdf104f7a26e716e0a1e2789df78,ruby:>= 2.0.0,rubygems:>= 2.6.3
-      1.0.0 |checksum:#{Digest::SHA256.hexdigest File.binread(gem_file('sigstore-1.0.0.gem'))}
+      0.0.1 |checksum:b5d4045c3f466fa91fe2cc6abe79232a1a57cdf104f7a26e716e0a1e2789df78,ruby:>= 2.0.0,rubygems:>= 2.6.3,created_at:#{v001.created_at.utc.iso8601}
+      1.0.0 |checksum:#{Digest::SHA256.hexdigest File.binread(gem_file('sigstore-1.0.0.gem'))},created_at:#{v100.created_at.utc.iso8601}
     INFO
-    assert_equal Digest::MD5.hexdigest(info_file), Rubygem.find_by!(name: "sigstore").versions.find_by(number: "1.0.0").info_checksum
+    assert_equal Digest::MD5.hexdigest(info_file), v100.info_checksum
 
     get api_v2_rubygem_version_path("sigstore", "1.0.0", format: "json")
 
@@ -92,10 +96,12 @@ class PushTest < ActionDispatch::IntegrationTest
 
     assert page.has_css?(css, count: 2)
 
-    assert_equal Digest::MD5.hexdigest(<<~INFO), Rubygem.find_by!(name: "sandworm").versions.sole.info_checksum
+    version = Rubygem.find_by!(name: "sandworm").versions.sole
+    expected_info = <<~INFO
       ---
-      1.0.0 |checksum:#{Digest::SHA256.hexdigest gem_io.string}
+      1.0.0 |checksum:#{Digest::SHA256.hexdigest gem_io.string},created_at:#{version.created_at.utc.iso8601}
     INFO
+    assert_equal Digest::MD5.hexdigest(expected_info), version.info_checksum
   end
 
   test "push a new version of a gem" do

test/jobs/upload_info_file_job_test.rb

@@ -14,7 +14,7 @@ class UploadInfoFileJobTest < ActiveJob::TestCase
 
     content = <<~INFO
       ---
-      0.0.1 |checksum:b5d4045c3f466fa91fe2cc6abe79232a1a57cdf104f7a26e716e0a1e2789df78,ruby:>= 2.0.0,rubygems:>= 2.6.3
+      0.0.1 |checksum:b5d4045c3f466fa91fe2cc6abe79232a1a57cdf104f7a26e716e0a1e2789df78,ruby:>= 2.0.0,rubygems:>= 2.6.3,created_at:#{version.created_at.utc.iso8601}
     INFO
 
     assert_equal content, RubygemFs.compact_index.get("info/#{version.rubygem.name}")

test/system/gem_server_lifecycle_test.rb

@@ -109,7 +109,8 @@ class GemServerLifecycleTest < ApplicationSystemTestCase
 
     assert_equal "200", info_a_after_first_push.code
     assert_equal "text/plain; charset=utf-8", info_a_after_first_push["content-type"]
-    expected_info = "---\n1.0.0 |checksum:#{gem_a100.sha256}\n"
+    a100_version = Version.find_by!(full_name: "a-1.0.0")
+    expected_info = "---\n1.0.0 |checksum:#{gem_a100.sha256},created_at:#{a100_version.created_at.utc.iso8601}\n"
 
     assert_equal expected_info, info_a_after_first_push.body
 
@@ -196,12 +197,21 @@ class GemServerLifecycleTest < ApplicationSystemTestCase
     info_a_after_second_push = do_get_info("a")
 
     assert_valid_compact_index_response info_a_after_second_push
-    assert_equal info_a_after_yank.body + "0.0.1 |checksum:#{gem_a001.sha256}\n", info_a_after_second_push.body
+    a001_version = Version.find_by!(full_name: "a-0.0.1")
+    expected_a_info = info_a_after_yank.body +
+      "0.0.1 |checksum:#{gem_a001.sha256},created_at:#{a001_version.created_at.utc.iso8601}\n"
+
+    assert_equal expected_a_info, info_a_after_second_push.body
 
     info_b = do_get_info("b")
 
     assert_valid_compact_index_response info_b
-    assert_equal "---\n1.0.0.pre a:< 1.0.0&>= 0.1.0|checksum:#{gem_b100pre.sha256},ruby:>= 2.0,rubygems:>= 2.0\n", info_b.body
+    b100pre_version = Version.find_by!(full_name: "b-1.0.0.pre")
+    expected_b_info = "---\n" \
+                      "1.0.0.pre a:< 1.0.0&>= 0.1.0|checksum:#{gem_b100pre.sha256}," \
+                      "ruby:>= 2.0,rubygems:>= 2.0,created_at:#{b100pre_version.created_at.utc.iso8601}\n"
+
+    assert_equal expected_b_info, info_b.body
 
     response = do_get_names
 
@@ -253,10 +263,13 @@ class GemServerLifecycleTest < ApplicationSystemTestCase
     info_a_after_third_push = do_get_info("a")
 
     assert_valid_compact_index_response info_a_after_third_push
+    a020_version = Version.find_by!(full_name: "a-0.2.0")
+    a020_mingw_version = Version.find_by!(full_name: "a-0.2.0-x86-mingw32")
+    a020_java_version = Version.find_by!(full_name: "a-0.2.0-java")
     expected_info_a = info_a_after_second_push.body +
-      "0.2.0 |checksum:#{gem_a020.sha256}\n" \
-      "0.2.0-x86-mingw32 |checksum:#{find_gem('a-0.2.0-x86-mingw32').sha256}\n" \
-      "0.2.0-java |checksum:#{find_gem('a-0.2.0-java').sha256}\n"
+      "0.2.0 |checksum:#{gem_a020.sha256},created_at:#{a020_version.created_at.utc.iso8601}\n" \
+      "0.2.0-x86-mingw32 |checksum:#{find_gem('a-0.2.0-x86-mingw32').sha256},created_at:#{a020_mingw_version.created_at.utc.iso8601}\n" \
+      "0.2.0-java |checksum:#{find_gem('a-0.2.0-java').sha256},created_at:#{a020_java_version.created_at.utc.iso8601}\n"
 
     assert_equal expected_info_a, info_a_after_third_push.body
 
@@ -312,7 +325,9 @@ class GemServerLifecycleTest < ApplicationSystemTestCase
     info_a_after_fourth_push = do_get_info("a")
 
     assert_valid_compact_index_response info_a_after_fourth_push
-    assert_match(/0\.3\.0 \|checksum:#{gem_a030.sha256}\n\z/, info_a_after_fourth_push.body)
+    a030_version = Version.find_by!(full_name: "a-0.3.0")
+
+    assert_match(/0\.3\.0 \|checksum:#{gem_a030.sha256},created_at:#{a030_version.created_at.utc.iso8601}\n\z/, info_a_after_fourth_push.body)
 
     specs_after_fourth_push = do_get_specs