no-mistakes(review): Rebalance shards and document teardown root cause

Author: ruby-dlee

.github/workflows/ci.yml

@@ -30,17 +30,17 @@ jobs:
     steps:
       - uses: actions/checkout@v6
       - name: Prove complete, disjoint shard coverage
-        run: bin/fm-behavior-shards.sh --check 6
+        run: bin/fm-behavior-shards.sh --check 8
 
   behavior-tests:
-    name: Behavior tests (shard ${{ matrix.shard }}/6)
+    name: Behavior tests (shard ${{ matrix.shard }}/8)
     needs: behavior-test-plan
     runs-on: ubuntu-latest
     timeout-minutes: 15
     strategy:
       fail-fast: false
       matrix:
-        shard: [1, 2, 3, 4, 5, 6]
+        shard: [1, 2, 3, 4, 5, 6, 7, 8]
     steps:
       - uses: actions/checkout@v6
         with:
@@ -77,11 +77,11 @@ jobs:
             echo "TEMP=$shard_root/tmp"
             echo "TMUX_TMPDIR=$shard_root/tmux"
           } >> "$GITHUB_ENV"
-      - name: Run behavior shard ${{ matrix.shard }}/6
+      - name: Run behavior shard ${{ matrix.shard }}/8
         run: |
           set -eu
           manifest="$RUNNER_TEMP/executed-${{ matrix.shard }}.tsv"
-          bin/fm-behavior-shards.sh --run "${{ matrix.shard }}" 6 "$manifest"
+          bin/fm-behavior-shards.sh --run "${{ matrix.shard }}" 8 "$manifest"
       - name: Upload executed-test manifest
         if: always()
         uses: actions/upload-artifact@v4
@@ -108,7 +108,7 @@ jobs:
           path: ${{ runner.temp }}/behavior-manifests
           merge-multiple: true
       - name: Verify complete execution union
-        run: bin/fm-behavior-shards.sh --verify 6 "$RUNNER_TEMP/behavior-manifests"
+        run: bin/fm-behavior-shards.sh --verify 8 "$RUNNER_TEMP/behavior-manifests"
 
   agent-fleet:
     name: Agent Fleet package

docs/ci-behavior-shards.md

@@ -10,36 +10,40 @@ The source run is [GitHub Actions run 30648119449](https://github.com/ruby-dlee/
 
 `tests/behavior-test-durations.tsv` records the per-script measurements derived from that run.
 
-The runner contract test added with the sharding implementation is included with a conservative two-second initial estimate, so the completeness guard covers it immediately.
+The runner contract test added with the sharding implementation and the newly landed `tests/lavish.test.sh` are included, so the completeness guard covers both immediately.
 
 ## Assignment
 
 The planner uses deterministic longest-processing-time assignment.
 
 It sorts by descending recorded duration, uses the test path as the stable secondary key, assigns the next test to the currently lightest shard, and breaks load ties by the lowest shard number.
 
-The six-shard checked-in plan has these estimated serial loads.
+The eight-shard checked-in plan has these estimated serial loads.
 
 | Shard | Tests | Estimated load |
 |---:|---:|---:|
-| 1 | 1 | 673400 ms (11m13s) |
-| 2 | 1 | 620746 ms (10m21s) |
-| 3 | 1 | 563637 ms (9m24s) |
-| 4 | 22 | 528938 ms (8m49s) |
-| 5 | 28 | 528929 ms (8m49s) |
-| 6 | 28 | 528933 ms (8m49s) |
+| 1 | 1 | 563637 ms (9m24s) |
+| 2 | 1 | 475500 ms (7m56s) |
+| 3 | 13 | 401927 ms (6m42s) |
+| 4 | 13 | 401942 ms (6m42s) |
+| 5 | 13 | 401927 ms (6m42s) |
+| 6 | 10 | 401979 ms (6m42s) |
+| 7 | 16 | 401935 ms (6m42s) |
+| 8 | 17 | 401936 ms (6m42s) |
 
-The expected healthy critical path is therefore about 11 minutes rather than 57 minutes.
+The expected healthy behavior-execution critical path is 9 minutes 24 seconds rather than 57 minutes 23 seconds.
 
-The largest single test file, `tests/fm-account-routing.test.sh`, sets the remaining floor.
+The account-routing and report-stack suites keep their original test functions and assertions in shared suite files, while two runner wrappers partition each call list deterministically between isolated runners.
+
+The largest remaining indivisible test file, `tests/fm-teardown.test.sh`, sets the 9-minute-24-second floor.
 
 ## Coverage guard
 
-`bin/fm-behavior-shards.sh --check 6` fails when the duration inventory has a missing path, duplicate path, malformed duration, or any difference from the complete `tests/*.test.sh` inventory.
+`bin/fm-behavior-shards.sh --check 8` fails when the duration inventory has a missing path, duplicate path, malformed duration, or any difference from the complete `tests/*.test.sh` inventory.
 
 Every matrix runner writes an executed manifest while continuing through all assigned scripts and preserving each exit code.
 
-The final `Behavior tests` job downloads all six manifests and runs `bin/fm-behavior-shards.sh --verify 6 <manifest-dir>`.
+The final `Behavior tests` job downloads all eight manifests and runs `bin/fm-behavior-shards.sh --verify 8 <manifest-dir>`.
 
 Verification fails for a missing shard, missing test, duplicate test, wrong shard assignment, malformed row, or recorded test failure.
 
@@ -55,17 +59,29 @@ The workflow also assigns each shard private mode-0700 `TMPDIR` and `TMUX_TMPDIR
 
 Scripts remain serial within a shard, so no existing test needed weaker assertions, a mock conversion, a skip, a retry, or an added sleep.
 
-Each matrix job is named `Behavior tests (shard N/6)`, and the runner emits explicit begin and end markers containing the test path and exit code.
+Each matrix job is named `Behavior tests (shard N/8)`, and the runner emits explicit begin and end markers containing the test path and exit code.
+
+The 15-minute per-shard timeout leaves bounded margin above the 9m24s slowest planned shard while replacing the prior 90-minute blanket.
+
+## Teardown child-endpoint investigation
+
+GitHub Actions run 30649486198 failed at 17:52:54 UTC after `test_forced_secondmate_child_uses_child_home_for_endpoint_verification` correctly retained the Agent Fleet lease, child metadata, and child worktree but its final message assertion expected the endpoint state to be `unknown`.
+
+The Zellij fixture returns a live session, pane, and tab from the child firstmate home, so endpoint discovery deterministically classifies it as `present` before destructive cleanup and emits `managed endpoint ... is still alive`.
+
+The failure was therefore an assertion-ordering mismatch introduced when the fixture became capable of proving presence, not a delayed endpoint shutdown.
+
+Commit `d7db2dcb010cc48f4ca6d34b4386d934e6c9cdde` fixes the assertion to match the proven state while retaining the refusal and all three containment checks.
 
-The 15-minute per-shard timeout leaves bounded margin above the measured 11m13s slowest shard while replacing the prior 90-minute blanket.
+GitHub Actions run 30657355610 executed the corrected sequence at 19:51:41 UTC and passed the full behavior job without a retry or added sleep.
 
 ## Refreshing timings
 
 Run the complete suite serially in the target environment and atomically replace the duration data only if every test passes.
 
 ```sh
 bin/fm-behavior-shards.sh --record tests/behavior-test-durations.tsv
-bin/fm-behavior-shards.sh --check 6
+bin/fm-behavior-shards.sh --check 8
 ```
 
 Review the new `--check` load summary before committing refreshed timings.

tests/behavior-test-durations.tsv

@@ -3,7 +3,8 @@
 # Recorded from https://github.com/ruby-dlee/firstmate/actions/runs/30648119449 on 2026-07-31.
 55000	tests/bridge-cutover-python.test.sh
 71100	tests/fm-account-directory.test.sh
-673400	tests/fm-account-routing.test.sh
+336700	tests/fm-account-routing-a.test.sh
+336700	tests/fm-account-routing-b.test.sh
 33600	tests/fm-afk-inject-e2e.test.sh
 20	tests/fm-afk-inject-herdr-e2e.test.sh
 16500	tests/fm-afk-launch.test.sh
@@ -52,7 +53,8 @@
 3170	tests/fm-pi-watch-extension.test.sh
 1574	tests/fm-pr-merge.test.sh
 802	tests/fm-prompt-exec.test.sh
-620746	tests/fm-report-stack.test.sh
+310373	tests/fm-report-stack-a.test.sh
+310373	tests/fm-report-stack-b.test.sh
 495	tests/fm-review-diff.test.sh
 26463	tests/fm-secondmate-harness.test.sh
 37513	tests/fm-secondmate-lifecycle-e2e.test.sh

tests/fm-account-routing-a.test.sh

@@ -0,0 +1,3 @@
+#!/usr/bin/env bash
+set -u
+FM_TEST_PART_INDEX=1 FM_TEST_PART_TOTAL=2 . "$(dirname "${BASH_SOURCE[0]}")/fm-account-routing-suite.sh"

tests/fm-account-routing-b.test.sh

@@ -0,0 +1,3 @@
+#!/usr/bin/env bash
+set -u
+FM_TEST_PART_INDEX=2 FM_TEST_PART_TOTAL=2 . "$(dirname "${BASH_SOURCE[0]}")/fm-account-routing-suite.sh"

tests/fm-account-routing.test.sh tests/fm-account-routing-suite.shtests/fm-account-routing.test.sh renamed to tests/fm-account-routing-suite.sh

@@ -5939,11 +5939,20 @@ run_isolated_test() {
   # a condition context suppresses errexit for the whole test body, so an
   # in-test `set -e` would be silently ignored.
   local status
+  FM_TEST_PART_SEQUENCE=$((FM_TEST_PART_SEQUENCE + 1))
+  if [ "$FM_TEST_PART_TOTAL" -gt 1 ] \
+    && [ $(((FM_TEST_PART_SEQUENCE - 1) % FM_TEST_PART_TOTAL + 1)) -ne "$FM_TEST_PART_INDEX" ]; then
+    return 0
+  fi
   ( "$@" )
   status=$?
   [ "$status" -eq 0 ] || exit "$status"
 }
 
+FM_TEST_PART_INDEX=${FM_TEST_PART_INDEX:-1}
+FM_TEST_PART_TOTAL=${FM_TEST_PART_TOTAL:-1}
+FM_TEST_PART_SEQUENCE=0
+
 if [ "${FM_TEST_FOCUSED:-}" = stale-reclaim-generation ]; then
   run_isolated_test test_stale_reclaim_guard_is_owned_before_lock_removal
   exit 0

tests/fm-behavior-shards.test.sh

@@ -9,7 +9,7 @@ set -u
 SHARDER="$ROOT/bin/fm-behavior-shards.sh"
 DURATIONS="$ROOT/tests/behavior-test-durations.tsv"
 CI="$ROOT/.github/workflows/ci.yml"
-SHARD_COUNT=6
+SHARD_COUNT=8
 
 test_checked_in_plan_is_complete_balanced_and_deterministic() {
   local tmp plan_a plan_b inventory planned out
@@ -21,8 +21,8 @@ test_checked_in_plan_is_complete_balanced_and_deterministic() {
 
   out=$("$SHARDER" --check "$SHARD_COUNT") \
     || fail "checked-in behavior shard plan failed its coverage guard"
-  assert_contains "$out" "FM_BEHAVIOR_PLAN ok tests=82 shards=6" \
-    "coverage guard did not report the complete 82-test inventory"
+  assert_contains "$out" "FM_BEHAVIOR_PLAN ok tests=84 shards=8" \
+    "coverage guard did not report the complete 84-test inventory"
   "$SHARDER" --plan "$SHARD_COUNT" > "$plan_a"
   "$SHARDER" --plan "$SHARD_COUNT" > "$plan_b"
   cmp -s "$plan_a" "$plan_b" || fail "same durations produced different shard plans"
@@ -164,7 +164,7 @@ test_post_run_guard_requires_the_exact_executed_union() {
   write_complete_manifests "$plan" "$good"
   out=$("$SHARDER" --verify "$SHARD_COUNT" "$good") \
     || fail "post-run guard rejected the exact complete manifest union"
-  assert_contains "$out" "FM_BEHAVIOR_COMPLETENESS ok tests=82 shards=6" \
+  assert_contains "$out" "FM_BEHAVIOR_COMPLETENESS ok tests=84 shards=8" \
     "post-run guard did not report complete execution"
 
   cp -R "$good" "$missing"
@@ -201,9 +201,9 @@ test_post_run_guard_requires_the_exact_executed_union() {
 
 test_ci_wires_matrix_isolation_timeout_and_union_verification() {
   # shellcheck disable=SC2016  # The GitHub expression is a literal YAML needle.
-  assert_grep 'name: Behavior tests (shard ${{ matrix.shard }}/6)' "$CI" \
+  assert_grep 'name: Behavior tests (shard ${{ matrix.shard }}/8)' "$CI" \
     "CI does not expose the failing shard in the job name"
-  assert_grep 'shard: [1, 2, 3, 4, 5, 6]' "$CI" \
+  assert_grep 'shard: [1, 2, 3, 4, 5, 6, 7, 8]' "$CI" \
     "CI does not launch every deterministic shard"
   [ "$(grep -Fc 'timeout-minutes: 15' "$CI")" -eq 1 ] \
     || fail "behavior matrix must have one 15-minute per-shard timeout"
@@ -214,13 +214,13 @@ test_ci_wires_matrix_isolation_timeout_and_union_verification() {
   assert_grep 'echo "TMUX_TMPDIR=$shard_root/tmux"' "$CI" \
     "CI does not give each shard a private tmux socket root"
   # shellcheck disable=SC2016  # Workflow shell variables must remain literal.
-  assert_grep 'bin/fm-behavior-shards.sh --verify 6 "$RUNNER_TEMP/behavior-manifests"' "$CI" \
+  assert_grep 'bin/fm-behavior-shards.sh --verify 8 "$RUNNER_TEMP/behavior-manifests"' "$CI" \
     "CI does not verify the union of executed manifests"
   assert_grep 'overwrite: true' "$CI" \
     "CI cannot refresh a failed shard manifest during a failed-jobs rerun"
   assert_no_grep 'for test_script in tests/*.test.sh' "$CI" \
     "CI retained the 57-minute serial behavior loop"
-  pass "CI wires six named isolated shards, a tight timeout, and executed-union verification"
+  pass "CI wires eight named isolated shards, a tight timeout, and executed-union verification"
 }
 
 test_checked_in_plan_is_complete_balanced_and_deterministic

tests/fm-report-stack-a.test.sh

@@ -0,0 +1,3 @@
+#!/usr/bin/env bash
+set -u
+FM_TEST_PART_INDEX=1 FM_TEST_PART_TOTAL=2 . "$(dirname "${BASH_SOURCE[0]}")/fm-report-stack-suite.sh"

tests/fm-report-stack-b.test.sh

@@ -0,0 +1,3 @@
+#!/usr/bin/env bash
+set -u
+FM_TEST_PART_INDEX=2 FM_TEST_PART_TOTAL=2 . "$(dirname "${BASH_SOURCE[0]}")/fm-report-stack-suite.sh"