no-mistakes(review): Reject incomplete Lavish decision forms and answers

Author: ruby-dlee

.agents/skills/lavish-decision-boards/SKILL.md

@@ -55,6 +55,6 @@ A read-only status page is not a decision surface.
 - Never rely on poll output or conversation memory as the only copy because ephemeral poll output can be reaped.
 - Treat a `lavish-axi poll` return as transport or lifecycle output, not automatically as the captain's answer.
 - Act only after genuine connection and receipt of one unambiguous batch with `submission: "explicit-send-batch"`, a nonempty structured `answers` array, and a manifest containing `expectedQuestionKeys` and `expectedCount`.
-- Accept the batch only when the manifest keys are nonempty and unique, its count equals its key count, the answer keys are nonempty and unique, and the answer-key set exactly equals the manifest-key set.
-- Disconnects, UI flicker, re-polls, layout or audit returns, session events, and empty, partial, subset, missing-answer, unmarked, or ambiguous payloads are not submissions; ignore them and keep waiting.
+- Accept the batch only when the manifest keys are nonempty and unique, its count equals its key count, and every manifest key has exactly one structured answer entry with the same key and a nonempty `answer` value.
+- Reject absent, empty, extra, or duplicate answer keys, every manifest mismatch, and every disconnect, UI flicker, re-poll, layout or audit return, session event, unmarked return, or ambiguous return; ignore them and keep waiting.
 - If a return is ambiguous or lacks a clear explicit-decision payload, treat it as not submitted and do not act until the captain's actual answer is verified in the payload.

.agents/skills/lavish-decision-boards/assets/lavish-board-template.html

@@ -75,6 +75,7 @@
   form.q label:has(input:checked){border-color:var(--accent);background:var(--accent-soft)}
   form.q input[type=radio]{margin-top:2px;accent-color:var(--accent);width:16px;height:16px;flex:none}
   .selection-status{font-size:13px;color:var(--ink-2);margin:0 0 10px;min-height:20px}
+  .submission-status{font-size:13px;color:var(--red);margin:10px 0 0;min-height:20px}
   button{font-family:inherit;font-size:13.5px;font-weight:650;border-radius:9px;cursor:pointer;border:1px solid var(--accent);background:var(--accent);color:#fff;padding:8px 15px}
 </style>
 </head>
@@ -98,11 +99,17 @@ <h3>What should be decided?</h3>
   </div>
 
   <button type="button" data-send-answers onclick="sendAnswers()">Send answers</button>
+  <p class="submission-status" data-submission-status role="alert" aria-live="assertive"></p>
 </div>
 <script>
-  document.querySelectorAll('form[data-lavish-question]').forEach(function(form){
+  document.querySelectorAll('form.q').forEach(function(form){
     form.addEventListener('change',function(){
-      var key=form.dataset.lavishQuestion;
+      var key=(form.dataset.lavishQuestion||'').trim();
+      if(!key){
+        form.querySelector('[data-selection-status]').textContent=
+          'Configuration error: add a unique data-lavish-question value to this decision form.';
+        return;
+      }
       var choice=new FormData(form).get(key);
       form.querySelector('[data-selection-status]').textContent=
         choice?'Selected locally (not sent): '+choice:'No answer selected.';
@@ -112,25 +119,43 @@ <h3>What should be decided?</h3>
   var submissionInFlight=false;
 
   function sendAnswers(){
-    var forms=Array.from(document.querySelectorAll('form[data-lavish-question]'));
+    var forms=Array.from(document.querySelectorAll('form.q'));
     var answers=[];
     var firstIncomplete=null;
     var sendButton=document.querySelector('[data-send-answers]');
+    var submissionStatus=document.querySelector('[data-submission-status]');
     if(submissionInFlight)return;
-    forms.forEach(function(form){
-      var key=form.dataset.lavishQuestion;
+    function failConfiguration(message){
+      sendButton.disabled=true;
+      sendButton.textContent='Cannot send answers';
+      submissionStatus.textContent=message;
+    }
+    if(!forms.length){
+      failConfiguration('Configuration error: add at least one decision form before serving this board.');
+      return;
+    }
+    var keyedForms=forms.map(function(form,index){
+      return {form:form,key:(form.dataset.lavishQuestion||'').trim(),index:index};
+    });
+    var missingKey=keyedForms.find(function(item){return !item.key;});
+    if(missingKey){
+      failConfiguration('Configuration error: decision form '+(missingKey.index+1)+' needs a unique nonempty data-lavish-question value.');
+      return;
+    }
+    var expectedQuestionKeys=keyedForms.map(function(item){return item.key;});
+    var uniqueQuestionKeys=new Set(expectedQuestionKeys);
+    if(uniqueQuestionKeys.size!==expectedQuestionKeys.length){
+      failConfiguration('Configuration error: every decision form needs a unique data-lavish-question value.');
+      return;
+    }
+    keyedForms.forEach(function(item){
+      var form=item.form;
+      var key=item.key;
       var choice=new FormData(form).get(key);
       if(!choice){firstIncomplete=firstIncomplete||form;return;}
       answers.push({key:key,label:form.dataset.lavishLabel||key,answer:choice});
     });
     if(firstIncomplete){firstIncomplete.reportValidity();return;}
-    var expectedQuestionKeys=answers.map(function(answer){return answer.key;});
-    var uniqueQuestionKeys=new Set(expectedQuestionKeys);
-    if(!answers.length||expectedQuestionKeys.some(function(key){return !key;})||uniqueQuestionKeys.size!==expectedQuestionKeys.length){
-      sendButton.disabled=true;
-      sendButton.textContent='Board configuration error';
-      return;
-    }
     if(!window.lavish||!window.lavish.queuePrompt||!window.lavish.sendQueuedPrompts)return;
     var batch={
       submission:'explicit-send-batch',