.contains() throws "empty octet" for IPv4-mapped IPv6 addresses

[zuavra]

If you call .contains() with an IPv4 range and an IPv4-mapped IPv6 address you get an error.

const netmask = new Netmask("0.0.0.0/8");
console.log(netmask.contains("::ffff:127.0.0.1"));

What should happen:

Function contains() should return false.

What happens:

Error: empty octet
    at parseNum (.../node_modules/netmask/dist/netmask4.js:57:15)
    at ip2long (.../node_modules/netmask/dist/netmask4.js:73:24)
    at Netmask4Impl.contains (.../node_modules/netmask/dist/netmask4.js:169:21)
    at Netmask.contains (.../node_modules/netmask/dist/netmask.js:53:27)

[zuavra]

And here's a throw for the reverse scenario, calling .contains() with an IPv4 address for an IPv6 range:

const netmask = new Netmask("fc00::/7");
console.log(netmask.contains("10.0.0.1"));

results in:

Error: Invalid IPv6: expected 8 groups, got 1
    at parseIPv6Pure (.../node_modules/netmask/dist/netmask6.js:44:15)
    at ip6bigint (.../node_modules/netmask/dist/netmask6.js:24:12)
    at Netmask6Impl.contains (.../node_modules/netmask/dist/netmask6.js:164:26)
    at Netmask.contains (.../node_modules/netmask/dist/netmask.js:53:27)

It seems that it's not safe to cross-compare addresses and ranges from different protocol versions.

As a workaround I'm going to use the ip-regex module to identify the type of the address and only compare it against ranges of the same version.