Merge pull request #78 from romejoe/pr-responses

fix: address remaining ObsidianReviewBot violations (PR #11614 rescan)

Author: romejoe

eslint.config.mts

@@ -8,6 +8,7 @@ export default tseslint.config(
 		languageOptions: {
 			globals: {
 				...globals.browser,
+				Buffer: 'readonly',
 			},
 			parserOptions: {
 				projectService: {

src/attachment-chip.ts

@@ -459,7 +459,6 @@ export function buildAttachmentChipElement(token: ParsedVcToken, plugin: VaultCr
 						new Notice('Failed to save: filesystem API unavailable');
 						return;
 					}
-					// eslint-disable-next-line no-undef -- Buffer is a Node.js global available in Electron
 					await fs.writeFile(result.filePath, Buffer.from(data));
 					new Notice(`Saved to ${result.filePath}`);
 				} catch (err) {

src/chip-component.ts

@@ -137,7 +137,7 @@ function buildSecretChipElement(token: ParsedVcToken, plugin: VaultCryptPlugin):
 
 		if (Platform.isDesktop) {
 			menu.addItem(item => item
-				.setTitle('Open in KeePassXC')
+				.setTitle('Open database file')
 				.setIcon('external-link')
 				.onClick(async () => {
 					const config = peek(profileConfig);
@@ -654,29 +654,6 @@ function copyField(
 	}
 
 	navigator.clipboard.writeText(value).then(onCopySuccess).catch(() => {
-		// Fallback for mobile WebViews where the Clipboard API may be unavailable
-		let textarea: HTMLTextAreaElement|null = null;
-		try {
-			textarea = document.createElement('textarea');
-			textarea.value = value;
-			// eslint-disable-next-line obsidianmd/no-static-styles-assignment
-			textarea.style.cssText = 'position:fixed;opacity:0;';
-			document.body.appendChild(textarea);
-			textarea.focus();
-			textarea.select();
-			// eslint-disable-next-line @typescript-eslint/no-deprecated
-			const ok = document.execCommand('copy');
-			document.body.removeChild(textarea);
-			if (ok) {
-				onCopySuccess();
-			} else {
-				new Notice('Failed to copy to clipboard');
-			}
-		} catch {
-			if(textarea !== null){
-				textarea.remove();
-			}
-			new Notice('Failed to copy to clipboard');
-		}
+		new Notice('Failed to copy to clipboard');
 	});
 }

src/main.ts

@@ -152,7 +152,7 @@ export default class VaultCryptPlugin extends Plugin {
 		});
 
 		// Ribbon icon → unlock modal (prefers keyring when available)
-		this.addRibbonIcon('lock', 'VaultCrypt', () => {
+		this.addRibbonIcon('lock', 'Manage secrets', () => {
 			if (this.shouldUseKeyringUnlock()) {
 				new KeyringUnlockModal(this.app, this, () => {
 					// Chain to per-profile unlock for non-managed locked profiles
@@ -312,7 +312,7 @@ export default class VaultCryptPlugin extends Plugin {
 		this.registerEvent(
 			this.app.workspace.on('editor-menu', (menu: Menu, editor: Editor) => {
 				menu.addItem(item => item
-					.setTitle('VaultCrypt: insert secret here')
+					.setTitle('Insert secret here')
 					.setIcon('key')
 					.onClick(() => new InsertSecretModal(this.app, this, editor).open()));
 			})
@@ -425,7 +425,7 @@ export default class VaultCryptPlugin extends Plugin {
 					return;
 				}
 				if (profiles.length === 0) {
-					this.statusBarItem.setText('🔒 VaultCrypt');
+					this.statusBarItem.setText('No profiles');
 					return;
 				}
 				const parts = profiles.map(p => (p.isLocked ? '🔒 ' : '🔓 ') + p.name);

src/modals/profile-modals.ts

@@ -216,7 +216,7 @@ export class EditProfileModal extends Modal {
 		this.titleEl.setText("Edit profile");
 
 		new Setting(contentEl).setName("Profile name").setDesc(this.profileName);
-		new Setting(contentEl).setName("KDBX version").setDesc(String(this.config.kdbxVersion));
+		new Setting(contentEl).setName('Database version').setDesc(String(this.config.kdbxVersion));
 		new Setting(contentEl).setName("Path").setDesc(this.config.path);
 
 		new Setting(contentEl)

src/modals/vault-dir-modals.ts

@@ -17,7 +17,7 @@ export class SyncWarningModal extends Modal {
 		const {contentEl} = this;
 		const currentDir = this.plugin.settings.general.vaultCryptDir;
 
-		this.titleEl.setText('VaultCrypt sync notice');
+		this.titleEl.setText('Sync notice');
 
 		contentEl.createEl('p', {
 			text: `Your VaultCrypt folder ("${currentDir}") starts with a dot. `
@@ -26,18 +26,18 @@ export class SyncWarningModal extends Modal {
 		});
 
 		contentEl.createEl('p', {
-			text: 'Would you like to move it to "VaultCrypt" (a visible folder that Obsidian Sync will include)?',
+			text: 'Would you like to move it to a visible folder so Obsidian Sync can include it?',
 		});
 
 		new Setting(contentEl)
 			.addButton(btn => btn
-				.setButtonText('Move to "VaultCrypt"')
+				.setButtonText('Move to visible folder')
 				.setCta()
 				.onClick(async () => {
 					this.close();
 					try {
 						await this.plugin.profileService.moveVaultDir('VaultCrypt');
-						new Notice('VaultCrypt: directory moved to "VaultCrypt".');
+						new Notice('Directory moved to visible location.');
 					} catch {
 						// moveVaultDir already shows a Notice on failure
 					}
@@ -87,7 +87,7 @@ export class MoveVaultDirModal extends Modal {
 		const {contentEl} = this;
 		const currentDir = this.plugin.settings.general.vaultCryptDir;
 
-		this.titleEl.setText('Change VaultCrypt directory');
+		this.titleEl.setText('Change storage directory');
 
 		new Setting(contentEl)
 			.setName('New directory path')
@@ -101,7 +101,7 @@ export class MoveVaultDirModal extends Modal {
 
 		new Setting(contentEl)
 			.setName('Move existing files')
-			.setDesc('Move .KDBX databases and other files from the current directory to the new location.')
+			.setDesc('Move database files and attachments from the current directory to the new location.')
 			.addToggle(toggle => toggle
 				.setValue(this.moveFiles)
 				.onChange(value => {

src/settings.ts

@@ -223,7 +223,7 @@ export class VaultCryptSettingTab extends PluginSettingTab {
 		new Setting(containerEl).setName("Vault").setHeading();
 
 		new Setting(containerEl)
-			.setName('VaultCrypt directory path')
+			.setName('Storage directory')
 			.setDesc(`Current: ${this.plugin.settings.general.vaultCryptDir} — Folder where .kdbx databases are stored.`)
 			.addButton(btn => btn
 				.setButtonText('Change directory')