GitHub nodejs issues #15 (#16)

* Fix error handling in performRebillUpdate() issues #15

* Change VERSION_NUMBER to K2.5

* Update expireYear to 2025

---------

Co-authored-by: Petrica Chiriac <petrica@localhost>

Author: petricarg

config/rgProperties.json

@@ -10,7 +10,7 @@
         "LIVE_HOST_16": "gateway-16.rocketgate.com",
         "LIVE_HOST_17": "gateway-17.rocketgate.com",
         "TEST_HOST": "dev-gateway.rocketgate.com",
-        "VERSION_NUMBER": "K2.4"
+        "VERSION_NUMBER": "K2.5"
     },
     "responseSettings": {
         "VERSION_INDICATOR": "version",

lib/gatewayService.js

@@ -642,13 +642,14 @@ function GatewayService(options) {
                 callback(results, request, response);
             });
         } else {
-            performTransaction(request, response, function(results) {
+            performTransaction(request, response, function(results, request, response) {
                 if (results) {
                     performConfirmation(request, response, function(results, request, response) {
                         callback(results, request, response);
                     });
+                } else {
+                    callback(results, request, response);
                 }
-                callback(results, request, response);
             });
         }
     }

test/unit/buildPaymentLink.js

@@ -16,7 +16,7 @@ describe('perform auth only', function() {
         request.amount = "9.99";
         request.cardNo = "4111-1111-1111-1111";
         request.expireMonth = "02";
-        request.expireYear = "2025";
+        request.expireYear = "2029";
         request.cvv2 = "999";
         request.customerFirstName = "Joe";
         request.customerLastName = "JSTester";

test/unit/performRebillUpdate.js

@@ -33,7 +33,7 @@ describe('perform rebill update', function() {
         request.amount = "5.55";
         request.cardNo = "4111-1111-1111-1111";
         request.expireMonth = "02";
-        request.expireYear = "2020";
+        request.expireYear = "2029";
         request.cvv2 = "999";
 
         service.setTestMode(true, function(err, result) {
@@ -98,6 +98,24 @@ describe('perform rebill update', function() {
             request.username = "node_added_username";
             request.customerPassword = "node_added_password";
 
+            service.performRebillUpdate(request, {}, function(results, request, response) {
+                results.should.equal(true);
+                response[responseSettings.RESPONSE_CODE].should.equal('0');
+                done();
+            });
+        });
+    });
+    it ('should perform rebill update with amount', function (done) {
+        service.performPurchase(request, {}, function(results, request, response) {
+            // perform purchase then update
+            request = new Request();
+            request.merchantID = 1;
+            request.merchantPassword = "testpassword";
+            request.merchantCustomerID = time + ".JSTest";
+            request.merchantInvoiceID = time + ".Test";
+            request.amount = "4.55";
+            request.rebillFrequency = 'MONTHLY';
+
             service.performRebillUpdate(request, {}, function(results, request, response) {
                 results.should.equal(true);
                 response[responseSettings.RESPONSE_CODE].should.equal('0');