Skip to content

docs(drift): draft from internal source#373

Merged
ipeleg merged 1 commit into
mainfrom
docs-drift/src-7a19faed1e-8b7ebf5
Jul 22, 2026
Merged

docs(drift): draft from internal source#373
ipeleg merged 1 commit into
mainfrom
docs-drift/src-7a19faed1e-8b7ebf5

Conversation

@pedromcunha

Copy link
Copy Markdown
Member

Drafted from an internal source repo, requested by @ipeleg.

This PR was auto-generated by the reusable-docs-draft-pr workflow from a Claude-drafted update in the source repo. It is opened as a draft — please review, edit as needed, and mark ready for review before merging.

Review checklist

  • Content matches the behavior shipped in the source PR
  • No internal-only details (service names, file paths, unreleased names, security internals) leaked into the draft
  • Conforms to CLAUDE.md style rules
  • Cross-references and internal links resolve
  • Any Needs human input items from the source comment are addressed

Generated by reusable-docs-draft-pr.yml in relayprotocol/agents-config.

Requested by @ipeleg via /publish-docs-pr
@ipeleg
ipeleg marked this pull request as ready for review July 22, 2026 18:52
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

Claude finished @ipeleg's task in 1m 53s —— View job


Code review — PR #373 (docs drift: supersededByRequestId → root)

  • Read changed files and surrounding context
  • Check against CLAUDE.md style rules
  • Verify cross-references and factual accuracy
  • Post review

This is a clean, small drift update reflecting that supersededByRequestId moved from data.supersededByRequestId (v2) to the response root in GET /requests/v3. I verified the substantive claims against the rest of the docs and it holds up well.

✅ Verified correct

  • x-api-key on the v3 curl — The migration guide confirms GET /requests/v3 requires x-api-key (migrating-to-requests-v3.mdx:272, :484), so adding the header to the v3 example is right. Placeholder YOUR_API_KEY matches the §2.8 convention.
  • ?id=<ORIGINAL_REQUEST_ID> is valid v3 syntaxid is a documented v3 top-level search parameter (migrating-to-requests-v3.mdx:283), so this doesn't need filters=[…].
  • "Bitcoin/BVM" is not internal leakageBVM is already used publicly in quickstart.mdx:130 and references/relay-kit/sdk/adapters.mdx:12. Safe.
  • Response envelope + field shape — The JSON example correctly uses the requests[] envelope (matches the other example at deposit-addresses.mdx:984) and moves supersededByRequestId to the item root, matching the v3 change.
  • Style/consistency — The new bullet's "promoted to the root" phrasing mirrors the existing sender entry, and listing the field in both the "Moved, added & nulled fields" bullet and the "Renamed & restructured" table matches how sender / moonpayId / depositAddress are handled. Conforms to §4.5-adjacent bolded-lead patterns.

💡 One suggestion (non-blocking)

Mixed v2/v3 in the same section. The first curl in Handling Quote Regeneration still targets v2 without auth:

# deposit-addresses.mdx:1257
curl -X GET "https://api.relay.link/requests/v2?depositAddress=<DEPOSIT_ADDRESS>&includeChildRequests=true"

…while the second example just moved to v3-with-key. Both depositAddress and includeChildRequests are valid v3 parameters (migrating-to-requests-v3.mdx:285, :289), so for consistency you could promote this first call to v3 as well:

curl -X GET "https://api.relay.link/requests/v3?depositAddress=<DEPOSIT_ADDRESS>&includeChildRequests=true" -H "x-api-key: YOUR_API_KEY"

The prose deliberately references both versions ("…in GET /requests/v3 (or … the legacy GET /requests/v2)"), so keeping the contrast is defensible — but leading a reader through one v2 call and one v3 call back-to-back reads slightly inconsistently now that v3 is the recommended path.

Align the first regeneration curl to v3 →

Verdict

Accurate, on-style, no broken links, no internal details leaked. Approving in spirit — just the optional consistency tweak above before marking ready for review.

@ipeleg
ipeleg merged commit 57126a1 into main Jul 22, 2026
3 checks passed
@ipeleg
ipeleg deleted the docs-drift/src-7a19faed1e-8b7ebf5 branch July 22, 2026 18:56
@mintlify

mintlify Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
unevenlabs 🔴 Failed Jul 22, 2026, 7:06 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants