Pre-Commit update

luismiguensfernandez · luismiguensfernandez · commit 91acdb05d73c · 2025-12-11T16:47:48.000+01:00
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -9,7 +9,7 @@ repos:
         args: ["--filter=-legal/copyright"]
 
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.6.0
+    rev: v6.0.0
     hooks:
       - id: trailing-whitespace
       - id: check-added-large-files
@@ -29,9 +29,10 @@ repos:
       - id: mixed-line-ending
 
   - repo: https://github.com/psf/black
-    rev: 24.4.2
+    rev: 25.12.0
     hooks:
       - id: black
+        language_version: python3.13
 
   - repo: local
     hooks:
diff --git a/src/include/CanDeviceConfiguration.h b/src/include/CanDeviceConfiguration.h
@@ -97,7 +97,7 @@ struct CanDeviceConfiguration {
   std::string to_string() const noexcept;
 };
 
-std::ostream &operator<<(std::ostream &os,
-                         const CanDeviceConfiguration &config) noexcept;
+std::ostream& operator<<(std::ostream& os,
+                         const CanDeviceConfiguration& config) noexcept;
 
 #endif  // SRC_INCLUDE_CANDEVICECONFIGURATION_H_
diff --git a/src/include/CanVendorAnagate.h b/src/include/CanVendorAnagate.h
@@ -17,22 +17,22 @@
  * information.
  */
 struct CanVendorAnagate : CanDevice {
-  friend void anagate_receive(AnaInt32 nIdentifier, const char *pcBuffer,
+  friend void anagate_receive(AnaInt32 nIdentifier, const char* pcBuffer,
                               AnaInt32 nBufferLen, AnaInt32 nFlags,
                               AnaInt32 hHandle) noexcept;
 
-  explicit CanVendorAnagate(const CanDeviceArguments &configuration);
+  explicit CanVendorAnagate(const CanDeviceArguments& configuration);
   inline ~CanVendorAnagate() override { vendor_close(); }
 
  private:
   CanReturnCode vendor_open() noexcept override;
   CanReturnCode vendor_close() noexcept override;
-  CanReturnCode vendor_send(const CanFrame &frame) noexcept override;
+  CanReturnCode vendor_send(const CanFrame& frame) noexcept override;
   CanDiagnostics vendor_diagnostics() noexcept override;
 
   void print_anagate_error(AnaUInt32 r) noexcept;
   static std::mutex m_handles_lock;
-  static std::map<int, CanVendorAnagate *> m_handles;
+  static std::map<int, CanVendorAnagate*> m_handles;
 
   AnaInt32 m_handle{0};
 };
diff --git a/src/include/CanVendorLoopback.h b/src/include/CanVendorLoopback.h
@@ -20,7 +20,7 @@ struct CanVendorLoopback : CanDevice {
    * which contains configuration parameters for the CAN device.
    */
   inline explicit CanVendorLoopback(
-      const CanDeviceArguments &configuration) noexcept
+      const CanDeviceArguments& configuration) noexcept
       : CanDevice("loopback", configuration) {}
 
  private:
@@ -34,7 +34,7 @@ struct CanVendorLoopback : CanDevice {
   inline CanReturnCode vendor_close() noexcept override {
     return CanReturnCode::success;
   }
-  CanReturnCode vendor_send(const CanFrame &frame) noexcept override;
+  CanReturnCode vendor_send(const CanFrame& frame) noexcept override;
   inline CanDiagnostics vendor_diagnostics() noexcept override {
     return CanDiagnostics{};
   }
diff --git a/src/include/CanVendorSocketCan.h b/src/include/CanVendorSocketCan.h
@@ -22,19 +22,19 @@
  * methods to open, close, and send CAN frames using the SocketCAN interface.
  */
 struct CanVendorSocketCan : CanDevice {
-  explicit CanVendorSocketCan(const CanDeviceArguments &args);
+  explicit CanVendorSocketCan(const CanDeviceArguments& args);
 
   ~CanVendorSocketCan() { vendor_close(); }
 
  private:
   CanReturnCode vendor_open() noexcept override;
   CanReturnCode vendor_close() noexcept override;
-  CanReturnCode vendor_send(const CanFrame &frame) noexcept override;
+  CanReturnCode vendor_send(const CanFrame& frame) noexcept override;
   CanDiagnostics vendor_diagnostics() noexcept override;
 
   int subscriber() noexcept;
-  static const CanFrame translate(const struct can_frame &message) noexcept;
-  static struct can_frame translate(const CanFrame &frame) noexcept;
+  static const CanFrame translate(const struct can_frame& message) noexcept;
+  static struct can_frame translate(const CanFrame& frame) noexcept;
 
   int m_socket_fd{-1};              // File descriptor for the SocketCAN device
   int m_epoll_fd{-1};               // File descriptor for the epoll instance
diff --git a/src/include/CanVendorSocketCanSystec.h b/src/include/CanVendorSocketCanSystec.h
@@ -18,13 +18,13 @@
  * SocketCan due to a kernel-panic bug on Systec linux module.
  */
 struct CanVendorSocketCanSystec : CanDevice {
-  explicit CanVendorSocketCanSystec(const CanDeviceArguments &args);
+  explicit CanVendorSocketCanSystec(const CanDeviceArguments& args);
   ~CanVendorSocketCanSystec() { vendor_close(); }
 
  private:
   CanReturnCode vendor_open() noexcept override;
   CanReturnCode vendor_close() noexcept override;
-  CanReturnCode vendor_send(const CanFrame &frame) noexcept override;
+  CanReturnCode vendor_send(const CanFrame& frame) noexcept override;
   CanDiagnostics vendor_diagnostics() noexcept override;
 
   std::unique_ptr<CanDevice> m_can_vendor_socketcan;
diff --git a/src/main/CanDerivedStats.cpp b/src/main/CanDerivedStats.cpp
@@ -15,7 +15,7 @@
  *                    the current Rx and Tx values and will be updated with
  *                    the calculated rolling average rates.
  */
-void CanDerivedStats::update(CanDiagnostics &diagnostics) noexcept {
+void CanDerivedStats::update(CanDiagnostics& diagnostics) noexcept {
   if (!m_init) {
     if (!diagnostics.rx.has_value() || !diagnostics.tx.has_value()) {
       m_enabled = false;
@@ -48,9 +48,9 @@ void CanDerivedStats::update(CanDiagnostics &diagnostics) noexcept {
                        .count();
 
   if (time_diff > 0) {
-    const auto update_rate = [&](std::deque<float> &window,
-                                 std::optional<uint32_t> &value,
-                                 uint32_t &last_value, int64_t time_diff) {
+    const auto update_rate = [&](std::deque<float>& window,
+                                 std::optional<uint32_t>& value,
+                                 uint32_t& last_value, int64_t time_diff) {
       float rate = static_cast<float>(value.value() - last_value) / time_diff;
       window.push_front(rate);
       if (window.size() > window_size) {
@@ -64,8 +64,8 @@ void CanDerivedStats::update(CanDiagnostics &diagnostics) noexcept {
 
     m_last_update = current_time;
 
-    const auto update_per_second = [&](const std::deque<float> &window,
-                                       std::optional<float> &per_second) {
+    const auto update_per_second = [&](const std::deque<float>& window,
+                                       std::optional<float>& per_second) {
       if (!window.empty()) {
         per_second =
             std::accumulate(window.begin(), window.end(), 0.0) / window.size();
diff --git a/src/main/CanDevice.cpp b/src/main/CanDevice.cpp
@@ -72,7 +72,7 @@ CanReturnCode CanDevice::close() noexcept {
  * @param frame The CAN frame to be sent. It must be a valid frame.
  * @return int Returns 0 on success, or a non-zero error code on failure.
  */
-CanReturnCode CanDevice::send(const CanFrame &frame) noexcept {
+CanReturnCode CanDevice::send(const CanFrame& frame) noexcept {
   LOG(Log::DBG, CanLogIt::h()) << "Sending CAN frame: " << frame;
 
   CanReturnCode result = vendor_send(frame);
@@ -100,10 +100,10 @@ CanReturnCode CanDevice::send(const CanFrame &frame) noexcept {
  * success or a non-zero error code on failure for the corresponding frame.
  */
 std::vector<CanReturnCode> CanDevice::send(
-    const std::vector<CanFrame> &frames) noexcept {
+    const std::vector<CanFrame>& frames) noexcept {
   std::vector<CanReturnCode> result(frames.size());
   std::transform(frames.begin(), frames.end(), result.begin(),
-                 [this](const CanFrame &frame) { return send(frame); });
+                 [this](const CanFrame& frame) { return send(frame); });
   return result;
 }
 
@@ -144,7 +144,7 @@ CanDiagnostics CanDevice::diagnostics() noexcept {
  * provided.
  */
 std::unique_ptr<CanDevice> CanDevice::create(
-    std::string_view vendor, const CanDeviceArguments &configuration) {
+    std::string_view vendor, const CanDeviceArguments& configuration) {
   LOG(Log::INF, CanLogIt::h()) << "Creating CAN device for vendor: " << vendor;
   LOG(Log::INF, CanLogIt::h()) << "Configuration: " << configuration.config;
 
@@ -174,7 +174,7 @@ std::unique_ptr<CanDevice> CanDevice::create(
   return nullptr;
 }
 
-std::ostream &operator<<(std::ostream &os, CanReturnCode code) {
+std::ostream& operator<<(std::ostream& os, CanReturnCode code) {
   switch (code) {
     case CanReturnCode::success:
       return os << "SUCCESS";
diff --git a/src/main/CanDeviceConfiguration.cpp b/src/main/CanDeviceConfiguration.cpp
@@ -87,7 +87,7 @@ std::string CanDeviceConfiguration::to_string() const noexcept {
  * @return The output stream (os) with the CanDeviceConfiguration object's
  * string representation inserted.
  */
-std::ostream &operator<<(std::ostream &os,
-                         const CanDeviceConfiguration &config) noexcept {
+std::ostream& operator<<(std::ostream& os,
+                         const CanDeviceConfiguration& config) noexcept {
   return os << config.to_string();
 }
diff --git a/src/main/CanDiagnostics.cpp b/src/main/CanDiagnostics.cpp
@@ -87,7 +87,7 @@ std::string CanDiagnostics::to_string() const noexcept {
  * @return The output stream (os) after the diagnostic information has been
  * printed.
  */
-std::ostream &operator<<(std::ostream &os,
-                         const CanDiagnostics &diag) noexcept {
+std::ostream& operator<<(std::ostream& os,
+                         const CanDiagnostics& diag) noexcept {
   return os << diag.to_string();
 }
diff --git a/src/main/CanVendorAnagate.cpp b/src/main/CanVendorAnagate.cpp
@@ -13,7 +13,7 @@
 #include "CanLogIt.h"
 
 std::mutex CanVendorAnagate::m_handles_lock;
-std::map<int, CanVendorAnagate *> CanVendorAnagate::m_handles;
+std::map<int, CanVendorAnagate*> CanVendorAnagate::m_handles;
 
 /**
  * @brief Callback function to handle incoming CAN frames from the AnaGate DLL.
@@ -31,7 +31,7 @@ std::map<int, CanVendorAnagate *> CanVendorAnagate::m_handles;
  * @param hHandle The handle of the CAN device associated with the received CAN
  * frame.
  */
-void anagate_receive(AnaInt32 nIdentifier, const char *pcBuffer,
+void anagate_receive(AnaInt32 nIdentifier, const char* pcBuffer,
                      AnaInt32 nBufferLen, AnaInt32 nFlags,
                      AnaInt32 hHandle) noexcept {
   uint32_t flags{0};
@@ -60,7 +60,7 @@ void anagate_receive(AnaInt32 nIdentifier, const char *pcBuffer,
  * @param arguments A constant reference to the CanDeviceArguments object,
  * which contains configuration parameters for the CAN device.
  */
-CanVendorAnagate::CanVendorAnagate(const CanDeviceArguments &args)
+CanVendorAnagate::CanVendorAnagate(const CanDeviceArguments& args)
     : CanDevice("anagate", args) {
   if (!args.config.bus_number.has_value() || !args.config.host.has_value()) {
     throw std::invalid_argument("Missing required configuration parameters");
@@ -114,7 +114,7 @@ CanReturnCode CanVendorAnagate::vendor_open() noexcept {
                   high_speed, enable_timestamp);
     CANSetCallback(m_handle,
                    reinterpret_cast<CAN_PF_CALLBACK>(anagate_receive));
-  } catch (const std::exception &e) {
+  } catch (const std::exception& e) {
     LOG(Log::ERR, CanLogIt::h())
         << "Exception caught in vendor_open: " << e.what();
     return CanReturnCode::internal_api_error;
@@ -164,7 +164,7 @@ CanReturnCode CanVendorAnagate::vendor_open() noexcept {
  * indicates success, while a non-zero value indicates an error. The specific
  * meaning of the error code can be obtained by calling CANGetLastError.
  */
-CanReturnCode CanVendorAnagate::vendor_send(const CanFrame &frame) noexcept {
+CanReturnCode CanVendorAnagate::vendor_send(const CanFrame& frame) noexcept {
   if (m_handle == 0) {
     LOG(Log::ERR, CanLogIt::h()) << "Cannot send frame: Device not open";
     return CanReturnCode::disconnected;
@@ -182,7 +182,7 @@ CanReturnCode CanVendorAnagate::vendor_send(const CanFrame &frame) noexcept {
                        frame.length(), anagate_flags)
             : CANWrite(m_handle, frame.id(), frame.message().data(),
                        frame.length(), anagate_flags);
-  } catch (const std::exception &e) {
+  } catch (const std::exception& e) {
     LOG(Log::ERR, CanLogIt::h())
         << "Exception caught in vendor_send: " << e.what();
     return CanReturnCode::internal_api_error;
@@ -230,7 +230,7 @@ CanReturnCode CanVendorAnagate::vendor_send(const CanFrame &frame) noexcept {
 CanDiagnostics CanVendorAnagate::vendor_diagnostics() noexcept {
   auto anagate_convert_timestamp = [](AnaInt64 timestamp) {
     std::time_t time = static_cast<std::time_t>(timestamp);
-    std::tm *local_time = std::localtime(&time);
+    std::tm* local_time = std::localtime(&time);
     std::ostringstream timestamp_stream;
     timestamp_stream << std::put_time(local_time, "%Y-%m-%d %H:%M:%S");
     return timestamp_stream.str();
@@ -344,7 +344,7 @@ CanDiagnostics CanVendorAnagate::vendor_diagnostics() noexcept {
 
     diagnostics.handle = m_handle;
     return diagnostics;
-  } catch (const std::exception &e) {
+  } catch (const std::exception& e) {
     LOG(Log::ERR, CanLogIt::h())
         << "Exception caught in vendor_diagnostics: " << e.what();
     return diagnostics;
diff --git a/src/main/CanVendorLoopback.cpp b/src/main/CanVendorLoopback.cpp
@@ -9,7 +9,7 @@
  * @param frame The CAN frame to be sent.
  * @return Always returns 0 indicating success.
  */
-CanReturnCode CanVendorLoopback::vendor_send(const CanFrame &frame) noexcept {
+CanReturnCode CanVendorLoopback::vendor_send(const CanFrame& frame) noexcept {
   received(frame);
   return CanReturnCode::success;
 }
diff --git a/src/main/CanVendorSocketCan.cpp b/src/main/CanVendorSocketCan.cpp
@@ -29,7 +29,7 @@ constexpr auto LIBSOCKETCAN_SUCCESS = 0;
  * @param args A constant reference to the CanDeviceArguments object,
  * which contains the arguments for the CAN device.
  */
-CanVendorSocketCan::CanVendorSocketCan(const CanDeviceArguments &args)
+CanVendorSocketCan::CanVendorSocketCan(const CanDeviceArguments& args)
     : CanDevice("socketcan", args) {
   if (!args.config.bus_name.has_value()) {
     throw std::invalid_argument("Missing required configuration parameters");
@@ -101,7 +101,7 @@ CanReturnCode CanVendorSocketCan::vendor_open() noexcept {
   addr.can_family = AF_CAN;
   addr.can_ifindex = ifr.ifr_ifindex;
 
-  if (bind(m_socket_fd, (struct sockaddr *)&addr, sizeof(addr)) < 0) {
+  if (bind(m_socket_fd, (struct sockaddr*)&addr, sizeof(addr)) < 0) {
     ::close(m_socket_fd);
     m_socket_fd = -1;
     LOG(Log::ERR, CanLogIt::h()) << "Failed to bind socket";
@@ -191,7 +191,7 @@ CanReturnCode CanVendorSocketCan::vendor_close() noexcept {
  * @return int Returns 0 on success, or -1 if the entire frame could not be
  * sent.
  */
-CanReturnCode CanVendorSocketCan::vendor_send(const CanFrame &frame) noexcept {
+CanReturnCode CanVendorSocketCan::vendor_send(const CanFrame& frame) noexcept {
   // Translate CanFrame to struct can_frame
   struct can_frame canFrame = translate(frame);
 
@@ -307,7 +307,7 @@ CanDiagnostics CanVendorSocketCan::vendor_diagnostics() noexcept {
  *
  * @return struct can_frame The translated CAN frame.
  */
-struct can_frame CanVendorSocketCan::translate(const CanFrame &frame) noexcept {
+struct can_frame CanVendorSocketCan::translate(const CanFrame& frame) noexcept {
   struct can_frame canFrame;
   canFrame.can_id = frame.id();
   canFrame.len = frame.length();
@@ -343,7 +343,7 @@ struct can_frame CanVendorSocketCan::translate(const CanFrame &frame) noexcept {
  * @return CanFrame The translated CanFrame object.
  */
 const CanFrame CanVendorSocketCan::translate(
-    const struct can_frame &canFrame) noexcept {
+    const struct can_frame& canFrame) noexcept {
   const auto id = canFrame.can_id & CAN_EFF_MASK;
   const auto length = static_cast<uint32_t>(canFrame.len);
   const auto rtr = (canFrame.can_id & CAN_RTR_FLAG);
diff --git a/src/main/CanVendorSocketCanSystec.cpp b/src/main/CanVendorSocketCanSystec.cpp
@@ -23,10 +23,10 @@
  * callback function.
  */
 CanVendorSocketCanSystec::CanVendorSocketCanSystec(
-    const CanDeviceArguments &args)
+    const CanDeviceArguments& args)
     : CanDevice("socketcan_systec", args) {
-  const std::function<void(const CanFrame &)> filter_busoff_callback =
-      [this](const CanFrame &frame) {
+  const std::function<void(const CanFrame&)> filter_busoff_callback =
+      [this](const CanFrame& frame) {
         if (frame.is_error() && (frame.id() & CAN_ERR_BUSERROR)) {
           LOG(Log::WRN, CanLogIt::h()) << "Bus off detected, restarting...";
           m_can_vendor_socketcan->close();
@@ -99,7 +99,7 @@ CanReturnCode CanVendorSocketCanSystec::vendor_close() noexcept {
  *           is returned.
  */
 CanReturnCode CanVendorSocketCanSystec::vendor_send(
-    const CanFrame &frame) noexcept {
+    const CanFrame& frame) noexcept {
   if (m_can_vendor_socketcan) return m_can_vendor_socketcan->send(frame);
   return CanReturnCode::internal_api_error;
 }
diff --git a/src/python/CanModule.cpp b/src/python/CanModule.cpp
@@ -18,11 +18,10 @@ PYBIND11_MODULE(canmodule, m) {
       .def(py::init<const uint32_t, const uint32_t>(), py::arg("id"),
            py::arg("requested_length"))
       .def(py::init<const uint32_t>(), py::arg("id"))
-      .def(py::init<const uint32_t, const std::vector<char> &>(), py::arg("id"),
+      .def(py::init<const uint32_t, const std::vector<char>&>(), py::arg("id"),
            py::arg("message"))
-      .def(
-          py::init<const uint32_t, const std::vector<char> &, const uint32_t>(),
-          py::arg("id"), py::arg("message"), py::arg("flags"))
+      .def(py::init<const uint32_t, const std::vector<char>&, const uint32_t>(),
+           py::arg("id"), py::arg("message"), py::arg("flags"))
       .def("id", &CanFrame::id)
       .def("message", &CanFrame::message)
       .def("flags", &CanFrame::flags)
@@ -62,15 +61,15 @@ PYBIND11_MODULE(canmodule, m) {
       .def("open", &CanDevice::open)
       .def("close", &CanDevice::close)
       .def("diagnostics", &CanDevice::diagnostics)
-      .def("send", py::overload_cast<const CanFrame &>(&CanDevice::send))
+      .def("send", py::overload_cast<const CanFrame&>(&CanDevice::send))
       .def("send",
-           py::overload_cast<const std::vector<CanFrame> &>(&CanDevice::send))
+           py::overload_cast<const std::vector<CanFrame>&>(&CanDevice::send))
       .def("args", &CanDevice::args)
       .def_static("create", &CanDevice::create);
 
   py::class_<CanDeviceArguments>(m, "CanDeviceArguments")
-      .def(py::init<const CanDeviceConfiguration &,
-                    const std::function<void(const CanFrame &)> &>(),
+      .def(py::init<const CanDeviceConfiguration&,
+                    const std::function<void(const CanFrame&)>&>(),
            py::arg("config"), py::arg("receiver") = nullptr)
       .def_readonly("config", &CanDeviceArguments::config);
 
diff --git a/test/cpp/CanFrame_test.cpp b/test/cpp/CanFrame_test.cpp
diff --git a/test/python/test_anagate.py b/test/python/test_anagate.py
