v0.2.0 release prep: 8 fixes for ship-blocker QA findings (#44)

* feat: release-blocker bundle for v0.2.0 (#17 #18 #21 #16 #15 #23 #39 #40)

Bundles eight ship-blocker fixes called out in the QA triage on main:

- **#39 session cache (major):** persist auth/cookies to
  $XDG_CACHE_HOME/crono-export/session.json (mode 0600), retry-on-stale,
  CRONOMETER_NO_CACHE escape hatch, new `auth logout` subcommand. Fixes
  the rate-limit foot-gun where 5–6 back-to-back calls trip Cronometer's
  throttle. Also de-duplicates the "login failed: login failed:" wrap.
- **#17 typed nutrition/notes JSON (breaking):** csvToJSON now returns
  []map[string]any with best-effort coercion (numeric → float64,
  true/false → bool, empty → null). Drops the contract drift where two
  of five subcommands forced jq `tonumber` on every column.
- **#15 + #23 validation before login:** Args=cobra.NoArgs + a PreRunE
  that calls chosenFormat — bad --format / positional args now exit
  fast without burning a Cronometer login attempt.
- **#16 + #18 + #21 contract-violation trio:** empty markdown is silent
  on stdout (friendly note → stderr); --until alone uses 7d window
  ending at --until (was 1-day); inverted --since/--until warns to
  stderr and returns empty + exit 0 (was non-zero error).
- **#40 VitaminDIU cosmetic:** strippedSuffix table had "UI" instead of
  the standard "IU" abbreviation; vitamin D markdown was rendering
  without splitting the unit. Added TestStrippedSuffix to cover.
- **#19 closed as part-fixed/part-wontfix:** zone-as-UTC was already
  fixed by the clean-room rewrite (#37); the wire CSV carries no
  time-of-day to surface. Documented in prime GOTCHAS.

New tests cover: strippedSuffix (cmd), resolveDateRange (cronoclient),
coerceCSVValue + csvToJSON (cronoclient), session cache round-trip
(cronoclient).

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>

* fixup: address PR review — README, gofmt, cache schema version

Review feedback on #44:

- **Must fix #1: README.md stale.** Replaced the "no token cache"
  paragraph with the cache location ($XDG_CACHE_HOME), the
  CRONOMETER_NO_CACHE opt-out, the `auth logout` subcommand, and a
  security note ("treat session.json like a password").  Folds in the
  reviewer's nice-to-have #5 (security guidance) at the same time.

- **Must fix #2: gofmt.**  Ran `gofmt -w` on `cmd/format.go` and
  `internal/cronoclient/daterange_test.go` (trailing blank line + struct
  field alignment).  `internal/cronoapi/gwt.go` is also flagged but is
  pre-existing from #37 — landed as a separate chore commit so this
  PR's diff stays scoped to release-blocker work.

- **Nice-to-have #4: cache schema version.**  Added
  `cacheSchemaVersion = 1` and a `Version int` field on cachedSession.
  Old/mismatched versions are silently treated as a miss so a future
  incompatible bump triggers a transparent re-login instead of a
  JSON-shape error.  New test: TestSessionCacheVersionMismatch.

Skipped: race on concurrent fresh logins (#6) — reviewer agreed this is
fine for a single-user CLI.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>

* chore: gofmt internal/cronoapi/gwt.go (preexisting drift from #37)

Pure formatting: column-aligned const block and var block. No logic change.
Flagged by `gofmt -l .` during review of #44.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]>

Author: DTTerastar

.gitignore

@@ -48,3 +48,4 @@ cronometer-capture/
 tools/wirecapture/captures/
 tools/wirecapture/wirecapture
 *.unredacted.json
+.DS_Store

README.md

@@ -78,7 +78,17 @@ export CRONOMETER_USERNAME="[email protected]"
 export CRONOMETER_PASSWORD="your-cronometer-password"
 ```
 
-The CLI logs in on every invocation; there's no token cache. Cronometer doesn't (yet) offer SSO or API tokens for individuals, so a real password is the only auth option.
+Cronometer doesn't (yet) offer SSO or API tokens for individuals, so a real password is the only auth option.
+
+After the first successful login, the session (auth token + cookies) is cached at `$XDG_CACHE_HOME/crono-export/session.json` (file mode `0600`, directory mode `0700`; on macOS this resolves to `~/Library/Caches/crono-export/session.json`). Subsequent invocations reuse the cached session and skip the login handshake — useful for LLM-agent workflows that fire several commands in quick succession (a fresh login on every call trips Cronometer's "Too Many Attempts" throttle after ~6 requests). When the cached session goes stale, the CLI transparently re-logs in and retries once.
+
+Escape hatches:
+
+- `CRONOMETER_NO_CACHE=1` forces a fresh login on every invocation (and skips writing the cache).
+- `crono-export auth logout` deletes the cached session.
+- `crono-export auth status` reports whether credentials are set and whether a session is cached.
+
+Treat `session.json` like a password: don't sync it to a shared backup, and don't commit it.
 
 ## Usage
 

cmd/auth.go

@@ -5,6 +5,8 @@ import (
 	"os"
 
 	"github.com/spf13/cobra"
+
+	"github.com/quantcli/crono-export-cli/internal/cronoclient"
 )
 
 var authCmd = &cobra.Command{
@@ -36,12 +38,46 @@ https://github.com/quantcli/common/blob/main/CONTRACT.md#5-auth`,
 		case pass == "":
 			return fmt.Errorf("missing CRONOMETER_PASSWORD")
 		}
-		fmt.Fprintf(cmd.OutOrStdout(), "credentials present for %s (env-var auth, no token cache)\n", user)
+		cacheState := "no cache"
+		if os.Getenv("CRONOMETER_NO_CACHE") == "" {
+			if p := cronoclient.SessionCachePath(); p != "" {
+				if _, err := os.Stat(p); err == nil {
+					cacheState = "session cached"
+				} else {
+					cacheState = "no session cached"
+				}
+			}
+		} else {
+			cacheState = "cache disabled (CRONOMETER_NO_CACHE set)"
+		}
+		fmt.Fprintf(cmd.OutOrStdout(), "credentials present for %s (%s)\n", user, cacheState)
+		return nil
+	},
+}
+
+var authLogoutCmd = &cobra.Command{
+	Use:   "logout",
+	Short: "Delete the cached Cronometer session, forcing a fresh login next call",
+	Long: `Remove the on-disk session cache at $XDG_CACHE_HOME/crono-export/session.json.
+Useful after rotating your password or when you suspect a stale session
+is causing failures.
+
+This is a local-only operation: it does NOT call Cronometer's logout
+endpoint (that would invalidate the cached cookies for a session we've
+already deleted). The next export call will perform a fresh login.`,
+	Args: cobra.NoArgs,
+	RunE: func(cmd *cobra.Command, _ []string) error {
+		p, err := cronoclient.DeleteCachedSession()
+		if err != nil {
+			return err
+		}
+		fmt.Fprintf(cmd.OutOrStdout(), "session cache cleared (%s)\n", p)
 		return nil
 	},
 }
 
 func init() {
 	authCmd.AddCommand(authStatusCmd)
+	authCmd.AddCommand(authLogoutCmd)
 	rootCmd.AddCommand(authCmd)
 }

cmd/biometrics.go

@@ -7,13 +7,18 @@ import (
 )
 
 var biometricsCmd = &cobra.Command{
-	Use:   "biometrics",
-	Short: "Export biometric records (weight, body fat, blood pressure, custom metrics)",
+	Use:     "biometrics",
+	Short:   "Export biometric records (weight, body fat, blood pressure, custom metrics)",
+	Args:    cobra.NoArgs,
+	PreRunE: ValidateExportFlags,
 	RunE: func(cmd *cobra.Command, _ []string) error {
 		rng, err := cronoclient.ParseDateRangeFromFlags(cmd)
 		if err != nil {
 			return err
 		}
+		if rng.IsEmpty() {
+			return emit(cmd, kindBiometrics, emptyValueFor(kindBiometrics))
+		}
 		ctx := cmd.Context()
 		c, err := cronoclient.NewLoggedIn(ctx)
 		if err != nil {

cmd/exercises.go

@@ -7,13 +7,18 @@ import (
 )
 
 var exercisesCmd = &cobra.Command{
-	Use:   "exercises",
-	Short: "Export logged exercises (cardio, strength, custom activities)",
+	Use:     "exercises",
+	Short:   "Export logged exercises (cardio, strength, custom activities)",
+	Args:    cobra.NoArgs,
+	PreRunE: ValidateExportFlags,
 	RunE: func(cmd *cobra.Command, _ []string) error {
 		rng, err := cronoclient.ParseDateRangeFromFlags(cmd)
 		if err != nil {
 			return err
 		}
+		if rng.IsEmpty() {
+			return emit(cmd, kindExercises, emptyValueFor(kindExercises))
+		}
 		ctx := cmd.Context()
 		c, err := cronoclient.NewLoggedIn(ctx)
 		if err != nil {

cmd/format.go

@@ -31,6 +31,16 @@ func AddFormatFlags(cmd *cobra.Command) {
 		"Output format: markdown (default, fitdown-style) or json")
 }
 
+// ValidateExportFlags is a PreRunE that fails fast on bad --format or date
+// flags before any network call is made. Without this, a typo in --format
+// would burn a Cronometer login attempt against the rate limit.
+func ValidateExportFlags(cmd *cobra.Command, _ []string) error {
+	if _, err := chosenFormat(cmd); err != nil {
+		return err
+	}
+	return nil
+}
+
 func chosenFormat(cmd *cobra.Command) (string, error) {
 	f, _ := cmd.Flags().GetString("format")
 	switch f {
@@ -70,20 +80,40 @@ func renderMarkdown(w io.Writer, kind recordKind, v any) error {
 		recs, _ := v.(cronoapi.ExerciseRecords)
 		return renderExercises(w, recs)
 	case kindNutrition:
-		rows, _ := v.([]map[string]string)
+		rows, _ := v.([]map[string]any)
 		return renderNutrition(w, rows)
 	case kindNotes:
-		rows, _ := v.([]map[string]string)
+		rows, _ := v.([]map[string]any)
 		return renderNotes(w, rows)
 	}
 	return fmt.Errorf("renderMarkdown: unknown kind %d", kind)
 }
 
 // ---- shared helpers ---------------------------------------------------
 
-func emptyMsg(w io.Writer) error {
-	_, err := fmt.Fprintln(w, "_(no records in window)_")
-	return err
+// noteEmpty writes a friendly "no records" note to stderr so humans see it,
+// while keeping stdout clean per the contract's "data only on stdout" rule.
+// w is ignored — kept for the renderer signatures.
+func noteEmpty(_ io.Writer) error {
+	fmt.Fprintln(os.Stderr, "(no records in window)")
+	return nil
+}
+
+// emptyValueFor returns the typed empty value for a record kind.  Used
+// when the caller knows there are no records (e.g. inverted date range)
+// and wants to emit them without making a network call.
+func emptyValueFor(kind recordKind) any {
+	switch kind {
+	case kindServings:
+		return cronoapi.ServingRecords{}
+	case kindBiometrics:
+		return cronoapi.BiometricRecords{}
+	case kindExercises:
+		return cronoapi.ExerciseRecords{}
+	case kindNutrition, kindNotes:
+		return []map[string]any{}
+	}
+	return nil
 }
 
 // fmtFloat trims trailing zeros so 1.95 → "1.95" and 100.000 → "100".
@@ -103,7 +133,7 @@ func strippedSuffix(field string) (name, unit string) {
 		{"Kcal", "kcal"},
 		{"Mg", "mg"},
 		{"Ug", "µg"},
-		{"UI", "IU"},
+		{"IU", "IU"},
 		{"G", "g"},
 	} {
 		if strings.HasSuffix(field, suf.go_) && len(field) > len(suf.go_) {
@@ -117,7 +147,7 @@ func strippedSuffix(field string) (name, unit string) {
 
 func renderServings(w io.Writer, recs cronoapi.ServingRecords) error {
 	if len(recs) == 0 {
-		return emptyMsg(w)
+		return noteEmpty(w)
 	}
 	// Group by local calendar date.
 	byDate := map[string][]cronoapi.ServingRecord{}
@@ -194,7 +224,7 @@ func strDefault(s, fallback string) string {
 
 func renderBiometrics(w io.Writer, recs cronoapi.BiometricRecords) error {
 	if len(recs) == 0 {
-		return emptyMsg(w)
+		return noteEmpty(w)
 	}
 	byDate := map[string][]cronoapi.BiometricRecord{}
 	for _, r := range recs {
@@ -226,7 +256,7 @@ func renderBiometrics(w io.Writer, recs cronoapi.BiometricRecords) error {
 
 func renderExercises(w io.Writer, recs cronoapi.ExerciseRecords) error {
 	if len(recs) == 0 {
-		return emptyMsg(w)
+		return noteEmpty(w)
 	}
 	byDate := map[string][]cronoapi.ExerciseRecord{}
 	for _, r := range recs {
@@ -263,19 +293,19 @@ func renderExercises(w io.Writer, recs cronoapi.ExerciseRecords) error {
 
 // ---- nutrition (daily totals, string-keyed CSV) ----------------------
 
-func renderNutrition(w io.Writer, rows []map[string]string) error {
+func renderNutrition(w io.Writer, rows []map[string]any) error {
 	if len(rows) == 0 {
-		return emptyMsg(w)
+		return noteEmpty(w)
 	}
 	// Sort by Date asc.
 	sort.SliceStable(rows, func(i, j int) bool {
-		return rows[i]["Date"] < rows[j]["Date"]
+		return cellString(rows[i]["Date"]) < cellString(rows[j]["Date"])
 	})
 	for di, row := range rows {
 		if di > 0 {
 			fmt.Fprintln(w)
 		}
-		date := row["Date"]
+		date := cellString(row["Date"])
 		if date == "" {
 			date = "(unknown date)"
 		}
@@ -294,42 +324,54 @@ func renderNutrition(w io.Writer, rows []map[string]string) error {
 			if isZeroish(v) {
 				continue
 			}
-			fmt.Fprintf(w, "- %s: %s\n", k, v)
+			fmt.Fprintf(w, "- %s: %s\n", k, cellString(v))
 		}
 	}
 	fmt.Fprintln(w)
 	fmt.Fprintln(w, "_zero-valued nutrients omitted; use --format json for the full row_")
 	return nil
 }
 
-// isZeroish reports whether a CSV value should be treated as "no data" and
-// hidden from the markdown output.  Empty strings, "0", "0.0", "0.00", etc.
-// are zeroish; everything else (including "false", "true", arbitrary text)
-// is rendered.
-func isZeroish(s string) bool {
-	if s == "" {
-		return true
-	}
-	// Try numeric: if it parses to 0, it's zeroish.
-	var f float64
-	if _, err := fmt.Sscanf(s, "%f", &f); err == nil && f == 0 {
-		// But only if the entire string was numeric.
-		t := strings.TrimSpace(s)
-		for _, r := range t {
-			if !(r >= '0' && r <= '9') && r != '.' && r != '-' && r != '+' {
-				return false
-			}
+// cellString renders a coerced CSV cell back to a display string.  Floats
+// drop trailing zeros so "1.5" stays "1.5" and "100" stays "100".
+func cellString(v any) string {
+	switch x := v.(type) {
+	case nil:
+		return ""
+	case string:
+		return x
+	case float64:
+		return fmtFloat(x)
+	case bool:
+		if x {
+			return "true"
 		}
+		return "false"
+	default:
+		return fmt.Sprintf("%v", x)
+	}
+}
+
+// isZeroish reports whether a coerced CSV value should be hidden from the
+// markdown output: nil, empty string, or numeric zero.  "false" / "true" /
+// arbitrary text is rendered.
+func isZeroish(v any) bool {
+	switch x := v.(type) {
+	case nil:
 		return true
+	case string:
+		return x == ""
+	case float64:
+		return x == 0
 	}
 	return false
 }
 
 // ---- notes ------------------------------------------------------------
 
-func renderNotes(w io.Writer, rows []map[string]string) error {
+func renderNotes(w io.Writer, rows []map[string]any) error {
 	if len(rows) == 0 {
-		return emptyMsg(w)
+		return noteEmpty(w)
 	}
 	dateKey := pickKey(rows[0], "Day", "Date")
 	noteKey := pickKey(rows[0], "Note", "Notes", "Comment")
@@ -339,36 +381,35 @@ func renderNotes(w io.Writer, rows []map[string]string) error {
 		if di > 0 {
 			fmt.Fprintln(w)
 		}
-		date := row[dateKey]
+		date := cellString(row[dateKey])
 		if date == "" {
 			date = "(unknown date)"
 		}
 		header := "## " + date
-		if t := row[timeKey]; t != "" {
+		if t := cellString(row[timeKey]); t != "" {
 			header += " " + t
 		}
 		fmt.Fprintln(w, header)
-		if note := strings.TrimSpace(row[noteKey]); note != "" {
+		if note := strings.TrimSpace(cellString(row[noteKey])); note != "" {
 			fmt.Fprintln(w, note)
 		} else {
 			// Fall back to dumping all non-empty fields if we can't find a Note column.
 			for k, v := range row {
-				if k == dateKey || k == timeKey || v == "" {
+				if k == dateKey || k == timeKey || isZeroish(v) {
 					continue
 				}
-				fmt.Fprintf(w, "- %s: %s\n", k, v)
+				fmt.Fprintf(w, "- %s: %s\n", k, cellString(v))
 			}
 		}
 	}
 	return nil
 }
 
-func pickKey(row map[string]string, candidates ...string) string {
+func pickKey(row map[string]any, candidates ...string) string {
 	for _, c := range candidates {
 		if _, ok := row[c]; ok {
 			return c
 		}
 	}
 	return ""
 }
-

cmd/format_test.go

@@ -0,0 +1,25 @@
+package cmd
+
+import "testing"
+
+func TestStrippedSuffix(t *testing.T) {
+	cases := []struct {
+		field, wantName, wantUnit string
+	}{
+		{"EnergyKcal", "Energy", "kcal"},
+		{"CarbsG", "Carbs", "g"},
+		{"CalciumMg", "Calcium", "mg"},
+		{"VitaminAUg", "VitaminA", "µg"},
+		{"VitaminDIU", "VitaminD", "IU"},
+		{"PolyunsaturatedG", "Polyunsaturated", "g"},
+		{"Group", "Group", ""},
+		{"G", "G", ""},
+	}
+	for _, c := range cases {
+		gotName, gotUnit := strippedSuffix(c.field)
+		if gotName != c.wantName || gotUnit != c.wantUnit {
+			t.Errorf("strippedSuffix(%q) = (%q, %q), want (%q, %q)",
+				c.field, gotName, gotUnit, c.wantName, c.wantUnit)
+		}
+	}
+}