Follow-up from #27. The core completion resolver handles alias.column for every case in #27 except implicit alias shadowing when the same alias name is bound at multiple nesting levels within a single statement.
Repro
Two tests live in crates/flowscope-core/tests/completion_items.rs, currently #[ignore]-d:
alias_shadowing_inner_subquery_wins — inner SELECT 1 FROM orders u shadows outer SELECT * FROM users u; cursor at inner u. should only surface orders columns (total), never users columns (email). Today it surfaces both.alias_shadowing_outer_scope_unaffected — cursor at the outer u. after a shadowing subquery should still only surface users columns. Today it also surfaces the inner-scope shadow (total).
Working baseline for reference: alias_shadowing_across_statements (unignored, passing) — two statements separated by ; each bind alias t to a different table; statement 2 resolves correctly. Statement-level isolation is already robust.
Root cause (working theory)
crates/flowscope-core/src/completion/ast_extractor.rs produces a flat tables_in_scope: Vec<CompletionTable> — every FROM/JOIN/subquery entry is collected without scope-depth tagging. resolve_qualifier in context.rs:1417 then matches aliases across the full vector, so both bindings of a shadowed alias appear.
Fix direction: tag each entry with a scope identifier (or the enclosing SELECT node) and, before resolution, filter to scopes that enclose the cursor — picking the innermost on ambiguity.
Acceptance
Un-`#[ignore]` the two tests and get `cargo test -p flowscope-core --test completion_items alias_shadowing` green.
Follow-up from #27. The core completion resolver handles
alias.columnfor every case in #27 except implicit alias shadowing when the same alias name is bound at multiple nesting levels within a single statement.Repro
Two tests live in
crates/flowscope-core/tests/completion_items.rs, currently#[ignore]-d:alias_shadowing_inner_subquery_wins— innerSELECT 1 FROM orders ushadows outerSELECT * FROM users u; cursor at inneru.should only surfaceorderscolumns (total), neveruserscolumns (email). Today it surfaces both.alias_shadowing_outer_scope_unaffected— cursor at the outeru.after a shadowing subquery should still only surfaceuserscolumns. Today it also surfaces the inner-scope shadow (total).Working baseline for reference:
alias_shadowing_across_statements(unignored, passing) — two statements separated by;each bind aliastto a different table; statement 2 resolves correctly. Statement-level isolation is already robust.Root cause (working theory)
crates/flowscope-core/src/completion/ast_extractor.rsproduces a flattables_in_scope: Vec<CompletionTable>— every FROM/JOIN/subquery entry is collected without scope-depth tagging.resolve_qualifierincontext.rs:1417then matches aliases across the full vector, so both bindings of a shadowed alias appear.Fix direction: tag each entry with a scope identifier (or the enclosing SELECT node) and, before resolution, filter to scopes that enclose the cursor — picking the innermost on ambiguity.
Acceptance
Un-`#[ignore]` the two tests and get `cargo test -p flowscope-core --test completion_items alias_shadowing` green.